[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-03 Thread Darin Fisher
We should definitely eliminate the need for the renderer to refer directly to its native view. I have been gradually working in this direction. Instead of sending view ids around, it should be enough to reference the render_view_id (i.e., routing_id). We don't need to graph this mapping onto Rend

[chromium-dev] Re: Disable plugin

2009-05-03 Thread Mohamed Mansour
Hi, I have answered your question there (the link you provided). This is mainly a development mailing list, where developers talk with each other on ways how to improve chromium. The help forum is a great way to ask these questions because there might be another user with the same question :) If

[chromium-dev] Re: Disable plugin

2009-05-03 Thread Robert Dailey
On Sun, May 3, 2009 at 11:47 PM, Peter Kasting wrote: > On Sun, May 3, 2009 at 9:39 PM, Robert Dailey wrote: > >> I'm asking on the dev list because I do not feel I will get my answer >> anywhere else. >> > > Not only will asking here not necessarily get you an answer but it will > waste our tim

[chromium-dev] Re: Disable plugin

2009-05-03 Thread Peter Kasting
On Sun, May 3, 2009 at 9:39 PM, Robert Dailey wrote: > I'm asking on the dev list because I do not feel I will get my answer > anywhere else. > Not only will asking here not necessarily get you an answer but it will waste our time as we try and implement things people need and want. We have hel

[chromium-dev] Re: Disable plugin

2009-05-03 Thread Robert Dailey
Well for sure I see several unanswered inquiries, and I do not feel like adding more to that pile. For example, here's someone with my exact question and he still needs an answer: http://www.google.com/support/forum/p/Chrome/thread?tid=352869505fd18061&hl=en

[chromium-dev] Re: Disable plugin

2009-05-03 Thread Evan Martin
Please ask the help forum first. http://www.google.com/support/chrome/?hl=en On Sun, May 3, 2009 at 9:00 PM, Robert Dailey wrote: > > Hi, > > How can I disable the Windows Media Player plugin in about:plugins? I > really hate that when I click an MP3 link it opens in Windows Media > Player :( >

[chromium-dev] Disable plugin

2009-05-03 Thread Robert Dailey
Hi, How can I disable the Windows Media Player plugin in about:plugins? I really hate that when I click an MP3 link it opens in Windows Media Player :( --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change emai

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-03 Thread Adam Barth
On Sun, May 3, 2009 at 7:50 PM, Evan Martin wrote: > Look at base/gfx/gtk_native_view_id_manager -- it implements #2 for GTK. Interesting. That's similar to what I had in mind, but not quite as tight in the sense that it lets one renderer interact with view_ids from another renderer. For those

[chromium-dev] Re: gfx::NativeViewId and IPC

2009-05-03 Thread Evan Martin
Look at base/gfx/gtk_native_view_id_manager -- it implements #2 for GTK. I like both approaches, but would really prefer #1. Adam implemented #2 in part for security but also in part because our initialization order made it a pain to have a native view id handy at the point the render view is ge

[chromium-dev] gfx::NativeViewId and IPC

2009-05-03 Thread Adam Barth
Currently we have a handful of renderer -> browser IPC messages that contain gfx::NativeViewIds: ViewHostMsg_GetWindowRect ViewHostMsg_GetScreenInfo ViewHostMsg_GetRootWindowRect ViewHostMsg_GetRootWindowResizerRect ViewHostMsg_ScriptedPrint These make me sad because the render could ask about r

[chromium-dev] Re: depot_tools is moving!

2009-05-03 Thread Darin Fisher
On Fri, May 1, 2009 at 1:34 PM, Marc-Antoine Ruel wrote: > gcl, gclient and friends are moving from > http://src.chromium.org/svn/trunk/depot_tools/ to > http://src.chromium.org/svn/trunk/tools/depot_tools/ > > To help you with the switch, there is now a little script to switch > automatically. Ju

[chromium-dev] Re: Plugin painting and deadlock

2009-05-03 Thread Darin Fisher
Painting is not the only issue. On Windows there are several ways in which the thread responsible for a HWND can block waiting for the thread responsible for a child HWND to respond. Are you sure there are no X calls that block in a similar fashion? Are there no cases where you can query somethi

[chromium-dev] Re: Read me: When checking in patches for someone else

2009-05-03 Thread Peter Kasting
2009/5/3 Evan Martin > On Sun, May 3, 2009 at 10:57 AM, Paweł Hajdan Jr. > wrote: > > How should I check whether someone has filed the CLA if it's his first > patch > > going to be committed? > > I don't know if there's a way to verify. I just ask if they're not in > the AUTHORS file and put th

[chromium-dev] Re: Read me: When checking in patches for someone else

2009-05-03 Thread Evan Martin
On Sun, May 3, 2009 at 10:57 AM, Paweł Hajdan Jr. wrote: > How should I check whether someone has filed the CLA if it's his first patch > going to be committed? I don't know if there's a way to verify. I just ask if they're not in the AUTHORS file and put them in with their first commit after t

[chromium-dev] Plugin painting and deadlock

2009-05-03 Thread Evan Martin
Two statements of fact first, and then a proposal afterwards. Please correct my facts if I'm wrong. 1) On Windows, when you have a windowed plugin and paint the main window, it synchronously (?) paints the child windows including plugins. (This is the major point I'm unsure about; I don't unders

[chromium-dev] Re: Read me: When checking in patches for someone else

2009-05-03 Thread Paweł Hajdan Jr .
How should I check whether someone has filed the CLA if it's his first patch going to be committed? On Sun, May 3, 2009 at 17:23, Evan Martin wrote: > I typically paste that in from the AUTHORS file (which is a good extra > check on whether someone has filed the CLA). --~--~-~--~~--

[chromium-dev] Re: Read me: When checking in patches for someone else

2009-05-03 Thread Evan Martin
If you're using git, I typically do: git cl patch -b 12345 where the number is the CL number. This patches in the change and makes the new branch use up the CL number of the original review, which will then be included in your commit. (If you want to fix the issue mapping of a branch later du

[chromium-dev] Read me: When checking in patches for someone else

2009-05-03 Thread Peter Kasting
If you check in patches for someone else, please do the following:* Mention the person who wrote the patch. * Since your gcl change is not the same Rietveld issue as the original review, put a link to the original review in your change description. * Put a BUG= or http://crbug.com/... line in so th

[chromium-dev] Re: BUG= formatting

2009-05-03 Thread Mark Larson (Google)
On Thu, Apr 30, 2009 at 14:06, Wan-Teh Chang wrote: > > On Thu, Apr 30, 2009 at 1:50 PM, Ben Goodger (Google) > wrote: > > > > Hint: > > > > If you write your changelist bug line like this: > > > > http://crbug.com/7991 > > > > instead of like this: > > > > BUG=7991 > > > > your bug line will be

[chromium-dev] Re: Nomination for chromium account?

2009-05-03 Thread Mark Larson (Google)
Thanks for all the bug fixes! I'll bring this up with committ...@chromium.org and let you know how it goes. --Mark On Thu, Apr 30, 2009 at 16:50, Shinichiro Hamaji wrote: > > Hi, > > I'm Shinichiro, working on chromium recently, and fixing chromium bugs > to learn the code base of chromium. As