[chromium-dev] Re: Getting Started with a New Project
Yes, I tried adding that project but it didn't seem to help. On 19 July, 20:49, Thiago Farina thiago.far...@gmail.com wrote: Did you added the common project to your solution? On Jul 19, 12:40 pm, Kruncher leaha...@gmail.com wrote: For the purposes of practice I am trying to create an empty Win32 Exe project that uses the demonstration code from: http://dev.chromium.org/developers/design-documents/chromeviews To do this I have created a new solution and an empty project. I have then added the demonstration code, and in the project settings added the additional include/lib directories (which I copied from an Exe project from the Chromium trunk). However, when I try to build the project, I get the following compilation error: 1c:\chromium\src\quick_test\quick_test\views\main_window.cc(4) : fatal error C1083: Cannot open include file: 'chrome/common/gfx/ chrome_canvas.h': No such file or directory What steps are required to create a new solution/project of this nature? I would really like to use the views API that Chromium has to offer. Many thanks, Lea Hayes --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
I notice that Greg Badros, www.badros.com/greg/doc/resume.html, is at Google now since March. I'd love to see him implement Constraint CSS (CCSS) in chrome, www.badros.com/greg/papers/css-uist99.pdf, and get the support and recognition it deserves. what is he working on? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
You are too late, as this article describes. http://www.techcrunch.com/2009/06/12/facebook-nabs-googles-senior-director-of-engineering/ On Mon, Jul 20, 2009 at 3:12 PM, darrel karischdkari...@gmail.com wrote: I notice that Greg Badros, www.badros.com/greg/doc/resume.html, is at Google now since March. I'd love to see him implement Constraint CSS (CCSS) in chrome, www.badros.com/greg/papers/css-uist99.pdf, and get the support and recognition it deserves. what is he working on? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
that's unfortunate. it's lamentable that CCSS can't find a home. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
Well, to emphasize the advice given previously on the thread: after much work the project is now set up such that we literally cannot make a change in our rendering engine without it being added to WebKit -- we don't even have our own copy of the WebKit code, but instead check it out directly from the upstream repository. On Mon, Jul 20, 2009 at 3:21 PM, darrel karischdkari...@gmail.com wrote: that's unfortunate. it's lamentable that CCSS can't find a home. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Purify help office hours
To echo Dan's valgrind office hours, I'll be available to help with Purify issues for this week's fixit as well. See http://code.google.com/p/chromium/wiki/StabilityFixitWeek for more details (thanks to dank for setting up this page). I'll be on IRC from 9-3:30PST, and should respond to email questions as well. You may still be able to help review bugs even if you don't have Purify installed (Purify isn't a free tool). It's likely that a number of the bugs will be findable simply by inspection. thanks, Erik --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Reusing chromium code
Chromium has lots of interesting base APIs such as the ones found under base/ and testing/. Is there any chance these two could be available as a separate library? It would be great if I could use such library in my own projects. Thanks, -Gatis --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Unable to download Chrome Source Code
Hi All, From past several days I am trying to download the source code, but for some reason the download quits after completion of 17 - 18 MB. I need assistance in this matter. Thanks Regards Pradeep Chandra --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Access to window handles from plugins?
This is something along the lines of calling IWebBrowser2.get_HWND or (more similarly) using XPCOM's nsIAccessibleDocument-GetWindowHandle () calls: http://msdn.microsoft.com/en-us/library/aa454384.aspx https://developer.mozilla.org/En/NsIAccessibleDocument/windowHandle Both of these provide a mechanism to get a native window handle. The reason for needing this is that webdriver pumps native events to the given HWND, allowing it to closely emulate user behaviour (certainly more closely than doing the same thing by synthesizing events on the DOM) By sending the events to the HWND, it avoids requiring the browser window to have focus. Since webdriver tests tend to run for a long time, it's useful to allow users to do something else with their computer as they run. Regards, Simon On Jul 17, 7:55 pm, John Abd-El-Malek j...@chromium.org wrote: On Fri, Jul 17, 2009 at 10:45 AM, Daniel Wagner-Hall dawag...@gmail.comwrote: Hi, Can anyone help me with this? How can I get the window handle of an element from its JS DOM node? DOM elements, with the exception of plugins and select controls, don't have window handles because they're not implemented as native controls (otherwise we'd run out of OS handles on some pages). Are you asking specifically about a plugin node? Perhaps a little background might help! I'm currently working on WebDriver, a browser testing automation tool[1], to add Chrome support. As suggested by the chrome team, this is being written as an extension with an embedded NPAPI plugin. The original driver worked with the AutomationProxy, but this is not available in release binaries, which means that a user would need to compile a custom version of Chrome; obviously a less than ideal user experience :) We use a native interactions library for sending keys/clicks/etc at the OS level, which requires a window handle to the window containing the element to do its thing. This library is shared between all the drivers for a particular platform (at the moment, only Windows, but X support is coming soon). Thanks, Daniel Wagner-Hall 1:http://code.google.com/p/webdriver/ --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Google Chrome - COM objects methods
Hi, I am new to Google chrome. I wanted to know if chrome supports Component Object Model. If yes, how can I get its object/method list? Thanks, Saurabh --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Reusing chromium code
http://code.google.com/p/googletest/ On Sun, Jul 19, 2009 at 1:46 PM, Igor Gatisigorga...@gmail.com wrote: Chromium has lots of interesting base APIs such as the ones found under base/ and testing/. Is there any chance these two could be available as a separate library? It would be great if I could use such library in my own projects. Thanks, -Gatis --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Google Chrome - COM objects methods
On Fri, Jul 17, 2009 at 6:59 PM, saurabhbuksh.saur...@gmail.com wrote: I wanted to know if chrome supports Component Object Model. It doesn't. Maybe take a look at http://code.google.com/p/chromiumembedded/ if you want to embed Chrome. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
The next step for your specification is to go to the W3C. yes, I've submitted a request to webkit.org a few days ago. I'm not advocating that anybody adopt the code. I merely wanted a POC for my own benefit and analysis before publicizing the proposal. I'd rather prefer to see some form of CCSS adopted by W3C, but after ten years it does not seem realistic. currently, it is difficult to manipulate absolutely positioned elements in CSS. they are virtual pariahs exiled to client-side JS. I think something like what I propose here is a start to assimilate what is currently done in CS JS into CSS with the added benefit of support for more powerful layout specific objects. Finally, features at this layer should go into WebKit directly, not into Chromium. Once your spec has been approved by W3C, you should take your feature request to webkit.org. I did make all mods in WebKit directly, the goal being to be as minimally invasive as possible. code extensions/modifications are enclosed in and isolated by appropriate preprocessor statements. CSS expressions have be a huge pain point for Internet Explorer, both in terms of security and in terms of performance. We'll want to be extremely careful before implementing a similar feature. using the parallel universe V8IsolatedWorld addresses the security concerns for the most part. performance is always an issue with javascript. that's why I chose v8. whether JS is executed in CSS or in js tags or includes, the performance issue remains. with absolutely positioned elements there is not much choice in our current state. having said that, the POC does push v8 to the limit as far as reentrancy is concerned. some analysis may reveal room for v8 improvements. perhaps reusable Scripts across contexts, although perhaps not simultaneously. thanks for your thoughtful replies. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: novel use of v8 - CSS Scripting Layout
On Mon, Jul 20, 2009 at 11:04 AM, darrel karischdkari...@gmail.com wrote: using the parallel universe V8IsolatedWorld addresses the security concerns for the most part. I'm not sure this is the case. That feature was design explicitly for the extension use case. We'd have to think carefully about whether it matches the security requirements of your use case. Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Design Doc: Adaptive spell checking for multilingual users
A new feature to add to the SpellChecker would be its ability to adapt to the user's language of choice when typing in a text box. A design doc can be found at: http://sites.google.com/a/chromium.org/dev/developers/design-documents/advancedspellchecker It will be great if you could go over it and provide suggestions/ improvements, before I move ahead and start implementing this feature as an experiment. -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium crash
Looks to me like the code in question wouldn't be compiled into release builds in the first place (it's under NDEBUG). So it might be problematic to match it to a known bug, since the known bugs would mostly look different. The general case of Started typing in omnibox and crashed is obviously not something which happens every time. That would certainly be noticed! -scott On Sun, Jul 19, 2009 at 2:48 PM, Thiago Farinathiago.far...@gmail.com wrote: I thought this problem was known. Thanks! On Jul 19, 6:33 pm, Peter Kasting pkast...@google.com wrote: On Sun, Jul 19, 2009 at 12:52 PM, Thiago Farina thiago.far...@gmail.comwrote: When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... Since yo're debugging, you can track down what's going on. Then you can look it up in the bug database. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Please look at your Mstone:3 bugs!
As we begin to tighten the screws on Mstone:3, please review your Mstone:3 bugs: http://code.google.com/p/chromium/issues/list?can=2q=Mstone%3A3+owner%3Ame If you need help with or have concerns about anything on your list, let your neighborhood triage team know and they'll find help. -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Unable to download Chrome Source Code
Pradeep, i was also never able to download the source via the tarball what i did in the end was use gclient sync as it continues from where it left off, if the download is interrupted also a friend of mine could only get the source code like this --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium crash
Yes, I'm compiling the code under debug build option. Everytime I try to type in omnibox this happens. On Jul 20, 4:02 pm, Scott Hess sh...@chromium.org wrote: Looks to me like the code in question wouldn't be compiled into release builds in the first place (it's under NDEBUG). So it might be problematic to match it to a known bug, since the known bugs would mostly look different. The general case of Started typing in omnibox and crashed is obviously not something which happens every time. That would certainly be noticed! -scott On Sun, Jul 19, 2009 at 2:48 PM, Thiago Farinathiago.far...@gmail.com wrote: I thought this problem was known. Thanks! On Jul 19, 6:33 pm, Peter Kasting pkast...@google.com wrote: On Sun, Jul 19, 2009 at 12:52 PM, Thiago Farina thiago.far...@gmail.comwrote: When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... Since yo're debugging, you can track down what's going on. Then you can look it up in the bug database. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Chromium crash
OK, how about a backtrace? On Mon, Jul 20, 2009 at 8:24 PM, Thiago Farinathiago.far...@gmail.com wrote: Yes, I'm compiling the code under debug build option. Everytime I try to type in omnibox this happens. On Jul 20, 4:02 pm, Scott Hess sh...@chromium.org wrote: Looks to me like the code in question wouldn't be compiled into release builds in the first place (it's under NDEBUG). So it might be problematic to match it to a known bug, since the known bugs would mostly look different. The general case of Started typing in omnibox and crashed is obviously not something which happens every time. That would certainly be noticed! -scott On Sun, Jul 19, 2009 at 2:48 PM, Thiago Farinathiago.far...@gmail.com wrote: I thought this problem was known. Thanks! On Jul 19, 6:33 pm, Peter Kasting pkast...@google.com wrote: On Sun, Jul 19, 2009 at 12:52 PM, Thiago Farina thiago.far...@gmail.comwrote: When I start typing in omnibox from Chromium (I'm debugging) the browser crashes... Since yo're debugging, you can track down what's going on. Then you can look it up in the bug database. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Design Doc: Adaptive spell checking for multilingual users
Another thing to consider is that something sort of like this is already supported by the OS X spellchecker through the Multilingual language setting. There is currently no way to switch to Multilingual in Chromium on OS X, but it wouldn't be that hard to enable that and it really is something that should be enabled if we want to support the native spelling correction panel on OS X (something which I have about 2/3's done), since the spelling panel shows Multilingual as a language option even if the context menu doesn't. I've done a little bit of experimenting and Multilingual seems to work pretty well in Chromium if you can enable it. One thing that might be a problem is that as far as I can tell, the Multilingual setting just checks all dictionaries for a word, so there could be problems there since a misspelling in the language being used might not be marked if it is a word in another language. I don't think I can say whether chromium is willing to accept Multilingual as the solution for this on OS X. If it is, then what you propose needs to be done in such a way that it doesn't touch the way OS X does this. If this is the solution for all platforms, OS X included, then we need to figure out a way around the spelling panel problem (no matter what, the spelling panel provided by NSSpellChecker will show Multilingual as an option). Whatever is decided, this definitely looks good for the other platforms. If this does go forward, I could probably help out, if you need a hand. -Paul Wicks On Mon, Jul 20, 2009 at 1:00 PM, sidchat sidc...@chromium.org wrote: A new feature to add to the SpellChecker would be its ability to adapt to the user's language of choice when typing in a text box. A design doc can be found at: http://sites.google.com/a/chromium.org/dev/developers/design-documents/advancedspellchecker It will be great if you could go over it and provide suggestions/ improvements, before I move ahead and start implementing this feature as an experiment. -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Please keep TOOLKIT_VIEWS green!
This mostly applies to people working on UI. Sometime tonight or tomorrow we'll be moving the TOOLKIT_VIEWS builder to the front page of the waterfall. Right now it's building just the chrome target, and running no tests, but in time we'll build this out. This is an experimental build distinct from the standard Chromium linux which we will ship but a codepath which we will support as first class for other purposes. So please keep it green! If it goes red, the same rules that apply to any other builder on the front page will apply. To build, export GYP_DEFINES=toolkit_views=1 gclient runhooks --force hammer chrome Thanks, -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind help office hours
I have a leak after a check-in. I tried following the instructions on my Linux box, but couldn't (I hardly develop on Linux). jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui Usage: chrome_tests.py -b dir -t test [-t test ...] chrome_tests.py: error: no such option: --generate_suppressions I had tried to follow the getting started instructions in installing and building valgrind from source so that it works in ui_tests, but the first line fails for me: jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh autogen.sh sh: autogen.sh: No such file or directory So I'm unable to fix the regressions from my checkin. I think it's difficult to require people to keep the tree green on all these builders, if it's this hard for developers on other platforms to reproduce the problems. On Mon, Jul 20, 2009 at 10:40 AM, Dan Kegel d...@kegel.com wrote: On Mon, Jul 20, 2009 at 3:48 PM, Dan Kegeld...@kegel.com wrote: If you'd like to help with the stability fixit week ( http://code.google.com/p/chromium/wiki/StabilityFixitWeek ) but valgrind is giving you trouble, I'll be available from 10am to 4pm PST today to help; contact me via email, chat, or IRC with your chromium valgrind questions and I'll try to answer them. forgot to mention: my preferred chromium chat is daniel.r.ke...@gmail.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind help office hours
On Mon, Jul 20, 2009 at 10:04 PM, John Abd-El-Malek j...@chromium.orgwrote: I have a leak after a check-in. I tried following the instructions on my Linux box, but couldn't (I hardly develop on Linux). jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui Usage: chrome_tests.py -b dir -t test [-t test ...] chrome_tests.py: error: no such option: --generate_suppressions I had tried to follow the getting started instructions in installing and building valgrind from source so that it works in ui_tests, but the first line fails for me: jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh autogen.sh sh: autogen.sh: No such file or directory Did you checkout the valgrind source into this dir? The directions you're starting with are talking about building it in the directory you downloaded the source too. In a lot of cases, simply by looking at the data from the bots you can see what the leak is likely to be to fix it without having to run locally. When you do need to run it under valgrind, the stdio log from the bot can help give you the command line the bot is using which you can then start with locally. TVL So I'm unable to fix the regressions from my checkin. I think it's difficult to require people to keep the tree green on all these builders, if it's this hard for developers on other platforms to reproduce the problems. On Mon, Jul 20, 2009 at 10:40 AM, Dan Kegel d...@kegel.com wrote: On Mon, Jul 20, 2009 at 3:48 PM, Dan Kegeld...@kegel.com wrote: If you'd like to help with the stability fixit week ( http://code.google.com/p/chromium/wiki/StabilityFixitWeek ) but valgrind is giving you trouble, I'll be available from 10am to 4pm PST today to help; contact me via email, chat, or IRC with your chromium valgrind questions and I'll try to answer them. forgot to mention: my preferred chromium chat is daniel.r.ke...@gmail.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind help office hours
On Mon, Jul 20, 2009 at 7:31 PM, Thomas Van Lenten thoma...@chromium.orgwrote: On Mon, Jul 20, 2009 at 10:04 PM, John Abd-El-Malek j...@chromium.orgwrote: I have a leak after a check-in. I tried following the instructions on my Linux box, but couldn't (I hardly develop on Linux). jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui Usage: chrome_tests.py -b dir -t test [-t test ...] chrome_tests.py: error: no such option: --generate_suppressions I had tried to follow the getting started instructions in installing and building valgrind from source so that it works in ui_tests, but the first line fails for me: jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh autogen.sh sh: autogen.sh: No such file or directory Did you checkout the valgrind source into this dir? The directions you're starting with are talking about building it in the directory you downloaded the source too. I just followed the Getting Started instructions under Linux. Perhaps the instructions need to call out where to get the source from (i.e. the ones there are incomplete). In a lot of cases, simply by looking at the data from the bots you can see what the leak is likely to be to fix it without having to run locally. When you do need to run it under valgrind, the stdio log from the bot can help give you the command line the bot is using which you can then start with locally. But as per my first problem, I couldn't even do that. TVL So I'm unable to fix the regressions from my checkin. I think it's difficult to require people to keep the tree green on all these builders, if it's this hard for developers on other platforms to reproduce the problems. On Mon, Jul 20, 2009 at 10:40 AM, Dan Kegel d...@kegel.com wrote: On Mon, Jul 20, 2009 at 3:48 PM, Dan Kegeld...@kegel.com wrote: If you'd like to help with the stability fixit week ( http://code.google.com/p/chromium/wiki/StabilityFixitWeek ) but valgrind is giving you trouble, I'll be available from 10am to 4pm PST today to help; contact me via email, chat, or IRC with your chromium valgrind questions and I'll try to answer them. forgot to mention: my preferred chromium chat is daniel.r.ke...@gmail.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Question about V8 bindings
Sorry if this is a dumb question, but why woudn't you simply have a WORKERCONTEXT and let virtual dispatch do its job for the rest? Shared methods can be implemented on the base class and the rest can be purely virtual with implementations in the sub classes. J On Mon, Jul 20, 2009 at 3:21 PM, Drew Wilson atwil...@chromium.org wrote: Following up on this. Let's imagine that I don't define a V8ClassIndex enum for the common base class (so, in my case, I get rid of WORKERCONTEXT, and have only DEDICATEDWORKERCONTEXT and SHAREDWORKERCONTEXT (the derived classes). Now, let's say I'm defining an ACCESSOR_GETTER on the base class - the first thing I want to do is get a pointer to the native object. I don't know which concrete class the native object is (DedicatedWorkerContext or SharedWorkerContext), but I do know that it's guaranteed to be an instance of the base native class (WorkerContext). Currently I'm doing this: WorkerContext* workerContext = V8DOMWrapper::convertToNativeObjectWorkerContext(V8ClassIndex::WORKERCONTEXT, info.Holder()); If I remove V8ClassIndex::WORKERCONTEXT, then I can't pass that in to convertToNativeObject. It looks like the passed-in enum is only used for error checking currently, so I guess what I should use instead is convertDOMWrapperToNative()?: WorkerContext* workerContext = V8DOMWrapper::convertDOMWrapperToNativeWorkerContext(info.Holder()); Is that the general pattern people use for cases like this? -atw On Mon, Jul 20, 2009 at 3:21 PM, Drew Wilson atwil...@chromium.orgwrote: resending from correct acct: Currently, Web Workers have a class (WorkerContext) which represents the global scope for a worker. The custom V8 bindings for this class are defined in V8WorkerContextCustom, and we also define V8ClassIndex::WORKERCONTEXT for the wrapper object. I'm refactoring the WebCore impl class, so WorkerContext becomes (essentially) an abstract base class, and the actual worker context will be one of two derived classes: DedicatedWorkerContext or SharedWorkerContext. In my refactoring, I've only implemented a single derived class (DedicatedWorkerContext) for now. I'm trying to figure out the correct way to structure the V8 bindings - I've already made a pass at it that passes all of the unit tests: https://bugs.webkit.org/show_bug.cgi?id=27420 I've defined V8ClassIndex::DEDICATEDWORKERCONTEXT, but I'm not certain if I need to remove V8ClassIndex::WORKERCONTEXT or not, since there shouldn't ever be a wrapper object created for that base class. Are the wrapper types defined in V8Index.h only for actually instantiable wrapper objects (in which case I should only define them for the leaves of the tree), or is it used for other things like instanceof? -atw --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Question about V8 bindings
In other words, make all workers appear the same to V8 (i.e. as a WORKERCONTEXT) and then implement polymorphism in the implementations being wrapped by V8. On Mon, Jul 20, 2009 at 8:19 PM, Jeremy Orlow jor...@chromium.org wrote: Sorry if this is a dumb question, but why woudn't you simply have a WORKERCONTEXT and let virtual dispatch do its job for the rest? Shared methods can be implemented on the base class and the rest can be purely virtual with implementations in the sub classes. J On Mon, Jul 20, 2009 at 3:21 PM, Drew Wilson atwil...@chromium.orgwrote: Following up on this. Let's imagine that I don't define a V8ClassIndex enum for the common base class (so, in my case, I get rid of WORKERCONTEXT, and have only DEDICATEDWORKERCONTEXT and SHAREDWORKERCONTEXT (the derived classes). Now, let's say I'm defining an ACCESSOR_GETTER on the base class - the first thing I want to do is get a pointer to the native object. I don't know which concrete class the native object is (DedicatedWorkerContext or SharedWorkerContext), but I do know that it's guaranteed to be an instance of the base native class (WorkerContext). Currently I'm doing this: WorkerContext* workerContext = V8DOMWrapper::convertToNativeObjectWorkerContext(V8ClassIndex::WORKERCONTEXT, info.Holder()); If I remove V8ClassIndex::WORKERCONTEXT, then I can't pass that in to convertToNativeObject. It looks like the passed-in enum is only used for error checking currently, so I guess what I should use instead is convertDOMWrapperToNative()?: WorkerContext* workerContext = V8DOMWrapper::convertDOMWrapperToNativeWorkerContext(info.Holder()); Is that the general pattern people use for cases like this? -atw On Mon, Jul 20, 2009 at 3:21 PM, Drew Wilson atwil...@chromium.orgwrote: resending from correct acct: Currently, Web Workers have a class (WorkerContext) which represents the global scope for a worker. The custom V8 bindings for this class are defined in V8WorkerContextCustom, and we also define V8ClassIndex::WORKERCONTEXT for the wrapper object. I'm refactoring the WebCore impl class, so WorkerContext becomes (essentially) an abstract base class, and the actual worker context will be one of two derived classes: DedicatedWorkerContext or SharedWorkerContext. In my refactoring, I've only implemented a single derived class (DedicatedWorkerContext) for now. I'm trying to figure out the correct way to structure the V8 bindings - I've already made a pass at it that passes all of the unit tests: https://bugs.webkit.org/show_bug.cgi?id=27420 I've defined V8ClassIndex::DEDICATEDWORKERCONTEXT, but I'm not certain if I need to remove V8ClassIndex::WORKERCONTEXT or not, since there shouldn't ever be a wrapper object created for that base class. Are the wrapper types defined in V8Index.h only for actually instantiable wrapper objects (in which case I should only define them for the leaves of the tree), or is it used for other things like instanceof? -atw --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] linux: debugging sandboxed renderers ?
So, sandboxing is in on linux, which is awesome. But how do I debug sandbox-related issues (in my case, why I can't create a shared memory buffer from the renderer when sandboxing is on). If I specify a --renderer-cmd-prefix, it doesn't use the zygote process, and I don't get sandboxed. If I let chrome do it's regular job, I can't attach gdb to a running renderer, I get a ptrace: Operation not permitted, which I assume from http://code.google.com/p/chromium/wiki/LinuxSUIDSandbox is expected. What's the best practice for debugging sanbox-related issues ? Antoine --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: linux: debugging sandboxed renderers ?
On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the best practice for debugging sanbox-related issues ? Usually you can just ask me: the reason you can't create shared memory is because you're trying to use POSIX shared memory, which requires filesystem access. You can use SysV shared memory without issues, but be careful to get the reference counting correct. (See render_process.cc for an example of doing it.) The other way is to comment out the setting of the DUMPABLE flag in zygote_main_linux.cc and then you'll be able to attach with GDB. Cheers AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: linux: debugging sandboxed renderers ?
On Tue, Jul 21, 2009 at 3:32 AM, Adam Langleya...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the best practice for debugging sanbox-related issues ? Usually you can just ask me: the reason you can't create shared memory is because you're trying to use POSIX shared memory, which requires filesystem access. You can use SysV shared memory without issues, but be careful to get the reference counting correct. (See render_process.cc for an example of doing it.) Those are SysV shared memory - for TransportDIB. Apparently it's not the creation that fails (I don't get the DLOG), but some issue further, hence why I wanted to debug. The other way is to comment out the setting of the DUMPABLE flag in zygote_main_linux.cc and then you'll be able to attach with GDB. Ah, ok, thanks ! I'll try that. Antoine --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind help office hours
On Tue, Jul 21, 2009 at 2:04 AM, John Abd-El-Malekj...@chromium.org wrote: I have a leak after a check-in. I tried following the instructions on my Linux box, but couldn't (I hardly develop on Linux). jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui Usage: chrome_tests.py -b dir -t test [-t test ...] chrome_tests.py: error: no such option: --generate_suppressions Sorry 'bout that. timu and I neglected to update the doc after a recent checkin. I've updated the doc and will check in code to support the missing option in case it's mentioned anywhere else we've missed. I had tried to follow the getting started instructions in installing and building valgrind from source so that it works in ui_tests, but the first line fails for me: jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh autogen.sh sh: autogen.sh: No such file or directory Ah, you forgot to cd to the valgrind source directory. I've updated that doc. We should probably have a canned script to run. Sorry this is hard. We'll keep trying until it's easy. - Dan --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: linux: debugging sandboxed renderers ?
On Tue, Jul 21, 2009 at 3:39 AM, Antoine Labourpi...@google.com wrote: On Tue, Jul 21, 2009 at 3:32 AM, Adam Langleya...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the best practice for debugging sanbox-related issues ? Usually you can just ask me: the reason you can't create shared memory is because you're trying to use POSIX shared memory, which requires filesystem access. You can use SysV shared memory without issues, but be careful to get the reference counting correct. (See render_process.cc for an example of doing it.) Those are SysV shared memory - for TransportDIB. Apparently it's not the creation that fails (I don't get the DLOG), but some issue further, hence why I wanted to debug. The other way is to comment out the setting of the DUMPABLE flag in zygote_main_linux.cc and then you'll be able to attach with GDB. Ah, ok, thanks ! I'll try that. Please add notes to http://code.google.com/p/chromium/wiki/LinuxDebugging once you've reached a conclusion! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: linux: debugging sandboxed renderers ?
On Tue, Jul 21, 2009 at 4:49 AM, Evan Martine...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:39 AM, Antoine Labourpi...@google.com wrote: On Tue, Jul 21, 2009 at 3:32 AM, Adam Langleya...@chromium.org wrote: On Tue, Jul 21, 2009 at 3:27 AM, Antoine Labourpi...@google.com wrote: What's the best practice for debugging sanbox-related issues ? Usually you can just ask me: the reason you can't create shared memory is because you're trying to use POSIX shared memory, which requires filesystem access. You can use SysV shared memory without issues, but be careful to get the reference counting correct. (See render_process.cc for an example of doing it.) Those are SysV shared memory - for TransportDIB. Apparently it's not the creation that fails (I don't get the DLOG), but some issue further, hence why I wanted to debug. The other way is to comment out the setting of the DUMPABLE flag in zygote_main_linux.cc and then you'll be able to attach with GDB. Ah, ok, thanks ! I'll try that. Please add notes to http://code.google.com/p/chromium/wiki/LinuxDebugging once you've reached a conclusion! Done. I added instructions that aren't yet valid (until http://codereview.chromium.org/159124 is in). Antoine --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
