[chromium-dev] Mac UI Types

2009-10-30 Thread Thomas Van Lenten
Gentle reminder: NSRect, NSPoint, NSSize are all defined based on CGFloat. In 64bit, this is a double, not a float. So please make sure all code dealing with these is using CGFloat so we don't have issues in the future. TVL --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-30 Thread Linus Upson
scrolling jank in gmail http://crbug.com/25741 Linus On Wed, Oct 28, 2009 at 12:05 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 28, 2009 at 8:05 AM, Evan Martin e...@chromium.org wrote: General comments: Linux tends to be lighter which means it does better on older hardware, so

[chromium-dev] browser/sync test fixit next week [Nov 2 - 6]

2009-10-30 Thread Tim Steele
Hello! A heads-up that folks working on sync will be holding a test fixit next week, Nov 2 - 6. The motivation is to improve test coverage of our code, as there are many more chunks without any unit-test coverage whatsoever than there should be. The sync integration tests do tickle *most *of

[chromium-dev] PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Jeremy Orlow
I've spent a good deal of this week trying to track down what turned out to be a simple but fairly common problem: I forgot virtual dispatch only partially works in destructors. There have been several email threads about this, but it still bites us form time to time, so I thought it was worth

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Adam Barth
I'm sorry for introducing this pattern in base::Thread. It's bitten use several times over the course of the project. If you see a better design, please don't hesitate to fix it. Adam On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow jor...@chromium.org wrote: I've spent a good deal of this

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Antoine Labour
On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow jor...@chromium.org wrote: I've spent a good deal of this week trying to track down what turned out to be a simple but fairly common problem: I forgot virtual dispatch only partially works in destructors. There have been several email threads

[chromium-dev] [Linux] 'make' build maintenance

2009-10-30 Thread Michael Moss
If you don't build with 'make', you can ignore this message. Recent gyp changes have rearranged the 'obj' output directory for make builds. This shouldn't affect how you build, but it will result in a bunch of orphaned object files from previous builds, which might be confusing, and will

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Antoine Labour
On Fri, Oct 30, 2009 at 3:26 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:17 PM, Antoine Labour pi...@google.com wrote: On Fri, Oct 30, 2009 at 3:12 PM, Jeremy Orlow jor...@chromium.orgwrote: I've spent a good deal of this week trying to track down what turned out

[chromium-dev] New ffmpeg sumo lib requires libbz2-dev, and possibly a clobber build

2009-10-30 Thread 王重傑
As of r30640, on Linux and FreeBSD, we are now building the FFmpeg binaries as part of the normal Chromium build process. This means we now have a dependency on libbz2. :) Make sure to install the libbz2-dev package. I've updated the src/build/install-build-deps.sh script to reflect the new

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Scott Hess
Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question, NOT of the class it will finally be, because in the constructor the subclass has not been constructed, yet, and in the destructor the subclass was

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Jeremy Orlow
On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question, NOT of the class it will finally be, because in the constructor the

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Michael Nordman
On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question, NOT of the class it will finally be, because in the constructor the

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Scott Hess
On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question,

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Antoine Labour
On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in

[chromium-dev] Re: Inheritance in gyp configurations

2009-10-30 Thread 王重傑
Sounds really powerful...but this scares methough that could just be my generalized fear of inheritance. However, if we start putting inheritance into the system, I worry about the level of complexity the gyp specification language will pick up and the possible breakages of information hiding

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread David Levin
On Fri, Oct 30, 2009 at 3:59 PM, Antoine Labour pi...@google.com wrote: On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because

[chromium-dev] Re: How can we kill scons?

2009-10-30 Thread Michael Moss
To follow up on this thread, for people who didn't see the related gyp-developer discussion, I submitted the last make fix for the gyp tests today. This was my minimum sanity check before switching any buildbots over to make. I might start with some FYI bots this weekend, then do the main bots