Re: [chromium-dev] How can I tell if a Renderer process finishes loading a page

2010-01-11 Thread hap 497
Thank you.

But when I load www.cnn.com, I see something strange:
First the throbber is spinning, and then the cnn fave icon is shown
and then the throbber is spinning again, and then fave icon is shown.
And then the fave icon stays.

Can you please help me understand under what situation will cause this
to happen? I don't think it is caused by frame set. This is because I
tried http://java.sun.com/j2se/1.5.0/docs/api/index.html, the throbber
stops after each frame in frame set is loaded.


On Sat, Jan 9, 2010 at 10:11 AM, Peter Kasting pkast...@google.com wrote:
 On Sat, Jan 9, 2010 at 12:15 AM, hap 497 hap...@gmail.com wrote:

 So how does renderer process knows the whole page is loaded completely
 and tell the browser process to stop the spinning icons and shows the
 favicon of the page?

 Sounds like you should start by looking in the browser for what controls the
 throbber and backtrack from there.  You want the NavigationController class.
 PK
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Question about GraphicsContext clipOut() function

2010-01-11 Thread Pierre-Antoine LaFayette
The clipOut function works like a normal clip() except, instead of clipping
against the rect/path parameter, it removes the rect/path from the current
drawing, i.e. clips it out.

2010/1/11 hap 497 hap...@gmail.com

 Hi,

 Can you please help me understand clipOut() function supposed to do?
 My understanding is GraphicsContext::clip() function is setting the
 clipping rectangle of the graphics context, only operations within the
 clipping rectangle will be shown.  But what is the purpose of
 clipOut() function?

 Thanks in advance for any help.

 Regards,

 --
 Chromium Developers mailing list: chromium-dev@googlegroups.com
 View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev




-- 
Pierre.
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] How can I tell if a Renderer process finishes loading a page

2010-01-11 Thread Brett Wilson
On Mon, Jan 11, 2010 at 12:59 AM, hap 497 hap...@gmail.com wrote:
 Thank you.

 But when I load www.cnn.com, I see something strange:
 First the throbber is spinning, and then the cnn fave icon is shown
 and then the throbber is spinning again, and then fave icon is shown.
 And then the fave icon stays.

 Can you please help me understand under what situation will cause this
 to happen? I don't think it is caused by frame set. This is because I
 tried http://java.sun.com/j2se/1.5.0/docs/api/index.html, the throbber
 stops after each frame in frame set is loaded.

I don't think anybody is able to answer this type of question off the
top of their head.

RenderView::didStartLoading / didStopLoading correspond to the
throbber starting and stopping in the renderer, I'd trace back form
there.

Brett
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] WebKit Gardeners 3 rebaseline.py -w

2010-01-11 Thread Victor Wang
I started working on upstreaming the rebaseline tool, which is part of the
plan for upstreaming layout tests in Q1.

On Sat, Jan 9, 2010 at 2:53 PM, Eric Seidel esei...@chromium.org wrote:

 Once we have this sort of tool for webkit.org then those of us who
 work on webkit.org could just add the new baselines when we commit the
 patches in the first place. :)

 On Fri, Jan 8, 2010 at 5:38 PM, Julie Parent jpar...@chromium.org wrote:
  Yeah, me too.
  This is what tends to lead to me spending the day after my gardening
  rotation doing clean up.  Maybe if we had 2 people gardening at the same
  time they could do this real time, but on a normal day, I think it is too
  much for one person.
  This tool is awesome though!
  Julie
  On Fri, Jan 8, 2010 at 4:54 PM, Jeremy Orlow jor...@chromium.org
 wrote:
 
  Same here.
  On Fri, Jan 8, 2010 at 4:51 PM, Drew Wilson atwil...@chromium.org
 wrote:
 
  Do you find that you have time to figure out if rebaselining a test is
  the right thing to do while you're actively gardening? Maybe I just
 work too
  slowly, but I often find that if I'm trying to rebaseline on the fly,
 it
  requires that I do at least *some* investigation of the test failure to
 make
  sure I'm not rebaselining in an error (or rebaselining a test that is
 merely
  flaky) which slows me down enough that I fall behind and inevitably am
  crushed by the WebKit juggernaut.
  -atw
  On Fri, Jan 8, 2010 at 4:33 PM, Dimitri Glazkov dglaz...@chromium.org
 
  wrote:
 
  Before heading out for the weekend, I just want to mention this:
  rebaseline tool really, really rocks. And yesterday I discovered an
  option that I, to my shame, hadn't seen before: -w. This option pulls
  baselines from the canary. It's like getting test expectations from
  the future!
 
  In other words, there are no more excuses for you, dear WebKit
  gardeners, to commit those ghastly BUG_SOMENAME entries in
  test_expectations.
 
  The workflow is mind-numbingly simple:
 
  1) Identify tests that need rebaselining prior to rolling
  2) Add these tests to test_expectations.txt as if you were to commit
  them -- except add a REBASELINE flag next to BUG_SOMENAME
  3) Run rebaseline -w
  4) Make sure that the tool ran and removed these entries from
  test_expectations.txt
  5) Create CL -- you will notice how new expected result files are
  conveniently added for you.
  6) Enjoy regression-free WebKit roll.
 
  Big thanks to Victor Wang for this amazing instrument of everlasting
  harmony. Send him your accolades. Or cash. If you find bugs/quirks,
  fix them.
 
  :DG
 
  P.S. As part of gardener/sheriff process overhaul, I will be adding
  these and other helpful tips/hints to our gardening doc.
 
  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
 http://groups.google.com/group/chromium-dev
 
 
  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
 http://groups.google.com/group/chromium-dev
 
 
  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
 http://groups.google.com/group/chromium-dev
 
 
  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
 http://groups.google.com/group/chromium-dev
 

 --
 Chromium Developers mailing list: chromium-dev@googlegroups.com
 View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-11 Thread Scott Hess
On Sat, Jan 9, 2010 at 3:06 PM, Victor Khimenko k...@google.com wrote:
 P.S. There are interesting fact related to specifically colon and MacOS.
 Classic MacOS uses colon as delimeter and you can use slash in filename.
 when they used POSIX-compliat kernel they needed some way to resolve thus
 collision. The solution was simple and elegant: they swapped colon and slash
 - so if you'll create http: directory old MacOS 9 program will see http/
 directory. Thus you can create file which looks as http://google.com; for
 unix-programs and for MacOS programs (even if it'll be two different files).

Long long ago, we spent an evening trying to delete a file on an SGI
machine which had been created with an embedded '/' character from an
early Mac NFS client.  The client could _create_ such files, but it
couldn't delete them... eventually we found a command or system call
or something to do a remove by inode and were golden.

-scott
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Linux sandbox configuration

2010-01-11 Thread Lei Zhang
Can you elaborate on what you mean by configure the sandbox?

On Fri, Jan 8, 2010 at 11:36 PM, n179911 n179...@gmail.com wrote:
 Hi,

 Can you please tell me if/where is the file to configure chromium's
 renderer sandbox?

 Thank you.

 --
 Chromium Developers mailing list: chromium-dev@googlegroups.com
 View archives, change email options, or unsubscribe:
    http://groups.google.com/group/chromium-dev

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] no more chromium-os dependency in linux_view build

2010-01-11 Thread oshima
Hello All,

On last Friday, I committed r35858, which (finally) removes chromium-os
dependency from linux_view build.
You no loner need git and the following line in your .gclient to build
linux_view (toolkit_view=1 on linux).

  { name: cros deps,
url : http://src.chromium.org/svn/trunk/cros_deps;,
  },

Please let me know if you have any question or problem with the build.

Thanks,
- oshima
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Re: [Mac] Something is eating the right mouse button events in the Toolbar. Help!

2010-01-11 Thread Andrew Bonventre
Wrong list. Oops.

On Mon, Jan 11, 2010 at 2:50 PM, Andrew Bonventre (Bons)
andyb...@google.com wrote:
 I'm attempting to add context menus to Browser Action buttons within
 the toolbar, but I've hit a snag and cannot for the life of me figure
 out what is happening with my events...

 - (void)onRightMouseDown:(NSEvent*)theEvent; is never being called
 within my NSButton subclass, and in fact, any other portion of the
 Toolbar controller except for the Omnibar. I've tried overloading the
 function within BrowserActionButton, ToolbarController and
 ToolbarView, only to never have it called. In order to track down the
 codepath for a right mouse down event that _does_ work in the toolbar,
 I got a stacktrace of the context menu code within the Omnibar:

 #0      0x001c7454 in -[AutocompleteTextFieldEditor menuForEvent:] at
 autocomplete_text_field_editor.mm:89
 #1      0x92ecf0ae in -[NSView rightMouseDown:]
 #2      0x92e3e1ef in -[NSTextView rightMouseDown:]
 #3      0x929adfe0 in -[NSWindow sendEvent:]
 #4      0x001f6c58 in -[ChromeEventProcessingWindow sendEvent:] at
 chrome_event_processing_window.mm:101
 #5      0x001f58a7 in -[ChromeBrowserWindow sendEvent:] at
 chrome_browser_window.mm:300
 #6      0x928c6b2f in -[NSApplication sendEvent:]
 #7      0x0078b18a in -[CrApplication sendEvent:] at 
 chrome_application_mac.mm:33
 #8      0x9285a4ff in -[NSApplication run]
 ...

 I have confirmed that -[ChromeEventProcessingWindow sendEvent:] IS
 being called on right mouse clicks and therefore NSWindow's sendEvent
 is being called.

 Any ideas would be greatly appreciated. Something is eating them up
 and I don't know what's going on.

 A

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Re: Linux: gold linker users should upgrade to 2.20 soon.

2010-01-11 Thread Brian Lum
Hi,

I am having problems with this issue when I try do a release build.
When I try to build, I get an error which suggests that I need to
upgrade:
$ make BUILDTYPE=Release
  LINK(target) out/Release/xdisplaycheck
/usr/bin/ld: --gc-sections: unknown option
/usr/bin/ld: use the --help option for usage information
collect2: ld returned 1 exit status
make: *** [out/Release/xdisplaycheck] Error 1

However, I already ran install-build-deps.sh and my copy of gold is
new enough:
$ /path/to/gold --gc-sections
bash: /path/to/gold: No such file or directory

I am getting both error messages.  Does anyone have any suggestions
how to get this to compile?

Here is my ld version:
$ ld -v
GNU gold (GNU Binutils 2.19.1) 1.7

With thanks,
Brian

On Nov 23 2009, 10:27 am, Lei Zhang thes...@chromium.org wrote:
 If you are just testing the Google Chrome build and you don't need
 symbols, you can always comment out the -gstabs line in
 build/common.gypi.



 On Sat, Nov 21, 2009 at 9:10 PM, David Moore davemo...@google.com wrote:
  Problem solved. Coincident with using the new linker I started building the
  Google Chrome build. This uses breakpad, which turns on stabs, which makes
  everything slower and bigger by a factor of 5. Only do the Chrome build if
  you need to is the lesson.
  Dave

  On Sat, Nov 21, 2009 at 8:39 PM, David Moore davemo...@google.com wrote:

  I checked and I compiled with -O2. I see a similar slowdown in the ar
  calls. I also notice that the size of the chrome executable is now 2GB. I
  think before the size was closer to 350MB. It was 750MB if you included
  webkit symbols. Perhaps something changed about the way we're managing
  symbols.
  Dave

  On Sat, Nov 21, 2009 at 6:50 PM, Antoine Labour pi...@google.com wrote:

  On Sat, Nov 21, 2009 at 6:24 PM, David Moore davemo...@google.com
  wrote:

  Since I did this upgrade my builds have gotten very very slow. A single
  file change, recompile and relink used to be about 35 seconds. Now it's 2
  and a half minutes. As far as I can tell I'm using the right gold.

  davemo...@dmoorel:~/chrome/src$ ld --version
  GNU gold (GNU Binutils 2.20) 1.9
  Are other people seeing this on linux?
  Dave

  Make sure you compile gold with -O2. That made a huge difference for me
  when I was playing with it, and that wasn't the default for some reason.
  Antoine

  On Wed, Nov 18, 2009 at 2:47 AM, Lei Zhang thes...@chromium.org wrote:

  Hi folks,

  We'll soon be relanding a patch that pass --gc-sections to the linker
  on Linux. For this to work, you need either GNU ld or a recent version
  of GNU gold. You can test and see if your copy of gold is new enough
  by running:

  /path/to/gold --gc-sections

  If you see: fatal error: no input files, _no action_ is required.
  If you see: --gc-sections:unknownoption, then you _need to
  upgrade_.

  If you installed gold through [1], please run it again. I've updated
  the script at r32315 to install gold 2.20. I've also updated all the
  Linux build / try bots to gold 2.20.

  [1]http://src.chromium.org/svn/trunk/src/build/install-build-deps.sh

  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
     http://groups.google.com/group/chromium-dev

  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
 http://groups.google.com/group/chromium-dev
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Re: [Chrome-team] Re: [Mac] Something is eating the right mouse button events in the Toolbar. Help!

2010-01-11 Thread Mike Pinkerton
Can you compare what happens when you right-click on the omnibox vs. a
bookmark button? It might be interesting to see where/how those stacks
differ.

On Mon, Jan 11, 2010 at 2:55 PM, Andrew Bonventre andyb...@chromium.org wrote:
 Wrong list. Oops.

 On Mon, Jan 11, 2010 at 2:50 PM, Andrew Bonventre (Bons)
 andyb...@google.com wrote:
 I'm attempting to add context menus to Browser Action buttons within
 the toolbar, but I've hit a snag and cannot for the life of me figure
 out what is happening with my events...

 - (void)onRightMouseDown:(NSEvent*)theEvent; is never being called
 within my NSButton subclass, and in fact, any other portion of the
 Toolbar controller except for the Omnibar. I've tried overloading the
 function within BrowserActionButton, ToolbarController and
 ToolbarView, only to never have it called. In order to track down the
 codepath for a right mouse down event that _does_ work in the toolbar,
 I got a stacktrace of the context menu code within the Omnibar:

 #0      0x001c7454 in -[AutocompleteTextFieldEditor menuForEvent:] at
 autocomplete_text_field_editor.mm:89
 #1      0x92ecf0ae in -[NSView rightMouseDown:]
 #2      0x92e3e1ef in -[NSTextView rightMouseDown:]
 #3      0x929adfe0 in -[NSWindow sendEvent:]
 #4      0x001f6c58 in -[ChromeEventProcessingWindow sendEvent:] at
 chrome_event_processing_window.mm:101
 #5      0x001f58a7 in -[ChromeBrowserWindow sendEvent:] at
 chrome_browser_window.mm:300
 #6      0x928c6b2f in -[NSApplication sendEvent:]
 #7      0x0078b18a in -[CrApplication sendEvent:] at 
 chrome_application_mac.mm:33
 #8      0x9285a4ff in -[NSApplication run]
 ...

 I have confirmed that -[ChromeEventProcessingWindow sendEvent:] IS
 being called on right mouse clicks and therefore NSWindow's sendEvent
 is being called.

 Any ideas would be greatly appreciated. Something is eating them up
 and I don't know what's going on.

 A


 --
 You received this message because you are subscribed to the Google Groups 
 Chrome-team group.
 To post to this group, send email to chrome-t...@google.com.
 To unsubscribe from this group, send email to 
 chrome-team+unsubscr...@google.com.
 For more options, visit this group at 
 http://groups.google.com/a/google.com/group/chrome-team/?hl=en.







-- 
Mike Pinkerton
Mac Weenie
pinker...@google.com
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-11 Thread Paweł Hajdan , Jr .
Is there any security risks with passing raw ftp listings to the
renderer in case we can't parse them? We already have a check in the
code so that we will only make a data connection to the server we have
the control connection with.

If it's ok to do so, I'd also like to include some message encouraging
the user to submit a bug report like hey, Chrome FTP listing parser
is not compatible with this site. That would really help with
compatibility. The new listing parser is doing quite well, but I think
it's still not compatible enough to entirely replace the Mozilla code.
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Re: [Chrome-team] Re: [Mac] Something is eating the right mouse button events in the Toolbar. Help!

2010-01-11 Thread Drew Wilson
Are you adding application-custom context menus, or is this a static context
menu provided by the browser? I ask, because I'm looking at adding custom
context-menu functionality for extension systray UI, and I'd like to see
what kind of API you came up with.

-atw

On Mon, Jan 11, 2010 at 11:55 AM, Andrew Bonventre andyb...@chromium.orgwrote:

 Wrong list. Oops.

 On Mon, Jan 11, 2010 at 2:50 PM, Andrew Bonventre (Bons)
 andyb...@google.com wrote:
  I'm attempting to add context menus to Browser Action buttons within
  the toolbar, but I've hit a snag and cannot for the life of me figure
  out what is happening with my events...
 
  - (void)onRightMouseDown:(NSEvent*)theEvent; is never being called
  within my NSButton subclass, and in fact, any other portion of the
  Toolbar controller except for the Omnibar. I've tried overloading the
  function within BrowserActionButton, ToolbarController and
  ToolbarView, only to never have it called. In order to track down the
  codepath for a right mouse down event that _does_ work in the toolbar,
  I got a stacktrace of the context menu code within the Omnibar:
 
  #0  0x001c7454 in -[AutocompleteTextFieldEditor menuForEvent:] at
  autocomplete_text_field_editor.mm:89
  #1  0x92ecf0ae in -[NSView rightMouseDown:]
  #2  0x92e3e1ef in -[NSTextView rightMouseDown:]
  #3  0x929adfe0 in -[NSWindow sendEvent:]
  #4  0x001f6c58 in -[ChromeEventProcessingWindow sendEvent:] at
  chrome_event_processing_window.mm:101
  #5  0x001f58a7 in -[ChromeBrowserWindow sendEvent:] at
  chrome_browser_window.mm:300
  #6  0x928c6b2f in -[NSApplication sendEvent:]
  #7  0x0078b18a in -[CrApplication sendEvent:] at
 chrome_application_mac.mm:33
  #8  0x9285a4ff in -[NSApplication run]
  ...
 
  I have confirmed that -[ChromeEventProcessingWindow sendEvent:] IS
  being called on right mouse clicks and therefore NSWindow's sendEvent
  is being called.
 
  Any ideas would be greatly appreciated. Something is eating them up
  and I don't know what's going on.
 
  A
 

 --
 You received this message because you are subscribed to the Google Groups
 Chrome-team group.
 To post to this group, send email to chrome-t...@google.com.
 To unsubscribe from this group, send email to
 chrome-team+unsubscr...@google.com chrome-team%2bunsubscr...@google.com.
 For more options, visit this group at
 http://groups.google.com/a/google.com/group/chrome-team/?hl=en.




-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] displaying unparseable ftp directory listings as-is

2010-01-11 Thread Pierre-Antoine LaFayette
I am looking into an issue involving adding icons for to the ftp directory
listing page, can you point me to where this code is handled? I know that
the HTML template is generated in
ftp_directory_listing_response_delegate.cc. I'm trying to see if its okay to
request icon data from the Browser from within the WebKit glue layer.

Thanks.

2010/1/11 Paweł Hajdan, Jr. phajdan...@chromium.org

 Is there any security risks with passing raw ftp listings to the
 renderer in case we can't parse them? We already have a check in the
 code so that we will only make a data connection to the server we have
 the control connection with.

 If it's ok to do so, I'd also like to include some message encouraging
 the user to submit a bug report like hey, Chrome FTP listing parser
 is not compatible with this site. That would really help with
 compatibility. The new listing parser is doing quite well, but I think
 it's still not compatible enough to entirely replace the Mozilla code.

 --
 Chromium Developers mailing list: chromium-dev@googlegroups.com
 View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev




-- 
Pierre.
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Linux sandbox configuration

2010-01-11 Thread Adam Langley
On Fri, Jan 8, 2010 at 11:36 PM, n179911 n179...@gmail.com wrote:
 Can you please tell me if/where is the file to configure chromium's
 renderer sandbox?

There is no configuration. That's probably why you can't find any :)


AGL
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Re: Linux: gold linker users should upgrade to 2.20 soon.

2010-01-11 Thread Adam Langley
On Mon, Jan 11, 2010 at 11:49 AM, Brian Lum brian...@chromium.org wrote:
 Here is my ld version:
 $ ld -v
 GNU gold (GNU Binutils 2.19.1) 1.7

You have gold 2.19.1. You need gold 2.20.

If install-build-deps.sh didn't work for you then you'll need to fix it.


AGL
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] buildbot failure in Chromium on Chromium Builder (dbg), revision 35944

2010-01-11 Thread buildbot
Automatically closing tree for compile on Chromium Builder (dbg)

http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder%20%28dbg%29/builds/15412

http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Builder%20%28dbg%29

--=  Automatically closing tree for compile on Chromium Builder (dbg)  =--

Revision: 35942, 35943, 35944
Blame list: dglaz...@chromium.org,mbel...@google.com,y...@chromium.org

Buildbot waterfall: http://build.chromium.org/
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-11 Thread Benjamin Smedberg
For what it's worth, the way Firefox solves this is:

* Check if the file is an absolute file path
** on Windows, X:\... or \\...
** on Posix, /...
* Otherwise, it's a URL relative to the current working directory
** So index.html resolves using the URL machinery to
file:///c:/cwd/index.html
** while http://www.google.com resolves to itself

This doesn't deal with the case firefox.exe www.google.com (which would try
to resolve as a file), but we decided not to care about this case. We do
have the explicit firefox.exe -url www.google.com which will perform URI
fixup to guess the correct URL.

--BDS
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 35967

2010-01-11 Thread buildbot
Automatically closing tree for compile on Linux Builder (ChromiumOS)

http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/2142

http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28ChromiumOS%29

--=  Automatically closing tree for compile on Linux Builder (ChromiumOS)  
=--

Revision: 35967
Blame list: s...@chromium.org

Buildbot waterfall: http://build.chromium.org/
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Re: Linux: gold linker users should upgrade to 2.20 soon.

2010-01-11 Thread Brian Lum
Hi,

So Albert Wong figured out what the issue is.  Thanks!  Currently, the
script calls ld --version and checks whether gold is installed or
not.  It does not check the version, so if you have an old version
like I did, then it will not update.

We need to modify the script by changing the *gold* to *gold*2.20*,
but it'll be broken once the next version of gold comes out.  Do we
need to check the versioning?  Right now, I'm looking into using awk
or grep to check for the minimum version number.  Any suggestions
would be welcomed.

Note that version 2.19 works for Debug.  Apparently, I only need 2.20
for Release builds.

Thanks,
Brian

On Mon, Jan 11, 2010 at 1:29 PM, Adam Langley a...@chromium.org wrote:
 On Mon, Jan 11, 2010 at 11:49 AM, Brian Lum brian...@chromium.org wrote:
 Here is my ld version:
 $ ld -v
 GNU gold (GNU Binutils 2.19.1) 1.7

 You have gold 2.19.1. You need gold 2.20.

 If install-build-deps.sh didn't work for you then you'll need to fix it.


 AGL

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] on not displaying the home page in a new tab or window

2010-01-11 Thread Dirk Pranke
As a side thread to the Core Principles / home button thread that
just went around, I have the following question:

Is it by design that if I click on a new tab or a new window, and I
have my preference set to open this page on the home page rather
than use the new tab page, we still show the new tab page?

I.e., we only show the home page when the browser is launched or when
I click on the home button?

If it is (and I can understand the logic that says that clicking on
new tab should display the new tab page), I have a feeling that this
might be really confusing to users:

http://code.google.com/p/chromium/issues/detail?id=25711
http://code.google.com/p/chromium/issues/detail?id=29637
http://code.google.com/p/chromium/issues/detail?id=28940

All look like examples of this. Personally I find it counterintuitive
as well, probably because I don't think any other browser does this.

There seem to be extensions (e.g.,
https://chrome.google.com/extensions/detail/jbnkijekempmdlleaimfelifcejbkmcd
, thanks Nico) that override this behavior, but that's not a
particularly discoverable solution for new users. (I'm not sure what
the answer is to fixing that particular problem).

Comments? Thoughts?

-- Dirk
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

[chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

2010-01-11 Thread Chris Evans
Hi,

I found this interesting: http://a.qoid.us/google.html

Because it's clearly very non-JavaScript focused (just a CSS rotation) and
yet the browsers exhibit very different performance characteristics.

All on my underpowered Windows laptop,
Chrome 3  4: smooth. Very nice anti-aliased accurate rendering.
Safari 4: not quite as smooth; less fps but still not bad. Text / lines more
jagged and text wobbles during the rotation.

The other browsers do not support the CSS used / required for this demo.

There was a similar version, but using SVG animation to do something very
similar. (It's currently offline). Firefox and Opera were able to attempt
the rotation of this one but both performed much worse that Safari and
Chrome.

Anyone know why Chrome, and to a certain extent Safari, are so much better
on this non-JS test? Is the Skia library underpinning Chrome superior?

There's also a difference between Chrome Windows and Chrome Linux. Whilst
Chrome Linux performs smoothly, the text is clearly jiggling around and even
getting more / less bold throughout the rotation cycle. Doesn't do that on
Windows. Any ideas?


Cheers
Chris
-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

2010-01-11 Thread James Robinson
Chromium is spending nearly all of its time inside Skia, so it's likely Skia
vs CG differences:

Welcome to pprof!  For help, type 'help'.
(pprof) top
Total: 1590 samples
 592  37.2%  37.2%  592  37.2% SkRegion::Spanerator::Spanerator
  89   5.6%  42.8%   89   5.6% sk_memset32_SSE2
  87   5.5%  48.3%  135   8.5% TT_RunIns
  71   4.5%  52.8%   71   4.5% S32_opaque_D32_filter_DXDY
  58   3.6%  56.4%   58   3.6% SkAlphaRuns::Break
  52   3.3%  59.7%  996  62.6% walk_edges

- James


On Tue, Jan 12, 2010 at 1:38 AM, Eric Seidel esei...@chromium.org wrote:

 I've filed https://bugs.webkit.org/show_bug.cgi?id=33515

 On Mon, Jan 11, 2010 at 9:04 PM, Chris Evans cev...@chromium.org wrote:
  Hi,
  I found this interesting: http://a.qoid.us/google.html
  Because it's clearly very non-JavaScript focused (just a CSS rotation)
 and
  yet the browsers exhibit very different performance characteristics.
  All on my underpowered Windows laptop,
  Chrome 3  4: smooth. Very nice anti-aliased accurate rendering.
  Safari 4: not quite as smooth; less fps but still not bad. Text / lines
 more
  jagged and text wobbles during the rotation.
  The other browsers do not support the CSS used / required for this demo.
  There was a similar version, but using SVG animation to do something very
  similar. (It's currently offline). Firefox and Opera were able to attempt
  the rotation of this one but both performed much worse that Safari and
  Chrome.
  Anyone know why Chrome, and to a certain extent Safari, are so much
 better
  on this non-JS test? Is the Skia library underpinning Chrome superior?
  There's also a difference between Chrome Windows and Chrome Linux. Whilst
  Chrome Linux performs smoothly, the text is clearly jiggling around and
 even
  getting more / less bold throughout the rotation cycle. Doesn't do that
 on
  Windows. Any ideas?
 
  Cheers
  Chris
  --
  Chromium Developers mailing list: chromium-dev@googlegroups.com
  View archives, change email options, or unsubscribe:
 http://groups.google.com/group/chromium-dev
 

 --
 Chromium Developers mailing list: chromium-dev@googlegroups.com
 View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

2010-01-11 Thread Chris Evans
On Mon, Jan 11, 2010 at 11:01 PM, Evan Martin e...@chromium.org wrote:

 On Mon, Jan 11, 2010 at 9:04 PM, Chris Evans cev...@chromium.org wrote:
  The other browsers do not support the CSS used / required for this demo.
  There was a similar version, but using SVG animation to do something very
  similar. (It's currently offline). Firefox and Opera were able to attempt
  the rotation of this one but both performed much worse that Safari and
  Chrome.
  Anyone know why Chrome, and to a certain extent Safari, are so much
 better
  on this non-JS test? Is the Skia library underpinning Chrome superior?

 I'm not certain, but it sounds like you're comparing CSS rotations in
 the Chrome/Safari case and SVG rotations in the other, so I'm not sure
 it's a fair comparison.  (Unless you mean to say Chrome/Safari were
 more performant for the SVG demo as well.)


Yes, that's what I meant. The SVG demo was pretty much the same: applying a
rotation transform to an iframe of www.google.com. It just happens to be
supported on more of the major browsers (everything except IE).

Cheers
Chris

Two anecdotal comments:
  - In my experience (on Linux) Firefox had really poor SVG
 performance, and that (for example) canvas performs a lot better.  I
 think none of the engines have done much work on SVG, in part because
 basically nobody uses it on the web except for demos like this.
  - Also in my experience Chrome+Skia tends to be faster but sometimes
 less smooth than Safari's CG.  See also all of Dean's Pre3d demos.

  There's also a difference between Chrome Windows and Chrome Linux. Whilst
  Chrome Linux performs smoothly, the text is clearly jiggling around and
 even
  getting more / less bold throughout the rotation cycle. Doesn't do that
 on
  Windows. Any ideas?

 I don't know much about how this rotation business works, but if I had
 to guess from looking at it I'd say hinting is getting involved.

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev