Re: [chromium-dev] WebKit Gardeners 3 rebaseline.py -w

2010-01-09 Thread Eric Seidel
Once we have this sort of tool for webkit.org then those of us who work on webkit.org could just add the new baselines when we commit the patches in the first place. :) On Fri, Jan 8, 2010 at 5:38 PM, Julie Parent jpar...@chromium.org wrote: Yeah, me too. This is what tends to lead to me

Re: [chromium-dev] speed or flakiness

2009-12-10 Thread Eric Seidel
I expect that WebKit folks would be willing to help flight WebKit test flakyness once we move more of our testing infrastructure into the svn.webkit.org repository. You might make a similar plea for help on webkit-dev, although I doubt you'll get a super-positive response until webkit folks can

Re: [chromium-dev] buildbot cycle time dashboard?

2009-12-08 Thread Eric Seidel
http://build.chromium.org/buildbot/waterfall/stats On Tue, Dec 8, 2009 at 2:51 PM, Dan Kegel d...@kegel.com wrote: Hey folks, I seem to recall we have a dashboard somewhere showing the cycle time of each of our build/test bots, but I can't find it.  Can somebody point me to it? If it

Re: [chromium-dev] webkit test flakiness moar better now

2009-11-20 Thread Eric Seidel
That's about the awesomest thing ever. I want this in my build.webkit.org! -eric On Fri, Nov 20, 2009 at 1:58 PM, Ojan Vafai o...@chromium.org wrote: As of yesterday, we now retry any unexpected webkit failures. If they pass the second time around, then we turn the bot orange and list the

Re: [chromium-dev] building without svg

2009-11-16 Thread Eric Seidel
track total binary size here:  http://build.chromium.org/buildbot/perf/dashboard/sizes.html I don't know of any place we track per-module sizes. On Fri, Nov 13, 2009 at 2:33 PM, Eric Seidel esei...@chromium.org wrote: Do we have any hard data about where our binary size goes?  It seems

Re: [chromium-dev] building without svg

2009-11-13 Thread Eric Seidel
Do we have any hard data about where our binary size goes? It seems such data would be very useful. On Fri, Nov 13, 2009 at 2:14 PM, Evan Martin e...@chromium.org wrote: I measured that SVG is nearly a sixth of the binary size of a Chrome debug build.  That's not only more compile time, it's

Re: [chromium-dev] scrolling a text area with shift-pgdn

2009-11-12 Thread Eric Seidel
Looks like this is the WebKit bug URL: https://bugs.webkit.org/show_bug.cgi?id=21955 On Thu, Nov 12, 2009 at 9:41 AM, Ojan Vafai o...@google.com wrote: This is a long-standing WebKit bug. The current behavior is correct for Mac. Linux/Win should behave as you expect. Patches welcome. :) On

[chromium-dev] Re: Assertion failures on Mac OS are super slow

2009-11-09 Thread Eric Seidel
ReportCrash is crawling for stacks and looking up symbol names. If your process is a debug build it has huge symbol tables. I don't know of any way to disable ReportCrash. However, you can add some code to your process to catch the offending symbols and exit instead. You can also run the

[chromium-dev] Re: Reverting a change, the fast way

2009-11-03 Thread Eric Seidel
Interesting. WebKit has similar functionality as: bugzilla-tool rollout 12345 We've found that git reverts are at least an order of magnitude faster than SVN reverse merges. I wonder what bugzilla-tool/drover can learn from one another. -eric On Tue, Nov 3, 2009 at 1:53 PM, Nicolas Sylvain

[chromium-dev] Re: anyone for a webkit review?

2009-10-28 Thread Eric Seidel
Thankfully I'm telelegetic and can read it from here. Looks amazing. Ping me once it's up and I'll give it the ol' r+. -eric On Wed, Oct 28, 2009 at 5:51 PM, Adam Langley a...@chromium.org wrote: On Wed, Oct 28, 2009 at 5:47 PM, Evan Stade est...@chromium.org wrote:

[chromium-dev] Re: Canary bot, now with formatted layout test results

2009-10-15 Thread Eric Seidel
One could show baselines of all the other platforms instead of just an upstream baseline. I'm not really sure from the output what this tool does. So it's difficult for me to tell how useful it would be to upstream. -eric On Thu, Oct 15, 2009 at 8:38 PM, Glenn Wilson gwil...@chromium.org

[chromium-dev] Fwd: [webkit-dev] Visual Studio 2005 ATL Security Update

2009-10-15 Thread Eric Seidel
In case any of you who hack on WebKit aren't on webkit-dev. (If that's you, you should definitely join webkit-dev now. It's very very low traffic and very high signal to noise ratio.) -eric -- Forwarded message -- From: Brian Weinstein bweinst...@apple.com Date: Thu, Oct 15,

[chromium-dev] Re: [LTTF] Flaky tests and setTimeout

2009-10-09 Thread Eric Seidel
YAY! :) Begone ye setTimeout! setTimeout is also lame because it makes the tests run slower. -eric On Fri, Oct 9, 2009 at 9:52 PM, Julie Parent jpar...@chromium.org wrote: For those of you looking into flaky tests - I've found a surprising number of tests that are flaky because they use a

[chromium-dev] WebKit has a buildbot console view too!

2009-09-30 Thread Eric Seidel
Who knew? Looks like Mark (Rowe) recently updated their buildbot: http://build.webkit.org/console Very hot. There is no link to it anywhere that I can see. -eric --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Try-ing WebKit patches (was WebKit Chromium Port Update Sep 29th)

2009-09-29 Thread Eric Seidel
On Tue, Sep 29, 2009 at 11:53 AM, Yaar Schnitman y...@chromium.org wrote: 1. An internal webkit chromium port try bot: Will help test webkit-only patches. At first stage, it will test build failures (saving many of us the need to manually test on 3 platforms), but later will also conduct

[chromium-dev] Re: Green tree task force: How to try upstream Windows layout tests?

2009-09-29 Thread Eric Seidel
WebKit has talked about try servers for a very long time. But none have been made. https://bugs.webkit.org/show_bug.cgi?id=29062 is the most recent discussion about this that I remember. Mark Rowe mr...@apple runs build.webkit.org to my knowledge. -eric On Tue, Sep 29, 2009 at 3:50 PM,

[chromium-dev] Re: Xcode dependency analysis

2009-09-22 Thread Eric Seidel
I'm not sure I understand what you're saying. I assume you're aware that script phases in XCode list explicit dependencies. I think I'd have an easier time parsing your paragraph with specific examples. -eric On Tue, Sep 22, 2009 at 5:30 AM, Thomas Van Lenten thoma...@chromium.org wrote:

[chromium-dev] Re: svn --depth not recognized?

2009-09-21 Thread Eric Seidel
No comment on 1.4 compatibility goals. :) I would bet most developers would want to upgrade to 1.6 for all the speed improvements. Official package: http://www.open.collab.net/downloads/community/ (Which installs it in the strange place of /opt/subversion/bin.) -eric On Mon, Sep 21, 2009 at

[chromium-dev] Re: Git questions

2009-09-18 Thread Eric Seidel
For my use case: If there is more than one commit on a branch, then that is intentional history on my part. :) So yes. -eric On Fri, Sep 18, 2009 at 11:45 AM, Nico Weber tha...@chromium.org wrote: BTW, do you typically have useful history on these branches? Typically the reason to preserve

[chromium-dev] runtime flags

2009-09-08 Thread Eric Seidel
It seems there is some confusion with how Chromium handles command line flags/runtime settings. Could someone who actually knows please post to webkit-dev to explain? https://bugs.webkit.org/show_bug.cgi?id=28941 https://bugs.webkit.org/show_bug.cgi?id=28930 I gave my attempt at an explanation

[chromium-dev] Re: WebKit Chromium Port

2009-09-08 Thread Eric Seidel
On Tue, Sep 8, 2009 at 6:43 PM, Jeremy Orlow jor...@chromium.org wrote: We can probably donate man-power, but I doubt they'll want to take any code from us (for whatever reason)...though we could always ask. :-) Who is they here? We are WebKit. At least all of us with @webkit.orgemail

[chromium-dev] Re: Chromium WebKit.org builder is now live

2009-09-08 Thread Eric Seidel
Yay! As soon as you believe the builder to be stable (give it a couple days), please post a patch to add it to the core builders list: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/buildbot.py#L46 Once it's there, the bugzilla-tool and the commit-queue will not commit patches

[chromium-dev] Re: WebKit Chromium Port

2009-09-08 Thread Eric Seidel
if we want to. To get them added to webkit.org's DNS records we would just need to ask on webkit-dev or ask Mark Rowe directly. -eric On Tue, Sep 8, 2009 at 10:47 PM, Eric Seidel esei...@chromium.org wrote: On Tue, Sep 8, 2009 at 10:39 PM, Jeremy Orlow jor...@chromium.org wrote: If it does work

[chromium-dev] Re: buildbot bisect script

2009-09-03 Thread Eric Seidel
WebKit's is: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/bisect-builds Maybe there is code to share there? Or with a fancier python one from Chromium we can replace that old perl thing. -eric On Thu, Sep 3, 2009 at 6:30 PM, Evan Martin e...@chromium.org wrote: I feel a couple

[chromium-dev] Re: Parallel builds w/ VS2005 (or, what Darin learned after mistakenly committing changes to common.gypi)

2009-08-14 Thread Eric Seidel
That is really slick. gyp-authors++ -eric On Fri, Aug 14, 2009 at 2:02 PM, Darin Fisher da...@chromium.org wrote: If you are like me and accustomed to hacking build/common.gypi to enable /MP under VS2005, then please read on: It turns out that there is a better way! Instead, just create a

[chromium-dev] Re: Clobbering

2009-08-11 Thread Eric Seidel
Never mind, that line is already complete! GENERATE_BINDINGS_SCRIPTS = \ bindings/scripts/CodeGenerator.pm \ bindings/scripts/IDLParser.pm \ bindings/scripts/IDLStructure.pm \ bindings/scripts/generate-bindings.pl \ On Tue, Aug 11, 2009 at 7:51 AM, Eric Seidel esei

[chromium-dev] Re: Font used in groups.google.com in Chromium on MacOSX

2009-08-08 Thread Eric Seidel
The fix is awaiting review:https://bugs.webkit.org/show_bug.cgi?id=19161 On Sat, Aug 8, 2009 at 10:37 AM, Adam Barth aba...@chromium.org wrote: I believe Eric Seidel just fixed this bug. He can tell you more. Adam On Sat, Aug 8, 2009 at 10:03 AM, n179911n179...@gmail.com wrote: Hi

[chromium-dev] Re: Flakiness. Please help.

2009-08-05 Thread Eric Seidel
Do we have a list of flakey tests? I feel like we used to have one... On Wed, Aug 5, 2009 at 9:44 PM, Peter Kasting pkast...@google.com wrote: THIS MAIL APPLIES TO YOU Flakiness is growing. Smash it before it gets bigger, and keep it smashed. *** The MOST IMPORTANT section in this

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

2009-07-22 Thread Eric Seidel
On Wed, Jul 22, 2009 at 10:13 AM, Darin Fisherda...@chromium.org wrote: On Wed, Jul 22, 2009 at 10:09 AM, Peter Kasting pkast...@google.com wrote: Actually, I've never been too sure about reverting in WebKit: does one revert the ChangeLog file too or add another ChangeLog entry at the top

[chromium-dev] Re: Landing WebKit patches

2009-07-17 Thread Eric Seidel
You should know about bugzilla-tool http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/bugzilla-tool if you plan on doing commits for other people. It will make your life much easier. :) bugzilla-tool land-patches BUGNUMBER is all you need. :) (Assuming the tree is green so that all the

[chromium-dev] Re: Layout tests (can't really block my machine from getting them)

2009-07-07 Thread Eric Seidel
This question comes up every so often on webkit-dev. :) The response there has been why does one ever want a webkit source checkout w/o layout tests? - If you're doing development, you need the layout tests. - If you're just want to run tip-of-tree, nightly builds are a better way of doing

[chromium-dev] Re: Trac

2009-07-01 Thread Eric Seidel
I will note that in WebKit's experience Trac is super-slow (at least the version webkit.org is using). Trac does not seem to do much (if any) caching. -eric On Wed, Jul 1, 2009 at 7:27 PM, Jeremy Orlowjor...@chromium.org wrote: Is there any reason we use ViewVC rather than something like trac

[chromium-dev] MYTH: WebKit uses design docs

2009-06-29 Thread Eric Seidel
It seems to be a common misconception of Google engineers joining WebKit that WebKit expects design docs like Google does. I see Google writing design docs a lot. I saw one or two in my 3 years at Apple. I've never seen WebKit use them. Google engineers posted 3 design docs to webkit-dev last

[chromium-dev] Re: [webkit-dev] Changing our IDL syntax to get closer to WebIDL

2009-06-22 Thread Eric Seidel
If our binding code is already upstream by then, Darin may be able to keep Chromium building throughout the process. https://bugs.webkit.org/show_bug.cgi?id=26567 On Mon, Jun 22, 2009 at 9:53 AM, Jeremy Orlowjor...@chromium.org wrote: FYI from the webkit mailing list. We'll probably want to

[chromium-dev] Re: [webkit-dev] Changing our IDL syntax to get closer to WebIDL

2009-06-22 Thread Eric Seidel
burden and impose no cost on the rest of the WebKit project. As a result: On Mon, Jun 22, 2009 at 10:48 AM, Eric Seidel esei...@chromium.org wrote: If our binding code is already upstream by then, Darin may be able to keep Chromium building throughout the process. https://bugs.webkit.org

[chromium-dev] Re: Resurrecting the JSC build.

2009-06-11 Thread Eric Seidel
I think such a build would be useful for performance testing of the rest of our infrastructure. It also makes having a webkit.org chromium-webkit build easier. I'm not sure how hard maintaining such a build would be with the new gyp goodness. -eric On Thu, Jun 11, 2009 at 4:06 PM, Dimitri

[chromium-dev] Re: chrome-bisect.py: Mac Chrome Continuous Build Archive Bisecting

2009-06-06 Thread Eric Seidel
FYI, WebKit also has a script which bisects over binaries (nightly builds): http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/bisect-builds Perhaps long term there is some code to share there (like maybe we can replace their perl script with our python script). ;) -eric On Fri, Jun 5,

[chromium-dev] Re: Is creating a custom PDF rendering backend a sound idea?

2009-05-17 Thread Eric Seidel
I think this would be out of scope for WebKit. Probably would fall under non-goals: http://webkit.org/projects/goals.html That said, I be this already works with the Apple WebKit Windows build. If you build WebKit with CG support on Windows then you likely already have this support from CG. :)

[chromium-dev] Re: src/WEBKIT_MERGE_REVISION

2009-03-24 Thread Eric Seidel
Tracker to use DEPS and then we can kill it. :DG On Mon, Mar 23, 2009 at 10:03 PM, Eric Seidel esei...@chromium.org wrote: Kill it (or I can, as part of the merge tomorrow)... so long as the merge instructions are up to date. On Mon, Mar 23, 2009 at 5:46 PM, Ojan Vafai o...@google.com wrote

[chromium-dev] No Video for you!

2009-03-24 Thread Eric Seidel
FYI, due to: http://trac.webkit.org/changeset/41907 I intend to turn off ENABLE_VIDEO for Chrome until the video folks have a chance to make it work with the re-write we're picking up as part of this merge. I've spoken to hclam and fishd and we believe this will not break any tests (since video

[chromium-dev] Build failing due to v8_mkshapshot.exe crash?

2009-02-20 Thread Eric Seidel
I'm trying to build Chrome this morning and v8_mksnapshot.exe is crashing? This is a clean build. Thoughts? -eric --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: Build failing due to v8_mkshapshot.exe crash?

2009-02-20 Thread Eric Seidel
++ v8_mksnapshot.exe!__tmainCRTStartup() Line 327 + 0x12 bytesC kernel32.dll!7c816fd7() [Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll] On Fri, Feb 20, 2009 at 11:54 AM, Eric Seidel esei...@chromium.org wrote: I'm trying to build

[chromium-dev] Re: list of webkit committers?

2008-12-16 Thread Eric Seidel
The quickest way to get your patches approved, is to submit enough that we can offer you commit access. :) -eric On Tue, Dec 16, 2008 at 2:44 PM, Ojan Vafai o...@chromium.org wrote: On Tue, Dec 16, 2008 at 1:52 PM, Darin Fisher da...@chromium.org wrote: http://nightly.webkit.org/start has a

[chromium-dev] Re: avoiding checking into a closed tree with git-cl

2008-10-28 Thread Eric Seidel
That is s awesome Evan. On Tue, Oct 28, 2008 at 11:11 AM, Evan Martin [EMAIL PROTECTED] wrote: If you're using git-cl, it now can check whether the tree is closed automatically. (Thanks Tony!) 1) Pull a new git-cl. 2) Run git cl config again. It'll ask you for a tree status URL --

[chromium-dev] RefPtr

2008-10-07 Thread Eric Seidel
If you're hacking on WebKit and don't feel like you fully understand RefPtr/PassRefPtr, you should read this: http://webkit.org/coding/RefPtr.html Darin (Adler) just updated it last night. I think it's a useful intro into ref-counting in WebCore. -eric

[chromium-dev] Re: webkit unforking

2008-10-07 Thread Eric Seidel
There are a bajillion logs of #webkit. None of them official. -eric On Tue, Oct 7, 2008 at 2:50 PM, Evan Martin [EMAIL PROTECTED] wrote: Eric asked on #webkit, and (since I don't think they log(?)) I'll just paraphrase a response from there, which is that this is a bad idea since the

[chromium-dev] Re: WebKit merge landing tomorrow afternoon

2008-09-29 Thread Eric Seidel
Greenblatt [EMAIL PROTECTED] wrote: Hi Eric, Is there a document somewhere that describes the changes that we can expect? Regards, Marshall On Mon, Sep 29, 2008 at 6:00 PM, Eric Seidel [EMAIL PROTECTED] wrote: We plan to land the webkit_merge_branch onto trunk tomorrow afternoon. http

[chromium-dev] Re: Fixing a CSS problem?

2008-09-24 Thread Eric Seidel
http://bugs.webkit.org/ is the place to file WebKit-level issues. (Issues which reproduce in both Safari and Chrome). http://webkit.org/quality/reporting.html There are numerous known issues with WebKit's object tag handling:

[chromium-dev] Re: conflicting cairo.h

2008-09-18 Thread Eric Seidel
We no longer compile with PLATFORM(CAIRO) on the merge branch. Thus I expect that can be removed. -eric On Thu, Sep 18, 2008 at 4:13 PM, Evan Martin [EMAIL PROTECTED] wrote: I'm playing with building a no-op test_shell that links in GTK. The GTK header stack pulls in