Re: [chromium-dev] WebKit Gardeners 3 rebaseline.py -w
I started working on upstreaming the rebaseline tool, which is part of the plan for upstreaming layout tests in Q1. On Sat, Jan 9, 2010 at 2:53 PM, Eric Seidel esei...@chromium.org wrote: Once we have this sort of tool for webkit.org then those of us who work on webkit.org could just add the new baselines when we commit the patches in the first place. :) On Fri, Jan 8, 2010 at 5:38 PM, Julie Parent jpar...@chromium.org wrote: Yeah, me too. This is what tends to lead to me spending the day after my gardening rotation doing clean up. Maybe if we had 2 people gardening at the same time they could do this real time, but on a normal day, I think it is too much for one person. This tool is awesome though! Julie On Fri, Jan 8, 2010 at 4:54 PM, Jeremy Orlow jor...@chromium.org wrote: Same here. On Fri, Jan 8, 2010 at 4:51 PM, Drew Wilson atwil...@chromium.org wrote: Do you find that you have time to figure out if rebaselining a test is the right thing to do while you're actively gardening? Maybe I just work too slowly, but I often find that if I'm trying to rebaseline on the fly, it requires that I do at least *some* investigation of the test failure to make sure I'm not rebaselining in an error (or rebaselining a test that is merely flaky) which slows me down enough that I fall behind and inevitably am crushed by the WebKit juggernaut. -atw On Fri, Jan 8, 2010 at 4:33 PM, Dimitri Glazkov dglaz...@chromium.org wrote: Before heading out for the weekend, I just want to mention this: rebaseline tool really, really rocks. And yesterday I discovered an option that I, to my shame, hadn't seen before: -w. This option pulls baselines from the canary. It's like getting test expectations from the future! In other words, there are no more excuses for you, dear WebKit gardeners, to commit those ghastly BUG_SOMENAME entries in test_expectations. The workflow is mind-numbingly simple: 1) Identify tests that need rebaselining prior to rolling 2) Add these tests to test_expectations.txt as if you were to commit them -- except add a REBASELINE flag next to BUG_SOMENAME 3) Run rebaseline -w 4) Make sure that the tool ran and removed these entries from test_expectations.txt 5) Create CL -- you will notice how new expected result files are conveniently added for you. 6) Enjoy regression-free WebKit roll. Big thanks to Victor Wang for this amazing instrument of everlasting harmony. Send him your accolades. Or cash. If you find bugs/quirks, fix them. :DG P.S. As part of gardener/sheriff process overhaul, I will be adding these and other helpful tips/hints to our gardening doc. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
I don't get third_party/WebKit/LayoutTests by excluding it in my .gclient,
not sure why it doesn't work for you. here is custom_deps section in my
.gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett james.l.howl...@gmail.comwrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: How to exclude src/third_party/WebKit/LayoutTests when checkout chromium source code
By the way, in your client, you won't be able to exclude the
whole src/webkit/data/layout_tests directory, only the LayoutTests
subdirectory can be excluded, you will still pull other subdirectories like
chrome, platform, pending etc.
On Thu, Jul 16, 2009 at 9:17 AM, Victor Wang vict...@chromium.org wrote:
I don't get third_party/WebKit/LayoutTests by excluding it in my .gclient,
not sure why it doesn't work for you. here is custom_deps section in my
.gclient:
custom_deps : {
# To use the trunk of a component instead of what's in DEPS:
#component: https://svnserver/component/trunk/;,
# To exclude a component from your working copy:
#data/really_large_component: None,
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests/LayoutTests: None,
},
On Wed, Jul 15, 2009 at 7:38 PM, James Howlett
james.l.howl...@gmail.comwrote:
How to exclude src/third_party/WebKit/LayoutTests when checkout
chromium source code?
I have added this to my .gclient
src/third_party/WebKit/LayoutTests: None,
src/webkit/data/layout_tests: None,
the directory src/webkit/data/layout_tests was excluded, but diectory
src/third_party/WebKit/LayoutTests is NOT excluded. Everytime, i
remove src/third_party/WebKit/LayoutTests, and then do a gclient sync,
it pulls does all the source again.
Can you please tell me how to exclude both directories?
Thank you.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
Hi, LayoutTests has been moved from webkit/data to third_party/WebKit. You should sync your client and do the following after sync: -. If your client excludes LayoutTests, remove the following line from .gclient file after sync. No need to have the old one anymore. src/webkit/data/layout_tests/LayoutTests: None, You still need this line: src/third_party/WebKit/LayoutTests: None, -. If your client includes LayoutTests, manually remove directory src/webkit/data/layout_tests/LayoutTests to save space. I also updated the developer docs that will be affected by this change. If I miss any docs, feel free to change them from webkit/data/layout_tests/LayoutTests to third_party/WebKit/LayoutTests. Let me know if you have any questions. Thanks, Victor On Fri, Jul 10, 2009 at 1:31 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: Right. Victor is just switching the tests to reside where they needed to be, not dealing with test results. Test results is somewhat of a longer story and we're not tackling this yet. :DG On Fri, Jul 10, 2009 at 12:07 PM, Victor Wangvict...@chromium.org wrote: On Fri, Jul 10, 2009 at 11:11 AM, Ryosuke Niwa rn...@google.com wrote: On Thu, Jul 9, 2009 at 3:09 PM, Victor Wang vict...@chromium.org wrote: If you DO NOT check out chromium source code, you can stop reading. What's the change? To reduce people's confusion about the LayoutTests directory, I am moving it from src/webkit/data/layout_tests/LayoutTests to src/third_party/WebKit/LayoutTests. For details of this request, see issue: http://code.google.com/p/chromium/issues/detail?id=8765 Does this mean that in the future, all expected results will be in WebKit? i.e. we no longer need to update Chromium tree whenever WebKit changes expected results. I think eventually we will get rid of chrome and upstream platform. For now, I just move the LayoutTests directory. Ojan or Dimitri can correct me if I am wrong. Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Moving LayoutTests to src/third_party/WebKit
If you DO NOT check out chromium source code, you can stop reading.
*What's the change?*
To reduce people's confusion about the LayoutTests directory, I am moving it
from *src/webkit/data/layout_tests/LayoutTests* to *src/third_party/WebKit/*
*LayoutTests*. For details of this request, see issue:
http://code.google.com/p/chromium/issues/detail?id=8765
The first patch http://codereview.chromium.org/146112 related to this
directory moving has been committed. The patch allows run_webkit_tests.py to
support both src/webkit/data/layout_tests/LayoutTests and
src/third_party/WebKit/LayoutTests directories
I have a pending patch http://codereview.chromium.org/155115 that actual
moves the directory. I am planning to move the directory next Monday after
Nicholas updates the buildbot gclient configurations.
*What do you need to do NOW?*
-. If you have LayoutTests as part of your client or don't care the size of
your working copy, you DO NOT need to do anything *now*.
-. If you excluded LayoutTests from your client and want continue to exclude
them, please add the following line to custom_deps section in your .gclient
file:
src/third_party/WebKit/LayoutTests: None,
For example, if you have an old .gclient like this:
custom_deps : {
src/webkit/data/layout_tests/LayoutTests: None,
}
You need to change it to:
custom_deps : {
src/webkit/data/layout_tests/LayoutTests: None,
src/third_party/WebKit/LayoutTests: None,
}
*What's Next?*
I will send out email once the patch is committed (planned for next Monday).
You may want sync your client and do following after sync: -. For those who
exclude LayoutTests in their client, remove the following line from .gclient
file. No need to have the old one anymore.
src/webkit/data/layout_tests/LayoutTests: None,
You still need this line: src/third_party/WebKit/LayoutTests: None,
-. For those who include LayoutTests in their client, manually remove
directory src/webkit/data/layout_tests/LayoutTests to save space.
Let me know if you have any questions.
Thanks,
Victor
*
*
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Moving LayoutTests to src/third_party/WebKit
On Fri, Jul 10, 2009 at 11:11 AM, Ryosuke Niwa rn...@google.com wrote: On Thu, Jul 9, 2009 at 3:09 PM, Victor Wang vict...@chromium.org wrote: If you DO NOT check out chromium source code, you can stop reading. *What's the change?* To reduce people's confusion about the LayoutTests directory, I am moving it from *src/webkit/data/layout_tests/LayoutTests* to * src/third_party/WebKit/**LayoutTests*. For details of this request, see issue: http://code.google.com/p/chromium/issues/detail?id=8765 Does this mean that in the future, all expected results will be in WebKit? i.e. we no longer need to update Chromium tree whenever WebKit changes expected results. I think eventually we will get rid of chrome and upstream platform. For now, I just move the LayoutTests directory. Ojan or Dimitri can correct me if I am wrong. Ryosuke --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
