[chromium-dev] Re: Crashes due to 25633
We've decided to keep this CHECK until it hits dev channel for a few days. The fact that users are hitting this means that we need to get meaningful dumps so we can file actionable bugs from it. We'll monitor the crash rate and release a patch for dev channel if it is too high. In the meantime the solution is either: 1) Have the affected users use a new profile. If the user want to send us his/her corrupted profile that is great. or 2) comment out line 53 in sqlite_utils.cc and roll your own build I recommend option 1. You can simply delete the existing profile dir (default) or user --user-data-dir to specify the location for a new profile. -cpu ps. There is a new sqlite wrapper but is not being used extensively yet. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On 09/17/2009 05:41 PM, cpu wrote: We've decided to keep this CHECK until it hits dev channel for a few days. The fact that users are hitting this means that we need to get meaningful dumps so we can file actionable bugs from it. We'll monitor the crash rate and release a patch for dev channel if it is too high. FWIW, I've backed this change out in the Fedora builds. Too many users jumping ship and refusing to test or help debug. ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On Thu, Sep 17, 2009 at 2:50 PM, spotrh spo...@gmail.com wrote: We've decided to keep this CHECK until it hits dev channel for a few days. The fact that users are hitting this means that we need to get meaningful dumps so we can file actionable bugs from it. We'll monitor the crash rate and release a patch for dev channel if it is too high. FWIW, I've backed this change out in the Fedora builds. Too many users jumping ship and refusing to test or help debug. We don't get any crash reports from Fedora users anyway, so I guess having more testers doesn't matter much either way? Which reminds me: do you (or have you considered) driving users towards a page like this? https://wiki.ubuntu.com/Chromium/Debug It is kind of frustrating when users file bug reports but aren't tech-savvy enough to include a backtrace; when they're on Ubuntu we can at least point them there. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On 09/17/2009 06:07 PM, Evan Martin wrote: On Thu, Sep 17, 2009 at 2:50 PM, spotrh spo...@gmail.com wrote: We've decided to keep this CHECK until it hits dev channel for a few days. The fact that users are hitting this means that we need to get meaningful dumps so we can file actionable bugs from it. We'll monitor the crash rate and release a patch for dev channel if it is too high. FWIW, I've backed this change out in the Fedora builds. Too many users jumping ship and refusing to test or help debug. We don't get any crash reports from Fedora users anyway, so I guess having more testers doesn't matter much either way? Which reminds me: do you (or have you considered) driving users towards a page like this? https://wiki.ubuntu.com/Chromium/Debug It is kind of frustrating when users file bug reports but aren't tech-savvy enough to include a backtrace; when they're on Ubuntu we can at least point them there. I will make that sort of a page, but until Fedora includes chromium into its official package repo, few, if any, users will find it. ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
I believe brettw new sqlite wrappers removed that. Maybe he has not landed it or I misunderstood. Let me check. Of course even if landed I don't know to what revision you synch to. Also that points to a bug, possibly sqlite db corruption. Do you mind filling a bug or having one of the users filling it? On Sep 14, 10:35 am, spotrh spo...@gmail.com wrote: A fair amount of the Fedora users using my package are reporting browser crashes when trying to type in the URL bar, and they seem to be caused by the change in 25633: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sqlite_... The code said it is planned to be removed once it has a few days of air time. ... I was wondering if those few days had passed. :) ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On 09/16/2009 02:25 PM, cpu wrote: I believe brettw new sqlite wrappers removed that. Maybe he has not landed it or I misunderstood. Let me check. I don't see any changes to src/chrome/common/sqlite_utils.cc in SVN trunk. ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On 09/16/2009 02:23 PM, Evan Martin wrote: What is the error message? I wonder if there is something Linux-specific where we're getting an error code that is harmless. (We've had a lot of that in code that checks errno where the value differs between Linux and OS X.) User says it reports: [5070:5093:8302515214:FATAL:/mnt/chromium/rpmbuild/BUILD/chromium-20090910svn25958/src/chrome/common/sqlite_utils.cc(52)] Check failed: false. sqlite fatal error 11 ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On Wed, Sep 16, 2009 at 12:44 PM, spotrh spo...@gmail.com wrote: On 09/16/2009 02:23 PM, Evan Martin wrote: What is the error message? I wonder if there is something Linux-specific where we're getting an error code that is harmless. (We've had a lot of that in code that checks errno where the value differs between Linux and OS X.) User says it reports: [5070:5093:8302515214:FATAL:/mnt/chromium/rpmbuild/BUILD/chromium-20090910svn25958/src/chrome/common/sqlite_utils.cc(52)] Check failed: false. sqlite fatal error 11 Hm, that doesn't sound good! #define SQLITE_CORRUPT 11 /* The database disk image is malformed */ --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On Wed, Sep 16, 2009 at 12:59 PM, Evan Martin e...@chromium.org wrote: On Wed, Sep 16, 2009 at 12:44 PM, spotrh spo...@gmail.com wrote: On 09/16/2009 02:23 PM, Evan Martin wrote: What is the error message? I wonder if there is something Linux-specific where we're getting an error code that is harmless. (We've had a lot of that in code that checks errno where the value differs between Linux and OS X.) User says it reports: [5070:5093:8302515214:FATAL:/mnt/chromium/rpmbuild/BUILD/chromium-20090910svn25958/src/chrome/common/sqlite_utils.cc(52)] Check failed: false. sqlite fatal error 11 Hm, that doesn't sound good! #define SQLITE_CORRUPT 11 /* The database disk image is malformed */ FYI, I'm almost finished updating our (locally patched) SQLite to version 3.6.18 instead of 3.6.1 that we have now; apparently 3.6.18 handles corruption much better than 3.6.1 does. (I am holding off checking it in until I can run it through all the tests I can find to make sure something won't break, but other than that it's ready.) I don't know what effect it might have on this issue, but hopefully it will be a good effect... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On 09/16/2009 04:07 PM, Mike Mammarella wrote: FYI, I'm almost finished updating our (locally patched) SQLite to version 3.6.18 instead of 3.6.1 that we have now; apparently 3.6.18 handles corruption much better than 3.6.1 does. (I am holding off checking it in until I can run it through all the tests I can find to make sure something won't break, but other than that it's ready.) I don't know what effect it might have on this issue, but hopefully it will be a good effect... This is good news, but FWIW, this is also a big reason why forking from established upstreams can lead to headaches. Is there any chance of reworking the chromium specific sqlite changes into something that upstream might merge? ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
One of the things I've done is to *find* all of our changes and try to separate them out from one another, so that should help. (I've created a set of patch files which contain all the changes compared to vanilla 3.6.18.) Some of our changes had been sent upstream already, and of those, some have now been merged. I don't know much about exactly why we have all the changes we do though, so I'm not really the best one to make a case for them in sending them upstream. Hopefully we can track down the authors of these patches though, and ask them to push them upstream. --Mike On Wed, Sep 16, 2009 at 1:21 PM, spotrh spo...@gmail.com wrote: On 09/16/2009 04:07 PM, Mike Mammarella wrote: FYI, I'm almost finished updating our (locally patched) SQLite to version 3.6.18 instead of 3.6.1 that we have now; apparently 3.6.18 handles corruption much better than 3.6.1 does. (I am holding off checking it in until I can run it through all the tests I can find to make sure something won't break, but other than that it's ready.) I don't know what effect it might have on this issue, but hopefully it will be a good effect... This is good news, but FWIW, this is also a big reason why forking from established upstreams can lead to headaches. Is there any chance of reworking the chromium specific sqlite changes into something that upstream might merge? ~spot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crashes due to 25633
On Wed, Sep 16, 2009 at 1:07 PM, Mike Mammarella m...@chromium.org wrote: On Wed, Sep 16, 2009 at 12:59 PM, Evan Martin e...@chromium.org wrote: On Wed, Sep 16, 2009 at 12:44 PM, spotrh spo...@gmail.com wrote: On 09/16/2009 02:23 PM, Evan Martin wrote: What is the error message? I wonder if there is something Linux-specific where we're getting an error code that is harmless. (We've had a lot of that in code that checks errno where the value differs between Linux and OS X.) User says it reports: [5070:5093:8302515214:FATAL:/mnt/chromium/rpmbuild/BUILD/chromium-20090910svn25958/src/chrome/common/sqlite_utils.cc(52)] Check failed: false. sqlite fatal error 11 Hm, that doesn't sound good! #define SQLITE_CORRUPT 11 /* The database disk image is malformed */ FYI, I'm almost finished updating our (locally patched) SQLite to version 3.6.18 instead of 3.6.1 that we have now; apparently 3.6.18 handles corruption much better than 3.6.1 does. (I am holding off checking it in until I can run it through all the tests I can find to make sure something won't break, but other than that it's ready.) I don't know what effect it might have on this issue, but hopefully it will be a good effect... To be clear, newer SQLite handles corruption much better in the sense that it detects it and throws SQLITE_CORRUPT in cases which previous code did not detect. In general, if the older code throws SQLITE_CORRUPT, the newer code will also throw SQLITE_CORRUPT. -scott --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
