Nice job. Thanks for doing this.

Now the critic:

Not too happy with the thunk generator:
VirtualAlloc(0, sizeof(_stdcallthunk), MEM_COMMIT | MEM_RESERVE,
PAGE_EXECUTE_READWRITE)

But I am too lazy right now to look at what does the VS2008 thunk
logic looks right now. I would expect the page to be read-only once
the thunk has been created.

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev

Reply via email to