[chromium-dev] Re: OSX cocoa_test_helper.mm and the like in browser.lib.

2009-09-21 Thread Scott Hess

Why is cocoa_test_helper.mm listed in the browser library?  This
results in the class being linked into Google Chrome Framework
(meaning it ships).  Doesn't seem appropriate to me.  This came up
because I have some helper code I was listing in the unit_tests
section of chrome.gyp.  Since it's in browser/cocoa/, it will already
be excluded from other platforms correctly.

I was wondering about test_support_unit or test_support_common, but
AFAICT since the file is in chrome/browser/, that would not be
appropriate for my file.  [cocoa_test_helper.mm doesn't have any
dependencies w/in browser, that I can see, so it could maybe move
there.]

Any thoughts?

-scott

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: OSX cocoa_test_helper.mm and the like in browser.lib.

2009-09-21 Thread Mike Pinkerton

Remove it, see what happens?

On Mon, Sep 21, 2009 at 12:47 PM, Scott Hess sh...@chromium.org wrote:

 Why is cocoa_test_helper.mm listed in the browser library?  This
 results in the class being linked into Google Chrome Framework
 (meaning it ships).  Doesn't seem appropriate to me.  This came up
 because I have some helper code I was listing in the unit_tests
 section of chrome.gyp.  Since it's in browser/cocoa/, it will already
 be excluded from other platforms correctly.

 I was wondering about test_support_unit or test_support_common, but
 AFAICT since the file is in chrome/browser/, that would not be
 appropriate for my file.  [cocoa_test_helper.mm doesn't have any
 dependencies w/in browser, that I can see, so it could maybe move
 there.]

 Any thoughts?

 -scott

 




-- 
Mike Pinkerton
Mac Weenie
pinker...@google.com

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---