This sounds like a great idea to me.
-Darin
On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote:
We don't have very good unit test coverage (in the broad sense, including
ui_tests, test_shell_tests, etc.) for our code. We've always had a policy
that any new code had to have
This sounds great. I'd like to get a unit test started for browser.cc
etc very soon.
-Ben
On Thu, Jan 8, 2009 at 1:24 PM, Darin Fisher da...@chromium.org wrote:
This sounds like a great idea to me.
-Darin
On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote:
We don't have
I think this sounds like an excellent start. We can tweak it if we
notice things not working properly.
Brett
On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote:
We don't have very good unit test coverage (in the broad sense, including
ui_tests, test_shell_tests, etc.) for our
Sounds great, Pam!
I think the gcl command line option to submit without a test should be:
gcl upload --i-am-a-test-slacker
Mike
On Mon, Jan 5, 2009 at 3:25 PM, Pam Greene p...@chromium.org wrote:
We don't have very good unit test coverage (in the broad sense, including
ui_tests,
I think you also need a way to override this in some instances, since
there are methods (especially in views/ and the UI) for which there is
no simple way to verify correctness of an implementation in code -
e.g. a function that paints a series of bitmaps at specific locations.
(Nor would we
Yes, there's an override option in the proposal below. It'll still give a
warning on 'gcl change', but that's harmless.
- Pam
On Mon, Jan 5, 2009 at 4:08 PM, Ben Goodger (Google) b...@chromium.orgwrote:
I think you also need a way to override this in some instances, since
there are methods
