[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-12 Thread Stuart Morgan
On Fri, Jun 12, 2009 at 6:59 AM, Dan Kegel wrote: > Don't you need root for that? Changing the soft limit doesn't require root, and there's apparently no hard limit at all on file descriptors (at least as of Leopard; I don't think that was always true). -Stuart --~--~-~--~~-

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-12 Thread Dan Kegel
On Thu, Jun 11, 2009 at 10:24 PM, Stuart Morgan wrote: >> Also, 256 is a pretty low limit. > > Dialing it up a few notches (say to 1024) to improve the performance > of a better overall solution certainly isn't an issue. Don't you need root for that? - Dan --~--~-~--~~~--

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Stuart Morgan
On Thu, Jun 11, 2009 at 8:03 PM, Michael Nordman wrote: > Sounds like the underlying issue is not the number of requests (or > type of request), but the number of SharedMemory instances in use on > behalf of request handling at any one time. True; I'll take a look at how else SharedMemory is used

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Stuart Morgan
On Thu, Jun 11, 2009 at 7:45 PM, Darin Fisher wrote: > It seems like this issue, since it is about the shared memory used for > streaming resources to a renderer, is not particular to file://.  It could > happen with http:// as well assuming we had a fast enough network or a janky > enough local s

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Michael Nordman
Sounds like the underlying issue is not the number of requests (or type of request), but the number of SharedMemory instances in use on behalf of request handling at any one time. Maybe put some limits on directly on that. When a request gets to the point where it needs a SharedMemory block it may

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Darin Fisher
On Thu, Jun 11, 2009 at 7:45 PM, Darin Fisher wrote: > On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan > wrote: > >> >> I'm working on getting the Intl2 test set from the page cycler up and >> running on the Mac, which currently crashes very quickly. It turns out >> that one of the test pages has

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Darin Fisher
On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan wrote: > > I'm working on getting the Intl2 test set from the page cycler up and > running on the Mac, which currently crashes very quickly. It turns out > that one of the test pages has hundreds of images on it, and we > simultaneously make hundreds

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Aaron Boodman
On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan wrote: > > I'm working on getting the Intl2 test set from the page cycler up and > running on the Mac, which currently crashes very quickly. It turns out > that one of the test pages has hundreds of images on it, and we > simultaneously make hundreds

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Scott Hess
In my experience, taking code which assumes a low number of file descriptors and just ramping up the file descriptor limits to accommodate a particular case doesn't work out well. You end up finding out that there are three or four other edge cases which cause problems, things like O(N^2) code pa

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Jeremy Orlow
On Thu, Jun 11, 2009 at 5:13 PM, Stuart Morgan wrote: > > I'm working on getting the Intl2 test set from the page cycler up and > running on the Mac, which currently crashes very quickly. It turns out > that one of the test pages has hundreds of images on it, and we > simultaneously make hundreds