[chromium-dev] Re: Updating Rietveld by replying to codereview emails
Note: this finds the Rietveld issue number by looking for the last http://codereview.chromium.org/ url in the email. So make sure to leave that url in the email, and if you add another url to a different issue, don't put it at the end. On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malek j...@chromium.org wrote: Just a heads up that you can now reply to code review emails and your reply will show up on Rietveld. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Updating Rietveld by replying to codereview emails
Hm...I wonder how mondrian (an internal Google tool) does it... Maybe the chromium-revi...@googlegroups.com could be changed to chromium-reviews+the review number@googlegroups.com and that could be used instead? On Wed, Jul 8, 2009 at 5:44 PM, John Abd-El-Malek j...@chromium.org wrote: Note: this finds the Rietveld issue number by looking for the last http://codereview.chromium.org/ url in the email. So make sure to leave that url in the email, and if you add another url to a different issue, don't put it at the end. On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malek j...@chromium.orgwrote: Just a heads up that you can now reply to code review emails and your reply will show up on Rietveld. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Updating Rietveld by replying to codereview emails
They put the id in the subject, but I wanted to avoid doing that. The smaller the subject, the more chance of seeing the lgtm or objections of others without reading the email. On Wed, Jul 8, 2009 at 6:17 PM, Jeremy Orlow jor...@chromium.org wrote: Hm...I wonder how mondrian (an internal Google tool) does it... Maybe the chromium-revi...@googlegroups.com could be changed to chromium-reviews+the review number@googlegroups.com and that could be used instead? On Wed, Jul 8, 2009 at 5:44 PM, John Abd-El-Malek j...@chromium.orgwrote: Note: this finds the Rietveld issue number by looking for the last http://codereview.chromium.org/ url in the email. So make sure to leave that url in the email, and if you add another url to a different issue, don't put it at the end. On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malek j...@chromium.orgwrote: Just a heads up that you can now reply to code review emails and your reply will show up on Rietveld. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Updating Rietveld by replying to codereview emails
Excellent! On Jul 6, 2009 9:43 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: This is the best news I've heard in the last week. Thank you, Thank you, Thank you. -- Elliot On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malekj...@chromium.org wrote: Just a heads up that y... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Updating Rietveld by replying to codereview emails
This is the best news I've heard in the last week. Thank you, Thank you, Thank you. -- Elliot On Mon, Jul 6, 2009 at 9:11 PM, John Abd-El-Malekj...@chromium.org wrote: Just a heads up that you can now reply to code review emails and your reply will show up on Rietveld. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
