[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Dirk Pranke
Yup, I've already adopted that. Thanks! On Mon, Jul 13, 2009 at 12:55 PM, Thomas Van Lententhoma...@chromium.org wrote: Quick skimmed reply: Mac already has expectations per OS where we need them, so you might be able to follow that basic model (and maybe small tweaks to the scripts to use

[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Julie Parent
On Mon, Jul 13, 2009 at 1:16 PM, Dirk Pranke dpra...@google.com wrote: Yup, I've already adopted that. Thanks! On Mon, Jul 13, 2009 at 12:55 PM, Thomas Van Lententhoma...@chromium.org wrote: Quick skimmed reply: Mac already has expectations per OS where we need them, so you might be

[chromium-dev] Re: running layout_tests on vista and windows 7

2009-07-13 Thread Tony Chang
(This time using a reply-all) We used to do this for things like faking font metrics. It resulted in lots of if (webkit_glue::IsLayoutTestMode()) code. We moved away from it because it made it made the code more complicated and meant we weren't shipping the code we were testing. I've heard it