[chromium-dev] Re: valgrind updated
Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a broken valgrind. It also adds a patch to properly terminate log files on exec (which gets rid of an annoying delay when running tools/valgrind/chrome_tests.sh on some tests). Separately, http://wiki.corp.google.com/Main/ChromeBuildbotLinux was also updated, and a new valgrind and gold were pushed to the main valgrind bots, codf15[678]. They were missing the long suppressions patch before, so the update should prevent recurrence of one of the intermittent valgrind warnings seen today. (It already had a suppression, but because the suppresson had a line longer than 200 chars, it was ignored.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind updated
it's just a helpful wrapper, doing stuff like --malloc-fill=41 and pointing at the suppression file. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a broken valgrind. It also adds a patch to properly terminate log files on exec (which gets rid of an annoying delay when running tools/valgrind/chrome_tests.sh on some tests). Separately, http://wiki.corp.google.com/Main/ChromeBuildbotLinux was also updated, and a new valgrind and gold were pushed to the main valgrind bots, codf15[678]. They were missing the long suppressions patch before, so the update should prevent recurrence of one of the intermittent valgrind warnings seen today. (It already had a suppression, but because the suppresson had a line longer than 200 chars, it was ignored.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind updated
I believe Pawel is referring to build-valgrind-for-chromium.sh, as in why use this script to build valgrind instead of the system-supplied valgrind. There are a few bugs that aren't in upstream releases that we patch to workaround. https://bugs.kde.org/show_bug.cgi?id=162848 https://bugs.kde.org/show_bug.cgi?id=186796 James On Wed, Jul 22, 2009 at 2:23 PM, Evan Stadeest...@chromium.org wrote: it's just a helpful wrapper, doing stuff like --malloc-fill=41 and pointing at the suppression file. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a broken valgrind. It also adds a patch to properly terminate log files on exec (which gets rid of an annoying delay when running tools/valgrind/chrome_tests.sh on some tests). Separately, http://wiki.corp.google.com/Main/ChromeBuildbotLinux was also updated, and a new valgrind and gold were pushed to the main valgrind bots, codf15[678]. They were missing the long suppressions patch before, so the update should prevent recurrence of one of the intermittent valgrind warnings seen today. (It already had a suppression, but because the suppresson had a line longer than 200 chars, it was ignored.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind updated
Yes, that's what I was asking about. Thanks. On Wed, Jul 22, 2009 at 21:28, James Hawkins jhawk...@chromium.org wrote: I believe Pawel is referring to build-valgrind-for-chromium.sh, as in why use this script to build valgrind instead of the system-supplied valgrind. There are a few bugs that aren't in upstream releases that we patch to workaround. https://bugs.kde.org/show_bug.cgi?id=162848 https://bugs.kde.org/show_bug.cgi?id=186796 James On Wed, Jul 22, 2009 at 2:23 PM, Evan Stadeest...@chromium.org wrote: it's just a helpful wrapper, doing stuff like --malloc-fill=41 and pointing at the suppression file. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a broken valgrind. It also adds a patch to properly terminate log files on exec (which gets rid of an annoying delay when running tools/valgrind/chrome_tests.sh on some tests). Separately, http://wiki.corp.google.com/Main/ChromeBuildbotLinux was also updated, and a new valgrind and gold were pushed to the main valgrind bots, codf15[678]. They were missing the long suppressions patch before, so the update should prevent recurrence of one of the intermittent valgrind warnings seen today. (It already had a suppression, but because the suppresson had a line longer than 200 chars, it was ignored.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: valgrind updated
That's right. You can get a lot of good work out of plain old valgrind-1.4, but it suffers from the bugs James linked to, i.e. it match suppressions with long symbols, and it will produce garbled output after fork(). build-valgrind-for-chromium.sh installs a valgrind that handles those situations better. On Wed, Jul 22, 2009 at 9:28 PM, James Hawkinsjhawk...@chromium.org wrote: I believe Pawel is referring to build-valgrind-for-chromium.sh, as in why use this script to build valgrind instead of the system-supplied valgrind. There are a few bugs that aren't in upstream releases that we patch to workaround. https://bugs.kde.org/show_bug.cgi?id=162848 https://bugs.kde.org/show_bug.cgi?id=186796 James On Wed, Jul 22, 2009 at 2:23 PM, Evan Stadeest...@chromium.org wrote: it's just a helpful wrapper, doing stuff like --malloc-fill=41 and pointing at the suppression file. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a broken valgrind. It also adds a patch to properly terminate log files on exec (which gets rid of an annoying delay when running tools/valgrind/chrome_tests.sh on some tests). Separately, http://wiki.corp.google.com/Main/ChromeBuildbotLinux was also updated, and a new valgrind and gold were pushed to the main valgrind bots, codf15[678]. They were missing the long suppressions patch before, so the update should prevent recurrence of one of the intermittent valgrind warnings seen today. (It already had a suppression, but because the suppresson had a line longer than 200 chars, it was ignored.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
