If you check in patches for someone else, please do the following:* Mention
the person who wrote the patch.
* Since your gcl change is not the same Rietveld issue as the original
review, put a link to the original review in your change description.
* Put a BUG= or http://crbug.com/... line in so the bug gets updated
correctly.
* Either you or the original author should mark the original issue "closed"
and the bug "fixed".

We've had a number of people not doing the last couple steps, which means
that bugs have been patched, but the bug is open with no indication of fixes
on it.  This hinders testing, merging, triage, etc.  Try not to be sloppy!

PK

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to