Re: [chromium-dev] displaying unparseable ftp directory listings as-is
On Mon, Jan 11, 2010 at 12:21 PM, Paweł Hajdan, Jr. phajdan...@chromium.org wrote: Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the control connection with. That should be fine. In general, the render is allowed to see the information contained in these directory listings. Handing off the unparsed listing is very similar to handing off the parsed listings. Adam -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] displaying unparseable ftp directory listings as-is
If an error is detected mid-stream, how about inserting some JS that will modify the DOM to insert a warning block at the top (or bottom) of the view port. You could include a link that when clicked would load the raw stream. Maybe we could achieve that by supporting a query parameter syntax, like: ftp://ftp.site.com/pub/?display=raw That URL could be served as text/plain. -Darin On Mon, Jan 11, 2010 at 12:21 PM, Paweł Hajdan, Jr. phajdan...@chromium.org wrote: Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the control connection with. If it's ok to do so, I'd also like to include some message encouraging the user to submit a bug report like hey, Chrome FTP listing parser is not compatible with this site. That would really help with compatibility. The new listing parser is doing quite well, but I think it's still not compatible enough to entirely replace the Mozilla code. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] displaying unparseable ftp directory listings as-is
Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the control connection with. If it's ok to do so, I'd also like to include some message encouraging the user to submit a bug report like hey, Chrome FTP listing parser is not compatible with this site. That would really help with compatibility. The new listing parser is doing quite well, but I think it's still not compatible enough to entirely replace the Mozilla code. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] displaying unparseable ftp directory listings as-is
I am looking into an issue involving adding icons for to the ftp directory listing page, can you point me to where this code is handled? I know that the HTML template is generated in ftp_directory_listing_response_delegate.cc. I'm trying to see if its okay to request icon data from the Browser from within the WebKit glue layer. Thanks. 2010/1/11 Paweł Hajdan, Jr. phajdan...@chromium.org Is there any security risks with passing raw ftp listings to the renderer in case we can't parse them? We already have a check in the code so that we will only make a data connection to the server we have the control connection with. If it's ok to do so, I'd also like to include some message encouraging the user to submit a bug report like hey, Chrome FTP listing parser is not compatible with this site. That would really help with compatibility. The new listing parser is doing quite well, but I think it's still not compatible enough to entirely replace the Mozilla code. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Pierre. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
