[chromium-dev] who uses third_party/pthread?

2009-09-11 Thread Tim Steele
The browser/sync engine currently depends on pthreads-win32, which about:credits already lists. We have pthreadVC2.lib checked in under src/third_party. The readme says that was used for testkjs (renamed to jsc, I think?) and trunk/WebKit/win/WebKit.vcproj still lists pthreadVC2.lib as a

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Jacob Mandelson
On Thu, Sep 10, 2009 at 10:03:00AM -0700, Dan Kegel wrote: An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what

[chromium-dev] Re: Gears for GNU/Linux

2009-09-11 Thread mE
hi i have google gear and it works for firefox the only problem is that i dont know how to enable it in chromium. i am currently using the ppa build from launchpad on my ubuntu can someone help me On Sep 1, 1:28 am, dhhwai dhh...@gmail.com wrote: You can add a STAR to the following issue to

[chromium-dev] Extensions and XMLHttpRequest

2009-09-11 Thread GOTTMODUS
Hi, I have a problem with the XMLHttpRequest in my extension. I want to receive a file but nothing happens. Can someone please help me with that? Or is it just not implementet yet? My Build: 4.0.207.0 (Ubuntu build 25615) Here is my code: JavaScript: var xhr = new XMLHttpRequest();

[chromium-dev] Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
Hi, I'm a developer at Adobe, on the Flash Builder (formerly Flex Builder) team. I'm trying to figure out how to allow --disable-hang-monitor to work even if Chrome is already running. Flash Builder, for those who aren't familiar with it, is a full IDE for creating Flash (and AIR) apps; one of

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Adam Barth
You can try using the --user-data-dir flag to point the test instance of Chrome at a dedicated testing profile. That will mean the --disable-hang-monitor instance will actually stay around. Adam On Thu, Sep 10, 2009 at 2:40 PM, Mike Morearty m...@morearty.com wrote: Hi, I'm a developer at

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Dan Kegel
On Thu, Sep 10, 2009 at 10:19 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: In this case, the code may have been submitted by a committer without  using the trybots (tsk, tsk).  We don't currently mention the trybots on dev.chromium.org.  Is it time to? Submitting without trybots and

[chromium-dev] Re: Extensions and XMLHttpRequest

2009-09-11 Thread Aaron Boodman
Are you running the XHR in the content script or in the toolstrip? Cross-origin XHR only works in toolstrips and background pages, not content scripts. - a On Fri, Sep 11, 2009 at 2:09 AM, GOTTMODUS kerst...@gmail.com wrote: Hi, I have a problem with the XMLHttpRequest in my extension. I

[chromium-dev] Re: [extensions] RFC: NPAPI manifest change

2009-09-11 Thread Mohamed Mansour
Why not just let the extension developer do different versions him/herself. When I download an extension, I don't want to download libraries/plugins from 10 different architectures. If my operating system is Windows, I would want to download just the .dll file. The extension developer could

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Amanda Walker
On Thu, Sep 10, 2009 at 2:05 PM, Jacob Mandelson ja...@mandelson.org wrote: It was more surprised that I was expected to have built chrome at home under multiple platforms. I wouldn't say that we expect people to build chrome at home under multiple platforms. We expect patches not to break

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Jacob Mandelson
On Fri, Sep 11, 2009 at 12:04:47PM -0700, Pam Greene wrote: On Fri, Sep 11, 2009 at 11:50 AM, Dan Kegel d...@kegel.com wrote: On Thu, Sep 10, 2009 at 10:19 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: In this case, the code may have been submitted by a committer without using

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Dan Kegel
On Fri, Sep 11, 2009 at 12:38 PM, Jacob Mandelson ja...@mandelson.org wrote: I don't think we should require contributors to have access to all platforms, but they do need to be aware of and responsible for them all. There is internal dispute about this then.  Evan Stade and Dan Kegel

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Jacob Mandelson
On Fri, Sep 11, 2009 at 12:49:22PM -0700, Dan Kegel wrote: On Fri, Sep 11, 2009 at 12:38 PM, Jacob Mandelson ja...@mandelson.org wrote: I don't think we should require contributors to have access to all platforms, but they do need to be aware of and responsible for them all. There is

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Jacob Mandelson
On Fri, Sep 11, 2009 at 01:15:22PM -0700, Scott Hess wrote: On Fri, Sep 11, 2009 at 1:03 PM, Jacob Mandelson ja...@mandelson.org wrote: ... And then we got in a long discussion about whether the policy that external contributors need to have built their patches against all three platforms

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Amanda Walker
I don't see any contradiction here. There is no policy about what equipment you need or what you build against. There has always been a policy about breaking the build. The policy is that if any builder on the main waterfall goes red, you need to fix it (if it's simple) or revert it and try

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Scott Hess
On Fri, Sep 11, 2009 at 1:28 PM, Jacob Mandelson ja...@mandelson.org wrote: On Fri, Sep 11, 2009 at 01:15:22PM -0700, Scott Hess wrote: On Fri, Sep 11, 2009 at 1:03 PM, Jacob Mandelson ja...@mandelson.org wrote: ... And then we got in a long discussion about whether the policy that external

[chromium-dev] last known good git commit?

2009-09-11 Thread Yaar Schnitman
Its easy to tell what is the last known good SVN revision for chrome: http://chromium-status.appspot.com/lkgr But what I need is the corresponding last known good GIT commit. Is there a fast way to get it? (I'm currently greping for the SVN lkgr in the git log)

[chromium-dev] Re: last known good git commit?

2009-09-11 Thread Paweł Hajdan Jr .
I think it would be simpler to modify git-cl to know which git commit corresponds to given svn revision. On Fri, Sep 11, 2009 at 13:38, Yaar Schnitman y...@chromium.org wrote: Its easy to tell what is the last known good SVN revision for chrome: http://chromium-status.appspot.com/lkgr But

[chromium-dev] Re: last known good git commit?

2009-09-11 Thread Matt Perry
I have the following aliases in my .gitconfig for this: find-lkgr = !git svn find-rev r$(curl -s http://chromium-status.appspot.com/lkgr) | tail -n 1 merge-lkgr = !git merge $(git find-lkgr) sync-lkgr = !git fetch git find-lkgr git merge-lkgr ; gclient sync You might need to run git fetch

[chromium-dev] Re: who uses third_party/pthread?

2009-09-11 Thread Darin Fisher
If the try bots don't complain, I say remove it ;-) I'm pretty sure we don't need it. -Darin On Fri, Sep 11, 2009 at 8:22 AM, Tim Steele t...@chromium.org wrote: The browser/sync engine currently depends on pthreads-win32, which about:credits already lists. We have pthreadVC2.lib checked in

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
We just discussed that, and decided against using it, because it could be potentially confusing. Most users would be unaware that we were launching in a separate profile, and even someone who did know that we were doing this would probably find it inconvenient. For example, if he does open

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Thu, Sep 10, 2009 at 5:40 PM, Mike Morearty m...@morearty.com wrote: Then let's say the Flash app hits the line where the breakpoint is. The Flash player notifies Flash Builder of the breakpoint, and then blocks, waiting on a socket until Flash Builder tells it what to do next (e.g.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Darin Fisher
I think that is a reasonable feature request. It would be nice however if there were some way to know when to restore the old behavior. Unfortunately, Chrome won't know when you are done. -Darin On Fri, Sep 11, 2009 at 2:10 PM, Mike Morearty m...@morearty.com wrote: We just discussed that,

[chromium-dev] Re: last known good git commit?

2009-09-11 Thread Evan Martin
To simplify Matt's message: $ git svn find-rev r$(curl -s http://chromium-status.appspot.com/lkgr) 8672ced71672761c86c4f5b59d8b49765f35a525 On Fri, Sep 11, 2009 at 1:40 PM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: I think it would be simpler to modify git-cl to know which git commit

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Evan Martin
I guess there's a precedent in the inspector where you can enable various development-related bits (like enable resource tracking). Maybe there's a reasonable place to hook in UI for that there. On Fri, Sep 11, 2009 at 2:24 PM, Darin Fisher da...@chromium.org wrote: I think that is a reasonable

[chromium-dev] Re: last known good git commit?

2009-09-11 Thread Yaar Schnitman
Thanks for the tips, but I'm using git without tracking svn. Is there a way to use git svn find-rev if I haven't done git svn init? On Fri, Sep 11, 2009 at 2:24 PM, Evan Martin e...@chromium.org wrote: To simplify Matt's message: $ git svn find-rev r$(curl -s

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Erik Kay
Also, the inspector already disables the hang monitor dynamically when it stops at a breakpoint since the renderer is stopped at that point, so this may just be a case of exposing this on-off switch via some API. Erik On Fri, Sep 11, 2009 at 2:26 PM, Evan Martin e...@chromium.org wrote: I

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
Could it be like incognito mode, where the window is special and the tabs cannot be pooled with other modes? Then we'd know you were done when all your plugin-dev tabs were gone. -scott On Fri, Sep 11, 2009 at 2:24 PM, Darin Fisher da...@chromium.org wrote: I think that is a reasonable

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
On Fri, Sep 11, 2009 at 2:46 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 5:24 PM, Darin Fisher da...@chromium.org wrote: I think that is a reasonable feature request. It would be nice however if there were some way to know when to restore the old behavior.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:12 PM, Mike Morearty m...@morearty.com wrote: That would work for us too. Seems pretty good -- an easy way for a plugin to say, Temporarily disable the hang monitor, because we are going to be deliberately hung for a little while. But I don't understand how the

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
I think this adds a lot of complexity. On Fri, Sep 11, 2009 at 2:44 PM, Scott Hess sh...@chromium.org wrote: Could it be like incognito mode, where the window is special and the tabs cannot be pooled with other modes? Then we'd know you were done when all your plugin-dev tabs were gone.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void NPN_PopPopupsEnabledState(NPP instance); Perhaps we can do the same thing here: void NPN_PushPluginHangDetectorState(NPP instance, NPBool enabled); void NPN_Pop

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 2:46 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 5:24 PM, Darin Fisher da...@chromium.org wrote: I think that is a reasonable feature request. It would be nice however if there were some way to know when to restore the old behavior.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
Another alternative would be a ping type call to say I'm unresponsive, and I mean it. Like a watchdog timer. The plug-in could still effectively be hung, but at least it has to have things together enough to call the watchdog. -scott On Fri, Sep 11, 2009 at 3:37 PM, John Abd-El-Malek

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.org wrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions. How else would an end-user get a plugin installed for Chrome? I don't

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:41 PM, Scott Hess sh...@chromium.org wrote: Another alternative would be a ping type call to say I'm unresponsive, and I mean it. Like a watchdog timer. The plug-in could still effectively be hung, but at least it has to have things together enough to call the

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:50 PM, Mike Mammarella m...@chromium.org wrote: Perhaps rather than disabling the hang monitor altogether what that could do is add an additional option to the warning the first time: don't notify me again. If you click that, then it will disable the hang monitor

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
Since the hang dialog comes up in the future after you've shifted your focus elsewhere, if we did any sort of user interaction at all I'd rather the plug-in could say Ask user for permission to disable hang monitor for this context right now. The plug-in hits the breakpoint, calls that function,

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.org wrote: For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void NPN_PopPopupsEnabledState(NPP instance); Perhaps we can do the same thing here: void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:53 PM, Scott Hess sh...@chromium.org wrote: Since the hang dialog comes up in the future after you've shifted your focus elsewhere, if we did any sort of user interaction at all I'd rather the plug-in could say Ask user for permission to disable hang monitor for this

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
On Fri, Sep 11, 2009 at 3:54 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.orgwrote: For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
On Fri, Sep 11, 2009 at 3:44 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.orgwrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 3:44 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.orgwrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:01 PM, Mike Morearty m...@morearty.com wrote: On Fri, Sep 11, 2009 at 3:54 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.orgwrote: For reference, something similar is done for popups: void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 7:31 PM, John Abd-El-Malek j...@chromium.org wrote: If this sounds good to you, the next step would be getting a broader discussion with other browser vendors on the plugin-futures mailing list ( https://mail.mozilla.org/listinfo/plugin-futures). Since the other

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 7:28 PM, John Abd-El-Malek j...@chromium.org wrote: Through whatever plugin installer they have (i.e. Flash's installer) or the toolkit (i.e. Flash Builder). So are you suggesting there is a better way to package an NPAPI plugin for Chrome than to build a CRX? On

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:34 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 7:28 PM, John Abd-El-Malek j...@chromium.orgwrote: Through whatever plugin installer they have (i.e. Flash's installer) or the toolkit (i.e. Flash Builder). So are you suggesting there is a better

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:32 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 7:31 PM, John Abd-El-Malek j...@chromium.orgwrote: If this sounds good to you, the next step would be getting a broader discussion with other browser vendors on the plugin-futures mailing list (

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Evan Martin
On Fri, Sep 11, 2009 at 4:45 PM, John Abd-El-Malek j...@chromium.org wrote: On Fri, Sep 11, 2009 at 4:32 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 7:31 PM, John Abd-El-Malek j...@chromium.org wrote: If this sounds good to you, the next step would be getting a broader

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
So, since Flash is installed by means other than as part of an Extension, does that mean that John Tamplin's suggestion of giving permissions via manifest.json won't work for me? I take it manifest.json is something that only applies to extensions, and not to the other methods of installing a

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:52 PM, Mike Morearty m...@morearty.com wrote: So, since Flash is installed by means other than as part of an Extension, does that mean that John Tamplin's suggestion of giving permissions via manifest.json won't work for me? I take it manifest.json is something that

[chromium-dev] Fighting the flakiness, animations

2009-09-11 Thread Paweł Hajdan Jr .
I wonder if we could deal with animating parts of the browser (like find window, bookmark bar, etc) just in one way: wait for a specified number of animations to finish. The alternative is to add notification for each thing: find window stopped animating, bookmark bar stopped animating, and so on.

[chromium-dev] Re: Fighting the flakiness, animations

2009-09-11 Thread Evan Stade
I would say take an approach similar to the View ID stuff. Make each animation user (optionally) set an ID on the animation object, then have an AnimationEnded notification which publishes the ID of the animation that ended. See browser/view_ids.h

[chromium-dev] Avoiding DevToolsSanityTest bustages

2009-09-11 Thread Paweł Hajdan Jr .
DevToolsSanityTest flips frequently between enabled and disabled. It seems to be mostly caused by changes in WebKit. I see two nice ways to prevent that: - run the tests upstream on webkit.org bots (probably hard) - run the tests on our webkit canary bot (should be doable) What do you think?

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Marc-Antoine Ruel
On Fri, Sep 11, 2009 at 4:28 PM, Jacob Mandelson ja...@mandelson.org wrote: The trybot is restricted access to committers only. I'm not a committer, and as such I don't have access. go/chrometryserver M-A --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] economist reevaluates chrome; startup still weak

2009-09-11 Thread Evan Martin
Their startup perf numbers are depressing: From cold, it was taking anything from 20 to 25 seconds for Firefox 3.5 to load his home page. Even Internet Explorer 8 was five seconds nimbler. Opera 10, the latest version of an old favourite from Norway, was faster still. But Chrome 3 blew everything

[chromium-dev] How do you perform tab traversal?

2009-09-11 Thread Daniel Cowx
I'm trying to create a simple dialog box following the exam at http://dev.chromium.org/developers/design-documents/views-windowing. Note that I'm using views as in a standalone app (I'm not embedding this dialog in Chromium). I've added 2 views::Textfields to WindowView, but I can't seem to tab

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Evan Stade
I agree it should be the responsibility of the committer to make sure the code passes the trybots on all platforms (I have in the past made the mistake of thinking the trybots were open to everyone, but they are not). I think many committers will not be willing to go through very many iterations

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Evan Martin
I generally leave the figure out the errors bit to the committer. Once you've made sure a patch isn't malicious: git checkout origin git cl patch -b theirname 12345 # code review number git try git checkout branch_i_was_working_on You can then point them to the try server build page and

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Evan Stade
On Fri, Sep 11, 2009 at 7:03 PM, Evan Martin e...@chromium.org wrote: I generally leave the figure out the errors bit to the committer. I assume you mean the contributor. The problem is then that you are trusting a non-committer to tell you whether to commit, which defeats the purpose of having

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Mohamed Mansour
We could do this instead:gcl try --url http://url/to/patch.diff --email contribut...@email.com --issue rietveldIssueNumber No need to download and apply the patch. - Mohamed Mansour On Fri, Sep 11, 2009 at 10:03 PM, Evan Martin e...@chromium.org wrote: I generally leave the figure out the

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-11 Thread Evan Stade
On Fri, Sep 11, 2009 at 7:07 PM, Mohamed Mansour m...@chromium.org wrote: We could do this instead: gcl try --url http://url/to/patch.diff --email contribut...@email.com --issue rietveldIssueNumber No need to download and apply the patch. - Mohamed Mansour heh, when I first read that I