[chromium-dev] Thinking about refactoring the confluence of processes and ipc channels.

2009-02-04 Thread Scott Hess
[Reposting from wrong mailing list, sorry for dupe.] On Mac/Linux, IPC::Channel uses socketpairs (or in some cases named pipes), with one end passed through the spawn to the child process. Right now the interfaces don't expose this dependency, so I'm thinking of refactoring things a bit to do

[chromium-dev] Re: Thinking about refactoring the confluence of processes and ipc channels.

2009-02-04 Thread Scott Hess
On Wed, Feb 4, 2009 at 11:02 AM, Darin Fisher da...@chromium.org wrote: On Wed, Feb 4, 2009 at 10:54 AM, Scott Hess sh...@chromium.org wrote: On Mac/Linux, IPC::Channel uses socketpairs (or in some cases named pipes), with one end passed through the spawn to the child process. Right now

[chromium-dev] Re: Thinking about refactoring the confluence of processes and ipc channels.

2009-02-04 Thread Scott Hess
On Wed, Feb 4, 2009 at 11:10 AM, Thomas Van Lenten thoma...@chromium.org wrote: On Wed, Feb 4, 2009 at 2:02 PM, Darin Fisher da...@chromium.org wrote: On Wed, Feb 4, 2009 at 10:54 AM, Scott Hess sh...@chromium.org wrote: [Reposting from wrong mailing list, sorry for dupe.] On Mac/Linux, IPC

[chromium-dev] Re: Linux Omnibox

2009-02-23 Thread Scott Hess
On Thu, Feb 19, 2009 at 4:53 AM, Dean McNamee de...@chromium.org wrote: I've started working on a GTK omnibox widget. I'll let you know when I have some more progress. I've been trying to figure out omnibox from the Mac side. I don't see anyone else having claimed it, let me know if I'm

[chromium-dev] Unit tests and anonymous namespaces.

2009-03-03 Thread Scott Hess
On the Mac, code like this: namespace { class MyTest : public testing::Test { }; } // namespace TEST_F(MyTest, ATest) { } generates errors like this: warning: ‘MyTest_ATest_Test’ has a field ‘MyTest_ATest_Test::anonymous’ whose type uses the anonymous namespace warning: ‘MyTest_ATest_Test’

[chromium-dev] Re: Profile Corruption, cause?

2009-03-06 Thread Scott Hess
If SQLite is crashing due to corruption in the database, we should be able to get Dr Hipp to help fix it. But we'd need a repeatable case to send to him. If we had a database which demonstrated this, I could certainly see about crafting a simplified database of example data to replicate the

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-06 Thread Scott Hess
, Darin Fisher da...@chromium.org wrote: On Tue, Mar 3, 2009 at 3:55 PM, Scott Hess sh...@chromium.org wrote: On the Mac, code like this: namespace { class MyTest : public testing::Test { }; } // namespace TEST_F(MyTest, ATest) { } generates errors like this: warning: 'MyTest_ATest_Test

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-06 Thread Scott Hess
2009/3/6 William Chan (陈智昌) willc...@chromium.org: 2009/3/6 Scott Hess sh...@chromium.org: I just wanted to make sure I understood your proposal. Right now, test classes want to be in the anonymous namespace so that unit test files do not have to coordinate with each other in the naming

[chromium-dev] Omnibox q around Mac+Chromium best-practices.

2009-03-19 Thread Scott Hess
I'm refactoring my Omnibox code towards something I'm willing to put up for review, and am realizing that I need to find a way to rule on whether I should have thick Objective-C helpers or thin ones.  Say for instance that I have an NSTableView, I'll need a data source for that, which needs to be

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Scott Hess
is to leverage the --user-data-dir command line switch to force the chrome instance launched by the ui_tests to use a dedicated user data directory.  We toss that directory prior to each test case IIRC. -Darin On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess sh...@chromium.org wrote: I posted this on the irc

[chromium-dev] Re: DO NOT ADD DEPENDENCIES FROM CHROME/VIEWS on CHROME/COMMON

2009-04-26 Thread Scott Hess
On Fri, Apr 24, 2009 at 10:19 PM, Brett Wilson bre...@chromium.org wrote: On Fri, Apr 24, 2009 at 10:10 PM, Aaron Boodman a...@chromium.org wrote: Is it possible to enforce these rules with code rather than capital letters? I don't think I've made this particular error, but it's something I

[chromium-dev] Re: Unpacking Extensions and the Sandbox

2009-05-01 Thread Scott Hess
On Fri, May 1, 2009 at 11:17 AM, Aaron Boodman a...@chromium.org wrote: We can use DuplicateHandle() to get the input file handle in, but I am not sure what to do about getting the directory sturcture out. Crazy-talk: Have the renderer unpack the zip into a SQLite database.

[chromium-dev] Re: Unforking: Canary Bot Lives!

2009-05-01 Thread Scott Hess
HEROIC! On Fri, May 1, 2009 at 2:38 PM, Dimitri Glazkov dglaz...@chromium.org wrote: Hello all, This is kind of a momentous occasion. For the first time -- ever, our WebKit Canary bot (the one that pulls directly from WebKit upstream) has built successfully and was able to run tests:

[chromium-dev] Re: Suggestion for crossplatform ProcessSingleton and ChromeBrowserProcessId()

2009-05-05 Thread Scott Hess
I agree with the earlier argument about not larding startup with things like writing new files to id the coming-up Chrome to late-coming instances. An alternative might be to acquire a lock to protect the profile, and write an id asynchronously after startup. The late-coming instance would see

[chromium-dev] Re: Why is the Mac Omnibox stealing focus?

2009-05-13 Thread Scott Hess
The why is probably because I misunderstood something. With an NSTextField there, we can't set the selection without having focus, which may have confused me into grabbing focus in cases where it isn't needed (or requested). I've been spending some time figuring out where all that code can get

[chromium-dev] Re: Changes to FilePath?

2009-05-13 Thread Scott Hess
This post made me think that we should have infrastructure so that certain unit tests can opt to run in a restricted environment to enforce that someone doesn't come along and add filesystem-access code or other known-bad synchronous APIs. I realize that that is probably hard, and that patches

[chromium-dev] Re: [chromium-reviews] Re: Add in boost_tuple into third-party for use by googlemock in windows.

2009-05-15 Thread Scott Hess
If this is the only reason gmock needs boost, it seems like a better idea would be to push a copy of tuple.h into gmock and submit a patch to make it more self-contained in the first place. -scott On Fri, May 15, 2009 at 11:17 AM, Albert J. Wong (王重傑) ajw...@chromium.org wrote: One other idea

[chromium-dev] Re: Print Settings Mockup

2009-06-02 Thread Scott Hess
I think the headers and footers are confusing (everywhere). Why not just a single popup for each selection which displays a real-time view of each thing? So it might have items like: Header: Bonsai Kitten http://www.shorty.com/bonsaikitten/; Footer: Page 1 of 2

[chromium-dev] Re: Print Settings Mockup

2009-06-02 Thread Scott Hess
? -- Mohamed Mansour On Tue, Jun 2, 2009 at 3:48 PM, Scott Hess sh...@chromium.org wrote: I think the headers and footers are confusing (everywhere).  Why not just a single popup for each selection which displays a real-time view of each thing?  So it might have items like: Header: Bonsai

[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Scott Hess
there, rather than having to go into printer options... -ian 2009/6/2 Scott Hess sh...@chromium.org What I meant was to have a popup full of formatted choices which look like the thing you want to have.  So instead of Page # of #, which is pretty abstract, Page 1 of 2.  Also, instead of have six

[chromium-dev] Re: Throttling URLRequestFileJobs rate?

2009-06-11 Thread Scott Hess
In my experience, taking code which assumes a low number of file descriptors and just ramping up the file descriptor limits to accommodate a particular case doesn't work out well. You end up finding out that there are three or four other edge cases which cause problems, things like O(N^2) code

[chromium-dev] Crash reporting and about:crash.

2009-06-16 Thread Scott Hess
about:crash is quite naturally one of our top crashers. When the Mac dev channel went out, I saw this an entered http://crbug.com/13453 , thinking that the fact that we were receiving those crashes probably meant we'd forgot to disable something before executing the handler. But, no, it's also a

[chromium-dev] Re: Crash reporting and about:crash.

2009-06-16 Thread Scott Hess
On Tue, Jun 16, 2009 at 3:37 PM, Stuart Morganstuartmor...@chromium.org wrote: On Tue, Jun 16, 2009 at 2:32 PM, Scott Hesssh...@chromium.org wrote: So, I'm inclined to mark it WontFix, except that then searches in the Issues database won't find it. Do we think it's something people are

[chromium-dev] Re: Is it possible to create branches?

2009-06-17 Thread Scott Hess
Against that, I sometimes use git to manage breaking reviews up. I'm always a bit unhappy to get a review which includes one bit of complex stuff that needs a bunch of back-and-forth, and another few bits of uncontentious stuff which is easy to +1. I'd rather see those separately, so that the

[chromium-dev] Re: A suggestion to Drastically improve build times,

2009-07-08 Thread Scott Hess
As a general observation on large development teams, infrastructure can get less love, because everyone comes to the team to work on the exciting main product, not the more mundane build infrastructure. If you have ideas on how to fix this stuff, I think it would be perfectly reasonable to put

[chromium-dev] Re: Improving power usage

2009-07-13 Thread Scott Hess
On Mon, Jul 13, 2009 at 9:37 AM, Peter Kastingpkast...@chromium.org wrote: On Mon, Jul 13, 2009 at 9:22 AM, Evan Martin e...@chromium.org wrote: I think it'd be pretty interesting to fully suspend background tabs, but doing it safely is likely tricky.  For example, imagine a page that has

[chromium-dev] Re: base::string16 / WebCore::String incompatibility

2009-07-13 Thread Scott Hess
On Mon, Jul 13, 2009 at 10:10 AM, Jeremy Orlowjor...@chromium.org wrote: On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote: Yes, I think NullableString16 is better than passing a separate bool. Can anyone think of a better name for it? What's wrong with

[chromium-dev] Re: Buildbot performance issue.

2009-07-14 Thread Scott Hess
If I understand right, simply serving the auto-refresh requests is substantial? At least for the main page, a reverse in accelerator mode could turn that into a constant load. [I'd offer to help, but I don't know what kind of technology we're talking about, here.] -scott On Tue, Jul 14, 2009

[chromium-dev] Re: Chromium crash

2009-07-20 Thread Scott Hess
Looks to me like the code in question wouldn't be compiled into release builds in the first place (it's under NDEBUG). So it might be problematic to match it to a known bug, since the known bugs would mostly look different. The general case of Started typing in omnibox and crashed is obviously

[chromium-dev] Re: Mozilla design challenge

2009-07-21 Thread Scott Hess
+1. There are tabs which I am using and will use consistently all the time (mail, calendar, things like that). For awhile on Firefox I had those pinned and turned into favicon-only tabs using extensions, and it mostly worked well. Then there are collections of on deck tabs associated with

[chromium-dev] Re: Mozilla design challenge

2009-07-21 Thread Scott Hess
I don't think it's reasonable to require the user to specify which tabs to suspend, except, perhaps, if we develop a metric for power-hungry tabs and expose that. I think there is some potential for UI geared towards particular use-cases which could be overloaded to also allow more aggressive

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

2009-07-22 Thread Scott Hess
If reverting RELEASE_NOTE really becomes a big problem, someone could write a wrapper script to manage that. That seems more sensible than adding a manually-maintained file. I'm not really sure if the right solution would be to drop RELEASE_NOTE for items which are reverted. If they are

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

2009-07-22 Thread Scott Hess
The stuff I'm implementing is important to _me_, but is it important enough to be in the release notes? Maybe we should have a tag for the issue-tracker which indicates that the issue is release-note-worthy, and we could use action on those bugs to help figure out which items are worthy of being

[chromium-dev] Re: Proposal for adding ChangeLog files to Chromium

2009-07-22 Thread Scott Hess
BTW: if people aren't annotating their CL's with bugs, they SURELY won't annotate them with release notes or update the change log. Just aiming for the path of least resistance, here. -scott On Wed, Jul 22, 2009 at 11:46 AM, Scott Hesssh...@chromium.org wrote: The stuff I'm implementing is

[chromium-dev] Re: better commit descriptions WAS: Proposal for adding ChangeLog files to Chromium

2009-07-22 Thread Scott Hess
On Wed, Jul 22, 2009 at 2:57 PM, Mark Larson (Google)m...@chromium.org wrote: On Wed, Jul 22, 2009 at 14:02, Peter Kasting pkast...@google.com wrote: On Wed, Jul 22, 2009 at 1:49 PM, Jeremy Orlow jor...@chromium.org wrote: Here comes the bike shedding Yes, Evan already concluded that was

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Scott Hess
On Thu, Jul 23, 2009 at 9:01 AM, Nicolas Sylvainnsylv...@chromium.org wrote: On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin e...@chromium.org wrote: On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvainnsylv...@chromium.org wrote: gclient has nothing to do with this case. svn update src/ was

[chromium-dev] Re: Cross-compiling on ARM

2009-08-24 Thread Scott Hess
Would it be possible/reasonable to use distcc plus a farm of cross-compiler machines to let you do faster self-hosted builds? It's not the right solution, but in the past I've found it to sometimes be an easier path to take in the short term while you're working on fixing all the little

[chromium-dev] Re: found corrupted db

2009-09-09 Thread Scott Hess
fts uses what is effectively a form of compression for the index, so most any stream of data will decode at some level. My bet in this case is that the segdir is referencing a segment block which doesn't exist, so someone inappropriately tries to decode NULL. From what I recall of debugging

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
Another alternative would be a ping type call to say I'm unresponsive, and I mean it. Like a watchdog timer. The plug-in could still effectively be hung, but at least it has to have things together enough to call the watchdog. -scott On Fri, Sep 11, 2009 at 3:37 PM, John Abd-El-Malek

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
.) That avoids the need to have a plugin be trusted in any way, but keeps the UI simple unless the plugin knows it wants to display it and get debugged. You'd still have to deal with the dialog once but after that it would get out of your way. --Mike On Fri, Sep 11, 2009 at 3:41 PM, Scott Hess sh

[chromium-dev] Re: Crashes due to 25633

2009-09-16 Thread Scott Hess
On Wed, Sep 16, 2009 at 1:07 PM, Mike Mammarella m...@chromium.org wrote: On Wed, Sep 16, 2009 at 12:59 PM, Evan Martin e...@chromium.org wrote: On Wed, Sep 16, 2009 at 12:44 PM, spotrh spo...@gmail.com wrote: On 09/16/2009 02:23 PM, Evan Martin wrote: What is the error message?  I wonder if

[chromium-dev] Re: custom built chromium *much* slower than chrome

2009-09-17 Thread Scott Hess
Also, if you search for chromium 26042, then the paths all start with branches/195/src/ -scott On Thu, Sep 17, 2009 at 2:15 PM, Amanda Walker ama...@chromium.org wrote: On Thu, Sep 17, 2009 at 5:10 PM, Rozenkraft rozenkr...@gmail.com wrote: Ok, it makes sense now, sorry. I was confused

[chromium-dev] Re: OSX cocoa_test_helper.mm and the like in browser.lib.

2009-09-21 Thread Scott Hess
Why is cocoa_test_helper.mm listed in the browser library? This results in the class being linked into Google Chrome Framework (meaning it ships). Doesn't seem appropriate to me. This came up because I have some helper code I was listing in the unit_tests section of chrome.gyp. Since it's in

[chromium-dev] Re: XP Perf page load regression on morejs and moz page cyclers

2009-10-01 Thread Scott Hess
I think we should be willing to take a temporary performance hit on the dev channel in the interests of generating data which will eventually improve stability. Could we set jemalloc on selected renderer processes? I realize that wouldn't necessarily only impact the target domains, but it might

[chromium-dev] Re: XP Perf page load regression on morejs and moz page cyclers

2009-10-01 Thread Scott Hess
On Thu, Oct 1, 2009 at 11:32 AM, Mike Belshe mbel...@google.com wrote: On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote: Could we set jemalloc on selected renderer processes?  I realize that wouldn't necessarily only impact the target domains, but it might be better than

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread Scott Hess
Our use of exclusive locking and page-cache preloading may open us up more to this kind of shenanigans. Basically SQLite will trust those pages which we faulted into memory days ago. We could mitigate against that somewhat, but this problem reaches into areas we cannot materially impact, such

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread Scott Hess
On Tue, Oct 6, 2009 at 5:09 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote: On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote: On Tue, Oct 6, 2009 at 4:14 PM, John Abd-El-Malek j...@chromium.org wrote:

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread Scott Hess
On Tue, Oct 6, 2009 at 5:24 PM, Dan Kegel d...@kegel.com wrote: 1) zfs was right: checksums are a good idea.  Can we add them to sqlite? I believe so, but I'm still working through the details. And by working I mean thinking. The challenge is in finding places to tuck things away where they

[chromium-dev] Re: detecting tabs using a lot of CPU?

2009-10-07 Thread Scott Hess
You could replace the favicon with a spinning clock or something. It might also be interesting to provide indicators for high memory usage (or perhaps if the recent memory growth is high), or IPC issues. Then again, many users might prefer not to have their tabs attracting attention needlessly.

[chromium-dev] How expensive is setting a crash key for breakpad?

2009-10-07 Thread Scott Hess
In fixing a Mac bug, I recently added a layer to intercept -[NSApplication sendAction:to:from:] and make sure a certain message wasn't forwarded if the target was known to be freed. Since this is sort of a core function for event dispatch, now we're seeing crashdumps with my new method on the

[chromium-dev] My Linux experience got better with a new version of flash.

2009-10-09 Thread Scott Hess
Of course, it didn't ACTUALLY get better until I got annoyed enough to figure out how to upgrade my system's version of flash. I went out and followed web instructions for apt-removing the older version and installed the newer deb from Adobe. Of course, that didn't fix it either.  Eventually it

[chromium-dev] Re: My Linux experience got better with a new version of flash.

2009-10-09 Thread Scott Hess
On Fri, Oct 9, 2009 at 8:55 AM, Evan Martin e...@chromium.org wrote: We de-duplicate multiple instances of the same file.  If you have multiple copies of the same file we attempt to prioritize non-nspluginwrapper versions over nspluginwrapper-wrapped versions. After that, the list of plugins

[chromium-dev] Re: How expensive is setting a crash key for breakpad?

2009-10-09 Thread Scott Hess
.  Unfortunately, right // now, the same dictionary is used for both Breakpad's parameters AND // the Upload parameters. If you look at the code that logs URLs you'll note that a URL is split over several keys. Best regards, Jeremy On Wed, Oct 7, 2009 at 10:48 PM, Scott Hess sh...@chromium.org wrote

[chromium-dev] Re: Who owns crash...@chromium.org and why is there so many updates from it?

2009-10-12 Thread Scott Hess
Does this relate to receiving crashbot emails adding Crash labels on closed-out bugs where the backtrace doesn't apparently have any relevance to the original backtraces involved with the bug? I've gotten a couple of these in the past week. -scott [Unfortunately, I don't remember the earlier

[chromium-dev] Re: Buildbot upgrade

2009-10-13 Thread Scott Hess
On Mon, Oct 12, 2009 at 7:44 AM, Nicolas Sylvain nsylv...@chromium.org wrote: On Sun, Oct 11, 2009 at 11:33 AM, Jeremy Orlow jor...@chromium.org wrote: Is there documentation anywhere for all the parameters you can feed into the buildbot webpage?  If not, a cheat sheet would be really helpful.

[chromium-dev] Re: Spellchecker and memory-mapped dicts

2009-10-22 Thread Scott Hess
On Linux what about mmap() and then madvise() with MADV_WILLNEED? [or posix_fadvise() with POSIX_FADV_WILLNEED on the file descriptor). -scott On Thu, Oct 22, 2009 at 2:06 PM, Steve Vandebogart vand...@chromium.org wrote: If you plan to read the entire file, mmap()ing it, then faulting it in

[chromium-dev] Re: Spellchecker and memory-mapped dicts

2009-10-22 Thread Scott Hess
posix_fadvise should give the same speeds as read()ing it into memory.  IIRC though, posix_fadvise will only read so much in a single request and will let readahead handle the rest after that. -- Steve On Thu, Oct 22, 2009 at 2:27 PM, Scott Hess sh...@chromium.org wrote: On Linux what about mmap

[chromium-dev] Re: Spellchecker and memory-mapped dicts

2009-10-22 Thread Scott Hess
the best way is to fadvise() it in, then mmap() it and use it from there. -- Steve On Thu, Oct 22, 2009 at 2:52 PM, Scott Hess sh...@chromium.org wrote: Faulting it in by hand is only helpful if we're right!  If we're wrong, it could evict other stuff from memory to support a feature which a user

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Scott Hess
Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question, NOT of the class it will finally be, because in the constructor the subclass has not been constructed, yet, and in the destructor the subclass was

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Scott Hess
On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question

[chromium-dev] Re: Which editor do you recommend on Mac OS X?

2009-11-03 Thread Scott Hess
...@chromium.org wrote: I've heard this suggested a few times (not just in this thread) - is there an advantage to running Carbon Emacs instead of plain-old-GNU-Emacs-in-a-terminal? -atw On Tue, Nov 3, 2009 at 1:14 PM, Scott Hess sh...@chromium.org wrote: +1.  I found Aquamacs weird/annoying

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Scott Hess
+100. This is very similar to getting paged about a production problem. Sometimes you get sucked into wasting an hour on easy fixes which don't fix anything. That sets you up for stupid mistakes. So, you broke the build. Take it like a man/woman, revert your change, and land it again when

[chromium-dev] Re: Large commit - update your .gclient files to avoid

2009-11-05 Thread Scott Hess
On Thu, Nov 5, 2009 at 1:33 PM, Antoine Labour pi...@google.com wrote: On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.org wrote: it'd be nice to have a gclient config lean or something like that. It'd be nice for it to be the default in fact. As long as we're on

[chromium-dev] Re: Preventing Incremental Backup of History/Thumbnails

2009-11-09 Thread Scott Hess
Applying incorrect journal files would be bad. SQLite uses a sync cookie to do some tricks WRT keeping the cache warm. I'm somewhat surprised that the same thing isn't used to prevent applying journal files inappropriately. [I don't know this, and should not be spending time verifying it just

Re: [chromium-dev] Re: Preventing Incremental Backup of History/Thumbnails

2009-11-10 Thread Scott Hess
On Mon, Nov 9, 2009 at 6:40 PM, Scott Hess sh...@chromium.org wrote: Applying incorrect journal files would be bad.  SQLite uses a sync cookie to do some tricks WRT keeping the cache warm.  I'm somewhat surprised that the same thing isn't used to prevent applying journal files inappropriately

Re: [chromium-dev] Corrupt Profile

2009-11-11 Thread Scott Hess
lucky, it will just be the Extensions dir or Extensions Cookies file. -scott On Wed, Nov 11, 2009 at 1:35 AM, PhistucK phist...@chromium.org wrote: I have a corrupt profile. Scott Hess wanted to know about these kinds of things, so I e-mailed him more than a week ago, but he did not answer

[chromium-dev] SQLite compression in history database.

2009-11-24 Thread Scott Hess
Long ago when developing fts1, I experimented with using zlib compression as part of the implementation.  It fell by the wayside because it really didn't provide enough performance improvement (I needed an order of magnitude, it didn't provide it), and because of licensing issues (fts1/2/3 are

Re: [chromium-dev] Thoughts on // NOLINT?

2009-12-10 Thread Scott Hess
On Thu, Dec 10, 2009 at 10:58 AM, Peter Kasting pkast...@google.com wrote: On Thu, Dec 10, 2009 at 10:45 AM, Jonathan Dixon j...@chromium.org wrote: In essence: return DoWork(foo) #if defined(OS_POSIX)      DoWork(posix_specific) #endif     ;  // -- Lint complains about this guy I'd

Re: [chromium-dev] Re: [WebGL] Recommending --no-sandbox

2009-12-11 Thread Scott Hess
On Fri, Dec 11, 2009 at 10:43 AM, Glen Murphy g...@chromium.org wrote: As for the info bar/modal dialog:  I've been thinking for a bit, and I'm not sure this is enough.  We have plenty of data that shows users often leave browsers open for a very long time.  The main risk is that someone sets

Re: [chromium-dev] Thread naming

2009-12-31 Thread Scott Hess
On Thu, Dec 31, 2009 at 1:11 AM, Berend-Jan Wever skyli...@chromium.org wrote: It would be nice if we could name all threads, so you know what you're looking at. It would be nice if threads were required to be given a name as part of creation, perhaps with a central registry to make sure things

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-11 Thread Scott Hess
On Sat, Jan 9, 2010 at 3:06 PM, Victor Khimenko k...@google.com wrote: P.S. There are interesting fact related to specifically colon and MacOS. Classic MacOS uses colon as delimeter and you can use slash in filename. when they used POSIX-compliat kernel they needed some way to resolve thus

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-14 Thread Scott Hess
On Thu, Jan 14, 2010 at 1:31 AM, Victor Khimenko k...@google.com wrote: Consider this attack vector: URL file on Desktop. Chrome will be started from known directory, now we need to put malicious file there. Hmm. Easy: create archive with some valuable data AND file http:/www.google.com (as

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-14 Thread Scott Hess
On Thu, Jan 14, 2010 at 6:56 AM, Victor Khimenko k...@google.com wrote: On Thu, Jan 14, 2010 at 5:38 PM, Scott Hess sh...@google.com wrote: On Thu, Jan 14, 2010 at 1:31 AM, Victor Khimenko k...@google.com wrote: Consider this attack vector: URL file on Desktop. Chrome will be started from

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-14 Thread Scott Hess
would understand what we're talking about could trivially write a shell script or alias to handle it, if they care to.] On Thu, Jan 14, 2010 at 9:15 AM, Scott Hess sh...@google.com wrote: On Thu, Jan 14, 2010 at 6:56 AM, Victor Khimenko k...@google.com wrote: On Thu, Jan 14, 2010 at 5:38 PM, Scott

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-14 Thread Scott Hess
On Thu, Jan 14, 2010 at 1:16 PM, Peter Kasting pkast...@google.com wrote: On Thu, Jan 14, 2010 at 9:19 AM, Scott Hess sh...@google.com wrote: [BTW, don't take my argument as support for allowing relative paths on the command-line.  It's such a low-volume use-case that I'd be perfectly fine

Re: [chromium-dev] Re: opening local files with chrome from command line, relative paths

2010-01-14 Thread Scott Hess
BTW, AFAICT on both Mac and Linux, chrome-cmd file.html opens file:///path/to/cwd/file.html. Mac works for opening relative http:/file.html. Since http: is not a valid filename for Windows, I'd say making them all consistent would make sense. On Thu, Jan 14, 2010 at 1:55 PM, Scott Hess sh