[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-16 Thread Mike Morearty
Okay, finally got around to starting this discussion on mozilla plugin-futures. - Mike On Fri, Sep 11, 2009 at 4:53 PM, John Abd-El-Malek j...@chromium.org wrote: On Fri, Sep 11, 2009 at 4:52 PM, Mike Morearty m...@morearty.com wrote: So, since Flash is installed by means other than as

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Thu, Sep 10, 2009 at 5:40 PM, Mike Morearty m...@morearty.com wrote: Then let's say the Flash app hits the line where the breakpoint is. The Flash player notifies Flash Builder of the breakpoint, and then blocks, waiting on a socket until Flash Builder tells it what to do next (e.g.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Darin Fisher
I think that is a reasonable feature request. It would be nice however if there were some way to know when to restore the old behavior. Unfortunately, Chrome won't know when you are done. -Darin On Fri, Sep 11, 2009 at 2:10 PM, Mike Morearty m...@morearty.com wrote: We just discussed that,

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Erik Kay
Also, the inspector already disables the hang monitor dynamically when it stops at a breakpoint since the renderer is stopped at that point, so this may just be a case of exposing this on-off switch via some API. Erik On Fri, Sep 11, 2009 at 2:26 PM, Evan Martin e...@chromium.org wrote: I

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void NPN_PopPopupsEnabledState(NPP instance); Perhaps we can do the same thing here: void NPN_PushPluginHangDetectorState(NPP instance, NPBool enabled); void NPN_Pop

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
Another alternative would be a ping type call to say I'm unresponsive, and I mean it. Like a watchdog timer. The plug-in could still effectively be hung, but at least it has to have things together enough to call the watchdog. -scott On Fri, Sep 11, 2009 at 3:37 PM, John Abd-El-Malek

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.org wrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions. How else would an end-user get a plugin installed for Chrome? I don't

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:41 PM, Scott Hess sh...@chromium.org wrote: Another alternative would be a ping type call to say I'm unresponsive, and I mean it. Like a watchdog timer. The plug-in could still effectively be hung, but at least it has to have things together enough to call the

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:50 PM, Mike Mammarella m...@chromium.org wrote: Perhaps rather than disabling the hang monitor altogether what that could do is add an additional option to the warning the first time: don't notify me again. If you click that, then it will disable the hang monitor

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Scott Hess
Since the hang dialog comes up in the future after you've shifted your focus elsewhere, if we did any sort of user interaction at all I'd rather the plug-in could say Ask user for permission to disable hang monitor for this context right now. The plug-in hits the breakpoint, calls that function,

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.org wrote: For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void NPN_PopPopupsEnabledState(NPP instance); Perhaps we can do the same thing here: void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 6:53 PM, Scott Hess sh...@chromium.org wrote: Since the hang dialog comes up in the future after you've shifted your focus elsewhere, if we did any sort of user interaction at all I'd rather the plug-in could say Ask user for permission to disable hang monitor for this

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
On Fri, Sep 11, 2009 at 3:54 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.orgwrote: For reference, something similar is done for popups: void NPN_PushPopupsEnabledState(NPP instance, NPBool enabled); void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
On Fri, Sep 11, 2009 at 3:44 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.orgwrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 3:44 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:38 PM, John Abd-El-Malek j...@chromium.orgwrote: I presume you're referring to Chrome extensions? I don't see the advantage of making this depend on the plugin being distributed via extensions.

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:01 PM, Mike Morearty m...@morearty.com wrote: On Fri, Sep 11, 2009 at 3:54 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 6:37 PM, John Abd-El-Malek j...@chromium.orgwrote: For reference, something similar is done for popups: void

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 7:31 PM, John Abd-El-Malek j...@chromium.org wrote: If this sounds good to you, the next step would be getting a broader discussion with other browser vendors on the plugin-futures mailing list ( https://mail.mozilla.org/listinfo/plugin-futures). Since the other

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Tamplin
On Fri, Sep 11, 2009 at 7:28 PM, John Abd-El-Malek j...@chromium.org wrote: Through whatever plugin installer they have (i.e. Flash's installer) or the toolkit (i.e. Flash Builder). So are you suggesting there is a better way to package an NPAPI plugin for Chrome than to build a CRX? On

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:32 PM, John Tamplin j...@google.com wrote: On Fri, Sep 11, 2009 at 7:31 PM, John Abd-El-Malek j...@chromium.orgwrote: If this sounds good to you, the next step would be getting a broader discussion with other browser vendors on the plugin-futures mailing list (

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread Mike Morearty
So, since Flash is installed by means other than as part of an Extension, does that mean that John Tamplin's suggestion of giving permissions via manifest.json won't work for me? I take it manifest.json is something that only applies to extensions, and not to the other methods of installing a

[chromium-dev] Re: Enabling --disable-hang-monitor for new windows when Chrome is already running

2009-09-11 Thread John Abd-El-Malek
On Fri, Sep 11, 2009 at 4:52 PM, Mike Morearty m...@morearty.com wrote: So, since Flash is installed by means other than as part of an Extension, does that mean that John Tamplin's suggestion of giving permissions via manifest.json won't work for me? I take it manifest.json is something that