Re: [chrony-dev] [PATCH] ntp_core.c: Remove useless assignment `prev = inst->local_rx;`

2013-10-03 Thread Miroslav Lichvar
On Thu, Oct 03, 2013 at 03:03:09PM +0200, Paul Menzel wrote: > Am Donnerstag, den 03.10.2013, 14:48 +0200 schrieb Miroslav Lichvar: > > --- a/ntp_core.c > > +++ b/ntp_core.c > > @@ -1548,6 +1548,8 @@ NCR_SlewTimes(NCR_Instance inst, struct timeval > > *when, double dfreq, double doff > > #ifdef

[chrony-dev] Logs from scan-build from Clang 3.4-1

2013-10-03 Thread Paul Menzel
Dear chrony developers, using the Clang static analyzer scan-build from Debian Clang version 3.4-1, the following warnings are printed. $ git describe origin/master 1.29-3-g169eee6 $ scan-build -analyze-headers -o scan-build make -j2 scan-build: Using

Re: [chrony-dev] [PATCH] ntp_core.c: Remove useless assignment `prev = inst->local_rx;`

2013-10-03 Thread Paul Menzel
Am Donnerstag, den 03.10.2013, 14:48 +0200 schrieb Miroslav Lichvar: > On Thu, Oct 03, 2013 at 02:34:46PM +0200, Paul Menzel wrote: > > The Clang static analyzer scan-build found the following unneeded > > assignment. > > > > /usr/share/clang/scan-build/ccc-analyzer -O2 -g -c sources.c >

[chrony-dev] [PATCH] rtc_linux.c: Remove useless assignment `error = -1;`

2013-10-03 Thread Paul Menzel
List-Post: chrony-dev@chrony.tuxfamily.org Date: Thu, 3 Oct 2013 14:37:31 +0200 The Clang static analyzer scan-build from Debian clang version 3.4-1 found the following unneeded assignment. rtc_linux.c:756:5: warning: Value stored to 'error' is never read error = 1;

[chrony-dev] [PATCH] sourcestats.c: Only assign values when needed for `TRACEON` to address warnings

2013-10-03 Thread Paul Menzel
List-Post: chrony-dev@chrony.tuxfamily.org Date: Thu, 3 Oct 2013 14:22:37 +0200 The Clang static analyzer scan-build from Debian clang version 3.4-1 currently issues the following two warnings. /usr/share/clang/scan-build/ccc-analyzer -O2 -g -c sourcestats.c sourcestats.c:625:5:

Re: [chrony-dev] [PATCH] ntp_core.c: Remove useless assignment `prev = inst->local_rx;`

2013-10-03 Thread Miroslav Lichvar
On Thu, Oct 03, 2013 at 02:34:46PM +0200, Paul Menzel wrote: > The Clang static analyzer scan-build found the following unneeded > assignment. > > /usr/share/clang/scan-build/ccc-analyzer -O2 -g -c sources.c > ntp_core.c:1545:3: warning: Value stored to 'prev' is never read >