Re: [chrony-dev] chronyd feature request: aggressive mode

2019-12-11 Thread Miroslav Lichvar
On Wed, Dec 11, 2019 at 03:57:50PM +0700, Gerriet M. Denkmann wrote: > chronyd does a good job of keeping the time in sync without big changes in > the drift (freuquency). > > But there are a few situations, where an “aggressive mode” (i.e. drastically > increasing the frequency) would be more

[chrony-dev] chronyd feature request: aggressive mode

2019-12-11 Thread Gerriet M. Denkmann
chronyd does a good job of keeping the time in sync without big changes in the drift (freuquency). But there are a few situations, where an “aggressive mode” (i.e. drastically increasing the frequency) would be more appropriate: (1) at start (2) when there is a big time-error (ntp-time -

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-11 Thread Christian Ehrhardt
On Wed, Dec 11, 2019 at 5:42 PM Miroslav Lichvar wrote: > On Wed, Dec 11, 2019 at 04:13:23PM +0100, Christian Ehrhardt wrote: > > That means the first switch_interrupts call from RTC_Initialise -> > > RTC_Linux_Initialise -> switch_interrupts has on_off=0 and that doesn't > > trigger the issue

[chrony-dev] [PATCH v2 2/2] rtc: extend check for RTCs that don't support interrupts

2019-12-11 Thread Christian Ehrhardt
Several RTCs would only expose the broken behavior on enabling interrupts. Therefore the check has to probe switch_interrupts(1) as well. Clocks known to expose that behavior include, but are not limited to: PPC64# dmesg | grep -i rtc    [    0.241872] rtc-generic rtc-generic: registered as rtc0

[chrony-dev] [PATCH v2 1/2] test: check if RTC is RTC_UIE_ON capable

2019-12-11 Thread Christian Ehrhardt
The test might run on different platforms. If the platform happens to have a RTC that does exist but unable to have RTC_UIE_ON set the test will fall into an infinite hang. Exampls of bad clocks are: - ppc64el: rtc-generic - arm64: rtc-efi To avoid that check the capability via `hwclock` before

[chrony-dev] [PATCH v2 0/2] fix RTC issues on some platforms

2019-12-11 Thread Christian Ehrhardt
Here an update to my patches on the topic. The changes of Miroslav already helped a lot, thanks! Out of our discussion and debugging here an updated set of patches that would fix behavior with the clocks that I encountered and skip tests to not false-positive flag chrony (while instead the RTC is

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-11 Thread Vincent Blut
On 2019-12-11T16:13+0100, Christian Ehrhardt wrote: On Tue, Dec 10, 2019 at 5:59 PM Miroslav Lichvar wrote: On Tue, Dec 10, 2019 at 04:25:31PM +0100, Christian Ehrhardt wrote: > On Tue, Dec 10, 2019 at 4:19 PM Miroslav Lichvar > > I'm sorry for changing my mind, but I now think this case

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-11 Thread Christian Ehrhardt
On Tue, Dec 10, 2019 at 5:59 PM Miroslav Lichvar wrote: > On Tue, Dec 10, 2019 at 04:25:31PM +0100, Christian Ehrhardt wrote: > > On Tue, Dec 10, 2019 at 4:19 PM Miroslav Lichvar > > > I'm sorry for changing my mind, but I now think this case should be > > > handled gracefully in chronyd and

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-11 Thread Miroslav Lichvar
On Wed, Dec 11, 2019 at 04:13:23PM +0100, Christian Ehrhardt wrote: > That means the first switch_interrupts call from RTC_Initialise -> > RTC_Linux_Initialise -> switch_interrupts has on_off=0 and that doesn't > trigger the issue at initialization phase. > Later on on RTC_TimeInit ->

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-11 Thread Christian Ehrhardt
On Wed, Dec 11, 2019 at 4:24 PM Vincent Blut wrote: > On 2019-12-11T16:13+0100, Christian Ehrhardt wrote: > >On Tue, Dec 10, 2019 at 5:59 PM Miroslav Lichvar > >wrote: > > > >> On Tue, Dec 10, 2019 at 04:25:31PM +0100, Christian Ehrhardt wrote: > >> > On Tue, Dec 10, 2019 at 4:19 PM Miroslav

[chrony-dev] chronyc tab completion, libedit 20191025-3.1 regression

2019-12-11 Thread Lonnie Abelbeck
Hi Devs, Just a quick note, related to chronyc tab completion ... libedit 20191025-3.1 has a regression and does not add a space character after a match ... sounds minor but actually causes problems. libedit 20191211-3.1 fixes the problem. https://thrysoee.dk/editline/ Thanks to Christos