Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-10 Thread Miroslav Lichvar
On Tue, Dec 10, 2019 at 04:25:31PM +0100, Christian Ehrhardt wrote: > On Tue, Dec 10, 2019 at 4:19 PM Miroslav Lichvar > > I'm sorry for changing my mind, but I now think this case should be > > handled gracefully in chronyd and not avoided in the test. According > > to the man page, the -s

[chrony-dev] [GIT] chrony/chrony.git branch master updated. 3.5-89-gf5eb7da

2019-12-10 Thread git
This is an automated email from git. It was generated because a ref change was pushed to the "chrony/chrony.git" repository. The branch, master has been updated via f5eb7daf2087d52e3a55f9c081ff318588e287e8 (commit) via d66b2f2b2423bfbd3de4d69895024dac7eefb306 (commit) via

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-10 Thread Christian Ehrhardt
On Tue, Dec 10, 2019 at 4:19 PM Miroslav Lichvar wrote: > On Tue, Dec 10, 2019 at 04:11:14PM +0100, Christian Ehrhardt wrote: > > On Tue, Dec 10, 2019 at 4:06 PM Vincent Blut > wrote: > > > >+hwclock -r --test | grep -q '^ioctl.*RTC_UIE_ON.*Invalid argument$' > && > > > test_skip "RTC not

Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-10 Thread Miroslav Lichvar
On Tue, Dec 10, 2019 at 04:11:14PM +0100, Christian Ehrhardt wrote: > On Tue, Dec 10, 2019 at 4:06 PM Vincent Blut wrote: > > >+hwclock -r --test | grep -q '^ioctl.*RTC_UIE_ON.*Invalid argument$' && > > test_skip "RTC not RTC_UIE_ON capable" > > > >

[chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-10 Thread Christian Ehrhardt
On Tue, Dec 10, 2019 at 4:06 PM Vincent Blut wrote: > On 2019-12-10T15:52+0100, Christian Ehrhardt wrote: > >The test might run on different platforms. > >If the platform happens to have a RTC that does exist but unable to > >have RTC_UIE_ON set the test will fall into an infinite hang. > > >

[chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-10 Thread Vincent Blut
On 2019-12-10T15:52+0100, Christian Ehrhardt wrote: The test might run on different platforms. If the platform happens to have a RTC that does exist but unable to have RTC_UIE_ON set the test will fall into an infinite hang. Exampls of bad clocks are: - ppc64el: rtc-generic - arm64: rtc-efi To

[chrony-dev] [PATCH] test: check if RTC is RTC_UIE_ON capable

2019-12-10 Thread Christian Ehrhardt
The test might run on different platforms. If the platform happens to have a RTC that does exist but unable to have RTC_UIE_ON set the test will fall into an infinite hang. Exampls of bad clocks are: - ppc64el: rtc-generic - arm64: rtc-efi To avoid that check the capability via `hwclock` before

Re: [chrony-dev] Re: Are there known issues in destructive tests on arm64 or ppc64

2019-12-10 Thread Christian Ehrhardt
On Tue, Dec 10, 2019 at 12:20 PM Miroslav Lichvar wrote: > On Fri, Dec 06, 2019 at 12:35:21PM +0100, Christian Ehrhardt wrote: > > To summarize: > > - RTC init fails > > - SCH_MainLoop then hangs > > Could the second be a consequence of the first? > > Does this make sense to anyone? > > It seems

Re: [chrony-dev] Re: Are there known issues in destructive tests on arm64 or ppc64

2019-12-10 Thread Miroslav Lichvar
On Fri, Dec 06, 2019 at 12:35:21PM +0100, Christian Ehrhardt wrote: > To summarize: > - RTC init fails > - SCH_MainLoop then hangs > Could the second be a consequence of the first? > Does this make sense to anyone? It seems the RTC interrupts cannot be enabled. As Vincent suggests this is

Re: [chrony-dev] rtcsync in chrony 3.5

2019-12-10 Thread Miroslav Lichvar
On Mon, Dec 09, 2019 at 04:11:30PM +0700, Gerriet M. Denkmann wrote: > I have some suspicion that rtcsync does no longer work in 3.5. > > set_sync_status has these lines: > /* update the RTC by applying a step of 0.0 secs */ >apply_step_offset(0.0); >last_rtc_sync = now; >