Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS

2020-10-15 Thread Miroslav Lichvar
On Thu, Oct 15, 2020 at 08:18:23PM +1300, Bryan Christianson wrote: > The latest beta release of macOS 11.0 (Big Sur beta 10) seems to have fixed > the signed/unsigned confusion. The final release of the OS will be sometime > in the next month, so I suggest waiting until then before reverting

Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS

2020-10-15 Thread Bryan Christianson
The latest beta release of macOS 11.0 (Big Sur beta 10) seems to have fixed the signed/unsigned confusion. The final release of the OS will be sometime in the next month, so I suggest waiting until then before reverting the workaround patch. Bryan > On 31/08/2020, at 8:37 PM, Bryan

Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS

2020-08-31 Thread Bryan Christianson
Hi Miroslav > On 31/08/2020, at 8:27 PM, Miroslav Lichvar wrote: > > Hopefully Apple will fix this soon. It's interesting they had a > signed/unsigned bug in both adjtime() and ntp_adjtime(). I submitted a very simple test case to them - it works correctly in 10.15 and fails in 11.0. Whether

Re: [chrony-dev] [PATCH] sys_timex: add workaround for broken ntp_adjtime() on macOS

2020-08-31 Thread Miroslav Lichvar
On Mon, Aug 31, 2020 at 07:56:45PM +1200, Bryan Christianson wrote: > On macOS 11.0 (Big Sur) beta, ntp_adjtime() incorrectly returns timex.freq as > an unsigned number. This patch is a workaround for the bug and should be > removed when Apple fix the problem (assuming they will). Applied.