Re: [Cin] zimg 2.8

2023-06-03 Thread Phyllis Smith via Cin
GIT manual checkin of Andrea's addition and clarifications of ffmpeg.git
and without-thirdparty builds.
Along with GIT source checkin of ffmpeg.git.patch# for ffmpeg 6.0.

On Sat, Jun 3, 2023 at 3:12 AM Andrea paz 
wrote:

> I try to attach a draft on the paragraph on alternative builds, to be
> put in the appendix.
> If it goes well, I would propose to wait until Andrew's patches are
> put into git.
>
> @Phyllis For the draft I used what you reported in previous emails.
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-03 Thread Andrea paz via Cin
I try to attach a draft on the paragraph on alternative builds, to be
put in the appendix.
If it goes well, I would propose to wait until Andrew's patches are
put into git.

@Phyllis For the draft I used what you reported in previous emails.
\section{Experimental Builds}
\label{sec:experimental_builds}
\index{build!experimental}

The main compilation we have seen leads to building \CGG{} with its own 
internal ffmpeg, provided with stability patches and feature patches. Normally 
ffmpeg is updated to version x.1 of each release. The reasons why it is best to 
use thirdparty with their static versions of the libraries and ffmpeg are 
explained in detail in \nameref{Using the very latest Libraries} and in 
\nameref{Unbundled Builds}.

You can still compile \CGG{} with ffmpeg-git to enjoy the latest version. This 
build may lead to feature variation and lower stability.
You have to supply the actual URL location of the ffmpeg git as you can see in 
this example \texttt{bld.sh} script:

\begin{lstlisting}[numbers=none]
#!/bin/bash
./autogen.sh
./configure --with-single-user --with-booby 
--with-git-ffmpeg=https://git.ffmpeg.org/ffmpeg.git
make && make install ) 2>1 | tee log
mv Makefile Makefile.cfg
cp Makefile.devel Makefile
\end{lstlisting}

Since the procedure for obtaining the latest ffmpeg version is not always kept 
up-to-date and the line numbers will always change, you may have to create that 
patch first. Generally those line numbers are only updated by a developer when 
a new stable version with worthwhile features is actually included in the 
\CGG{} build. FFmpeg is constantly changing and many times the git version is 
not as stable as desired.

Finally, it is possible to compile \CGG{} so that it uses ffmpeg which is 
already installed on the system. This build lightens the compile and may 
increase performance in both rendering and timeline. Again there may be 
variations in functionality and less stability.
Getting a build to work in a system environment is not easy. If you have 
already installed libraries which are normally in the thirdparty build, getting 
them to be recognized means you have to install the devel version
so the header files which match the library interfaces exist. If you want to 
build using only the thirdparty libraries installed in your system, just 
include \texttt{-–without-thirdparty} to your configure script. For example:

\begin{lstlisting}[numbers=none]
 ./confgure --with-single-user --disable-static-build --without-thirdparty 
--without-libdpx
\end{lstlisting}

libdpx is just such an example of lost functionality: this build of \CGG{} will 
not be able to use the DPX format.


Developer.tar.gz
Description: application/gzip
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Phyllis Smith via Cin
On Fri, Jun 2, 2023 at 5:54 AM Andrea paz 
wrote:

> @Stefan Thanks for the hint. I had done the copy/paste from
> bld_appimage.sh which indeed reports the error (@Phyllis: better
> correct this error?).
>

OK, next time I boot the desktop, I will correct.  Nice catch! thanks.
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrea paz via Cin
We wait until the patches are in git before writing anything.
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 19:40 Phyllis Smith :

> Not sure about adding it to the website page -- I do not think it should
> be publicized too much because it just leads to problems if not using what
> the defaults are.  For example, some things just do not work right,
> especially in FFmpeg without the patches.
>


Yeah, but some things might works better At The Moment, for example I
wonder if lcms2  support at image input side in ffmpeg6 actually makes any
difference on timeline .

Add *Use at your own risk* h1 sized header before this text? :)



> On Fri, Jun 2, 2023 at 10:34 AM Andrew Randrianasulu <
> randrianas...@gmail.com> wrote:
>
>>
>>
>> пт, 2 июн. 2023 г., 19:30 Phyllis Smith :
>>
>>>
>>> I remember old emails where, with your help, I had managed to compile
> without thirdparty. I can't find that thread anymore; does anyone
> remember what it was? The fact is that I forgot how to do such a
> build.
>


 you can look into "bld" directory - BSDs build work exactly without
 thirdparty (shortened):

 ./configure --with-single-user \
 --disable-static-build --without-thirdparty  --without-libdpx

 May be we should add this to manual .

>>>
>>> I have this staged to add to the Manual GIT.  It will look like this
>>> (but it will mostly be missed in reading anyway):
>>>
>>
>> May be add it to website page about building, too?
>>
>>
>>
>>> 1.3.4 Notes about Building from Git in your Customized Environment

 Getting a build to work in a custom environment is not easy. If you
 have already installed libraries which are normally in the thirdparty
 build, getting them to be recognized means you have to install the devel
 version so the header files which match the library interfaces exist. If you
 want to build using only the thirdparty libraries installed in your system,
 just include "–without-thirdparty" to your configure script. For example:

 ./confgure --with-single-user --disable-static-build
 --without-thirdparty

 Below is the list of thirdparty builds, but this list may have changed
 over ...

>>>
>>>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Phyllis Smith via Cin
Not sure about adding it to the website page -- I do not think it should be
publicized too much because it just leads to problems if not using what the
defaults are.  For example, some things just do not work right, especially
in FFmpeg without the patches.

On Fri, Jun 2, 2023 at 10:34 AM Andrew Randrianasulu <
randrianas...@gmail.com> wrote:

>
>
> пт, 2 июн. 2023 г., 19:30 Phyllis Smith :
>
>>
>> I remember old emails where, with your help, I had managed to compile
 without thirdparty. I can't find that thread anymore; does anyone
 remember what it was? The fact is that I forgot how to do such a
 build.

>>>
>>>
>>> you can look into "bld" directory - BSDs build work exactly without
>>> thirdparty (shortened):
>>>
>>> ./configure --with-single-user \
>>> --disable-static-build --without-thirdparty  --without-libdpx
>>>
>>> May be we should add this to manual .
>>>
>>
>> I have this staged to add to the Manual GIT.  It will look like this (but
>> it will mostly be missed in reading anyway):
>>
>
> May be add it to website page about building, too?
>
>
>
>> 1.3.4 Notes about Building from Git in your Customized Environment
>>>
>>> Getting a build to work in a custom environment is not easy. If you have
>>> already installed libraries which are normally in the thirdparty build,
>>> getting them to be recognized means you have to install the devel version
>>> so the header files which match the library interfaces exist. If you want to
>>> build using only the thirdparty libraries installed in your system, just
>>> include "–without-thirdparty" to your configure script. For example:
>>>
>>> ./confgure --with-single-user --disable-static-build --without-thirdparty
>>>
>>> Below is the list of thirdparty builds, but this list may have changed
>>> over ...
>>>
>>
>>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 19:30 Phyllis Smith :

>
> I remember old emails where, with your help, I had managed to compile
>>> without thirdparty. I can't find that thread anymore; does anyone
>>> remember what it was? The fact is that I forgot how to do such a
>>> build.
>>>
>>
>>
>> you can look into "bld" directory - BSDs build work exactly without
>> thirdparty (shortened):
>>
>> ./configure --with-single-user \
>> --disable-static-build --without-thirdparty  --without-libdpx
>>
>> May be we should add this to manual .
>>
>
> I have this staged to add to the Manual GIT.  It will look like this (but
> it will mostly be missed in reading anyway):
>

May be add it to website page about building, too?



> 1.3.4 Notes about Building from Git in your Customized Environment
>>
>> Getting a build to work in a custom environment is not easy. If you have
>> already installed libraries which are normally in the thirdparty build,
>> getting them to be recognized means you have to install the devel version
>> so the header files which match the library interfaces exist. If you want to
>> build using only the thirdparty libraries installed in your system, just
>> include "–without-thirdparty" to your configure script. For example:
>>
>> ./confgure --with-single-user --disable-static-build --without-thirdparty
>>
>> Below is the list of thirdparty builds, but this list may have changed
>> over ...
>>
>
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Phyllis Smith via Cin
> I remember old emails where, with your help, I had managed to compile
>> without thirdparty. I can't find that thread anymore; does anyone
>> remember what it was? The fact is that I forgot how to do such a
>> build.
>>
>
>
> you can look into "bld" directory - BSDs build work exactly without
> thirdparty (shortened):
>
> ./configure --with-single-user \
> --disable-static-build --without-thirdparty  --without-libdpx
>
> May be we should add this to manual .
>

I have this staged to add to the Manual GIT.  It will look like this (but
it will mostly be missed in reading anyway):

1.3.4 Notes about Building from Git in your Customized Environment
>
> Getting a build to work in a custom environment is not easy. If you have
> already installed libraries which are normally in the thirdparty build,
> getting them to be recognized means you have to install the devel version
> so the header files which match the library interfaces exist. If you want to
> build using only the thirdparty libraries installed in your system, just
> include "–without-thirdparty" to your configure script. For example:
>
> ./confgure --with-single-user --disable-static-build --without-thirdparty
>
> Below is the list of thirdparty builds, but this list may have changed
> over ...
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 16:17 Andrea paz :

> > So, you can manually edit keyframe with desired parameters?
> I tried varying the parameters but without enabling keyframes (autos)
> in the "Preset Edit" window. I don't know if that is what you wanted.
>


Ah, so it works this way too?

I forgot about this possibility, but wanted to test plugin autos (keyframes
themselves work, you can change ffmpeg filter parameters along the
timeline, just changes will be abrupt, not nicely curved)

>
> I append a text file with the data.
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrea paz via Cin
> So, you can manually edit keyframe with desired parameters?
I tried varying the parameters but without enabling keyframes (autos)
in the "Preset Edit" window. I don't know if that is what you wanted.

I append a text file with the data.
$ ffmpeg
ffmpeg version n6.0 Copyright (c) 2000-2023 the FFmpeg developers
  built with gcc 13.1.1 (GCC) 20230429
  configuration: --prefix=/usr --disable-debug --disable-static 
--disable-stripping --enable-amf --enable-avisynth --enable-cuda-llvm 
--enable-lto --enable-fontconfig --enable-gmp --enable-gnutls --enable-gpl 
--enable-ladspa --enable-libaom --enable-libass --enable-libbluray 
--enable-libbs2b --enable-libdav1d --enable-libdrm --enable-libfreetype 
--enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack 
--enable-libjxl --enable-libmfx --enable-libmodplug --enable-libmp3lame 
--enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg 
--enable-libopenmpt --enable-libopus --enable-libpulse --enable-librav1e 
--enable-librsvg --enable-libsoxr --enable-libspeex --enable-libsrt 
--enable-libssh --enable-libsvtav1 --enable-libtheora --enable-libv4l2 
--enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx 
--enable-libwebp --enable-libx264 --enable-libx265 --enable-libxcb 
--enable-libxml2 --enable-libxvid --enable-libzimg --enable-nvdec 
--enable-nvenc --enable-opencl --enable-opengl --enable-shared 
--enable-version3 --enable-vulkan
  libavutil  58.  2.100 / 58.  2.100
  libavcodec 60.  3.100 / 60.  3.100
  libavformat60.  3.100 / 60.  3.100
  libavdevice60.  1.100 / 60.  1.100
  libavfilter 9.  3.100 /  9.  3.100
  libswscale  7.  1.100 /  7.  1.100
  libswresample   4. 10.100 /  4. 10.100
  libpostproc57.  1.100 / 57.  1.100
Hyper fast Audio and Video encoder
usage: ffmpeg [options] [[infile options] -i infile]... {[outfile options] 
outfile}...

Use -h to get full help or, even better, run 'man ffmpeg'



pacman -Qi ffmpeg
Name: ffmpeg
Version : 2:6.0-8
Description : Complete solution to record, convert and stream audio and 
video
Architecture: x86_64
URL : https://ffmpeg.org/
Licenses: GPL3
Groups  : None
Provides: libavcodec.so=60-64  libavdevice.so=60-64  
libavfilter.so=9-64  libavformat.so=60-64  libavutil.so=58-64
  libpostproc.so=57-64  libswresample.so=4-64  
libswscale.so=7-64
Depends On  : alsa-lib  aom  bzip2  fontconfig  fribidi  gmp  gnutls  gsm  
jack  lame  libass.so=9-64  libavc1394
  libbluray.so=2-64  libbs2b.so=0-64  libdav1d.so=6-64  libdrm  
libfreetype.so=6-64  libgl  libiec61883
  libjxl.so=0.8-64  libmfx  libmodplug  libopenmpt.so=0-64  
libpulse  librav1e.so=0-64  libraw1394
  librsvg-2.so=2-64  libsoxr  libssh  libtheora  libva.so=2-64  
libva-drm.so=2-64  libva-x11.so=2-64
  libvdpau  libvidstab.so=1.2-64  libvorbisenc.so=2-64  
libvorbis.so=0-64  libvpx.so=8-64  libwebp  libx11
  libx264.so=164-64  libx265.so=199-64  libxcb  libxext  
libxml2  libxv  libxvidcore.so=4-64  libzimg.so=2-64
  ocl-icd  opencore-amr  openjpeg2  opus  sdl2  speex  srt  
svt-av1  v4l-utils  vmaf  vulkan-icd-loader  xz
  zlib
Optional Deps   : avisynthplus: AviSynthPlus support
  intel-media-sdk: Intel QuickSync support
  ladspa: LADSPA filters
  nvidia-utils: Nvidia NVDEC/NVENC support
Required By : aubio  blender  firefox  kfilemetadata  kpipewire  mpv  
opencv  qt5-webengine  qt6-multimedia-ffmpeg
  qt6-webengine  telegram-desktop
Optional For: alsa-plugins  gegl  krita  libde265  tinycompress  yt-dlp
Conflicts With  : None
Replaces: None
Installed Size  : 37.44 MiB
Packager: Maxime Gauduin 
Build Date  : Fri May 26 20:41:46 2023
Install Date: Sun May 28 08:03:11 2023
Install Reason  : Installed as a dependency for another package
Install Script  : No
Validated By: Signature


pacman -Qi zimg
Name: zimg
Version : 3.0.4-1
Description : Scaling, colorspace conversion, and dithering library
Architecture: x86_64
URL : https://github.com/sekrit-twc/zimg
Licenses: custom:WTFPL
Groups  : None
Provides: libzimg.so=2-64
Depends On  : gcc-libs  glibc
Optional Deps   : None
Required By : ffmpeg  ffmpeg4.4
Optional For: None
Conflicts With  : None
Replaces: None
Installed Size  : 942.99 KiB
Packager: Antonio Rojas 
Build Date  : Sun Jun 12 10:30:37 2022
Install Date: Mon Jun 13 08:02:25 2022
Install Reason  : Installed as a dependency for another package
Install Script  : No
Validated By: Signature
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 15:19 Andrea paz :

> > You tried to set parameters from down (input) to top?
>
> I don't know if I understand what you mean correctly. Anyway, I tried
> putting values (corresponding to bt2020) to the following paramaters,
> one at a time. Here are the results:
>
>
> matrixin --> 9 --> OK
> min  --> 9 --> OK
>
> transferin --> 14 --> OK
> tin--> 14 --> ERROR
>
> primariesin --> 9 --> OK
> pin --> 9 --> ERROR
>


So, you can manually edit keyframe with desired parameters?

Can you  also post your system's ffmpeg banner output and version of zimg
so I can try to ask about this error  on zimg github?

>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrea paz via Cin
> You tried to set parameters from down (input) to top?

I don't know if I understand what you mean correctly. Anyway, I tried
putting values (corresponding to bt2020) to the following paramaters,
one at a time. Here are the results:


matrixin --> 9 --> OK
min  --> 9 --> OK

transferin --> 14 --> OK
tin--> 14 --> ERROR

primariesin --> 9 --> OK
pin --> 9 --> ERROR
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 14:54 Andrea paz :

> @Stefan Thanks for the hint. I had done the copy/paste from
> bld_appimage.sh which indeed reports the error (@Phyllis: better
> correct this error?).
> The compilation starts but stops with an error.
>
> I did a new build with the 2 patches. This time the build happens
> without any problems. The zscale plugin is present, but it keeps
> getting the usual error when I change the color parameters.
>
> PluginFVClient::process_buffer() F_zscale
>   err: Generic error in an external library
>

:(

You tried to set parameters from down (input) to top?

Sorry, it just seems this plugin/underlaying library  behaves badly if you
set only *some* parameters, because there is no way I know to set them all
in one go (and anyway we can interactively change them individually and
watch result realtime )

>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrea paz via Cin
@Stefan Thanks for the hint. I had done the copy/paste from
bld_appimage.sh which indeed reports the error (@Phyllis: better
correct this error?).
The compilation starts but stops with an error.

I did a new build with the 2 patches. This time the build happens
without any problems. The zscale plugin is present, but it keeps
getting the usual error when I change the color parameters.

PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 10:58 Andrea paz :

> Unfortunately, now we start with errors that I don't understand. The
> compilation failed and I attach the cin.log and configure.log.
> Question: shouldn't we use ffmpeg-git?
>

It tend to be API-unstable .. :/

Anyway

pluginfclient.C:665:13: error: ‘avfilter_pad_count’ was not declared in
this scope
  665 | if( avfilter_pad_count(fp->outputs) > 1 ) return 0;

hopefully fixed by my patch (attached)

Phyllis currently testing ffmpeg-6.0 with rebased patches.


in ffmpeg.git we hopefully will see vulkan h264/265 decoding and no
additional breakage!



> The configure I used is as follows:
>
> ./configure --with-single-user --disable-static-build
> --with-config-dir=/home/paz/.bcast6 --without-thirdparty
> --without-libdpx
>
> Taking a hint from "bsd.sh" I also tried the following configure:
>
> $ ./configure --with-single-user --disable-static-build
> --with-config-dir=/home/paz/.bcast6 --without-thirdparty
> --without-libdpx --disable-dav1d --disable-libaom --disable libwebp
> --without-nv
>
> But I get the error:
>
> configure: error: unrecognized option: `--disable'
> Try `./configure --help' for more information
>
> If I change the "disable" to "without" I get:
>
> configure: error: unrecognized option: `--without'
> Try `./configure --help' for more information
>
From 33b366e2f2d5998c202029f4798fbc87aaca1927 Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu 
Date: Wed, 1 Mar 2023 23:24:48 +0300
Subject: [PATCH 2/4] Add 4 non-working plugins in ffmpeg 6.0 to plugin.opts

---
 cinelerra-5.1/ffmpeg/plugin.opts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/cinelerra-5.1/ffmpeg/plugin.opts b/cinelerra-5.1/ffmpeg/plugin.opts
index b567e78f..6fe8 100644
--- a/cinelerra-5.1/ffmpeg/plugin.opts
+++ b/cinelerra-5.1/ffmpeg/plugin.opts
@@ -477,3 +477,8 @@ virtualbass
 #remap_opencl ###Input/output error
 #xfade_opencl ###Input_output error
 #openclsrc ###invalid argument
+; do not work in 6.0
+#corr ###Input/output error
+#ssim360 ###Input/output error
+#a3dscope ###Input/output error
+#showcwt ###Input/output error
\ No newline at end of file
-- 
2.39.2

From 43c1702579e1bf2c39be103b1d373b2dc1faee1d Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu 
Date: Wed, 1 Mar 2023 22:25:17 +0300
Subject: [PATCH 1/4] Fix build in pluginfclient.C with ffmpeg 6.0

---
 cinelerra-5.1/cinelerra/pluginfclient.C | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/cinelerra-5.1/cinelerra/pluginfclient.C b/cinelerra-5.1/cinelerra/pluginfclient.C
index d188eb39..afb88c7a 100644
--- a/cinelerra-5.1/cinelerra/pluginfclient.C
+++ b/cinelerra-5.1/cinelerra/pluginfclient.C
@@ -37,6 +37,8 @@
 #include "vframe.h"
 #include "filexml.h"
 
+#include "libavfilter/version.h"
+
 #ifdef FFMPEG3
 #define av_filter_iterate(p) ((*(const AVFilter**)(p))=avfilter_next(*(const AVFilter **)(p)))
 #endif
@@ -660,13 +662,22 @@ PluginFClient::~PluginFClient()
 }
 
 bool PluginFClient::is_audio(const AVFilter *fp)
+
 {
 	if( !fp->outputs ) return 0;
+#if LIBAVFILTER_VERSION_MINOR > 2
+	if( avfilter_filter_pad_count(fp, 1) > 1 ) return 0;
+#else
 	if( avfilter_pad_count(fp->outputs) > 1 ) return 0;
+#endif
 	if( !avfilter_pad_get_name(fp->outputs, 0) ) return 0;
 	if( avfilter_pad_get_type(fp->outputs, 0) != AVMEDIA_TYPE_AUDIO ) return 0;
 	if( !fp->inputs ) return 1;
+#if LIBAVFILTER_VERSION_MINOR > 2
+	if( avfilter_filter_pad_count(fp, 0) > 1 ) return 0;
+#else
 	if( avfilter_pad_count(fp->inputs) > 1 ) return 0;
+#endif
 	if( !avfilter_pad_get_name(fp->inputs, 0) ) return 0;
 	if( avfilter_pad_get_type(fp->inputs, 0) != AVMEDIA_TYPE_AUDIO ) return 0;
 	return 1;
@@ -674,11 +685,19 @@ bool PluginFClient::is_audio(const AVFilter *fp)
 bool PluginFClient::is_video(const AVFilter *fp)
 {
 	if( !fp->outputs ) return 0;
+#if LIBAVFILTER_VERSION_MINOR > 2
+	if( avfilter_filter_pad_count(fp, 1) > 1 ) return 0;
+#else
 	if( avfilter_pad_count(fp->outputs) > 1 ) return 0;
+#endif
 	if( !avfilter_pad_get_name(fp->outputs, 0) ) return 0;
 	if( avfilter_pad_get_type(fp->outputs, 0) != AVMEDIA_TYPE_VIDEO ) return 0;
 	if( !fp->inputs ) return 1;
+#if LIBAVFILTER_VERSION_MINOR > 2
+	if( avfilter_filter_pad_count(fp, 0) > 1 ) return 0;
+#else
 	if( avfilter_pad_count(fp->inputs) > 1 ) return 0;
+#endif
 	if( !avfilter_pad_get_name(fp->inputs, 0) ) return 0;
 	if( avfilter_pad_get_type(fp->inputs, 0) != AVMEDIA_TYPE_VIDEO ) return 0;
 	return 1;
-- 
2.39.2

-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Stefan de Konink via Cin

On Friday, June 2, 2023 9:58:43 AM CEST, Andrea paz via Cin wrote:


--disable libwebp
But I get the error:

configure: error: unrecognized option: `--disable'
Try `./configure --help' for more information



You are missing the dash between disable and libwebp.

--
Stefan
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-02 Thread Andrea paz via Cin
Unfortunately, now we start with errors that I don't understand. The
compilation failed and I attach the cin.log and configure.log.
Question: shouldn't we use ffmpeg-git?

The configure I used is as follows:

./configure --with-single-user --disable-static-build
--with-config-dir=/home/paz/.bcast6 --without-thirdparty
--without-libdpx

Taking a hint from "bsd.sh" I also tried the following configure:

$ ./configure --with-single-user --disable-static-build
--with-config-dir=/home/paz/.bcast6 --without-thirdparty
--without-libdpx --disable-dav1d --disable-libaom --disable libwebp
--without-nv

But I get the error:

configure: error: unrecognized option: `--disable'
Try `./configure --help' for more information

If I change the "disable" to "without" I get:

configure: error: unrecognized option: `--without'
Try `./configure --help' for more information


cin-log_1.tar.gz
Description: application/gzip
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrew Randrianasulu via Cin
пт, 2 июн. 2023 г., 00:05 Andrea paz :

> I remember old emails where, with your help, I had managed to compile
> without thirdparty. I can't find that thread anymore; does anyone
> remember what it was? The fact is that I forgot how to do such a
> build.
>


you can look into "bld" directory - BSDs build work exactly without
thirdparty (shortened):

./configure --with-single-user \
--disable-static-build --without-thirdparty  --without-libdpx

May be we should add this to manual .






> Another question: should I still use the two "exports" in this build as
> well?
>

No, because build will attempt to link to already-build libav* libraries.
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrea paz via Cin
I remember old emails where, with your help, I had managed to compile
without thirdparty. I can't find that thread anymore; does anyone
remember what it was? The fact is that I forgot how to do such a
build.

Another question: should I still use the two "exports" in this build as well?
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrew Randrianasulu via Cin
On Thu, Jun 1, 2023 at 7:11 PM Andrea paz  wrote:
>
> With "$ taskset --cpu-list 1-10 ./cin" and doing various tests with
> the number of cores to disable, I always get the same error.
> I don't quite understand what you mean by "zscale filter setup
> string". If you mean which filter parameters I have varied then the
> answer is: all the ones involving colors! One after the other or in
> groups the result is always the same error. For example, if I set
> Primaries; Transfer and Matrix to "input" or to "unspecified" there
> are no errors; any other choice of color spaces always leads to the
> same error. All this is with both the X11 and X11-OpenGL driver.


Oh yes, I was only testing in width/height ...!

playing with color range controls give me:

PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library
PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library
PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library
PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library
PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library
terminate called after throwing an instance of 'zimg::error::InternalError'
Аварийный останов

>
> My idea is that CinGG's internal ffmpeg cannot use the libzimg library
> which is external instead. Could a patch be made that enables zimg and
> also builds the library internally?
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrea paz via Cin
With "$ taskset --cpu-list 1-10 ./cin" and doing various tests with
the number of cores to disable, I always get the same error.
I don't quite understand what you mean by "zscale filter setup
string". If you mean which filter parameters I have varied then the
answer is: all the ones involving colors! One after the other or in
groups the result is always the same error. For example, if I set
Primaries; Transfer and Matrix to "input" or to "unspecified" there
are no errors; any other choice of color spaces always leads to the
same error. All this is with both the X11 and X11-OpenGL driver.

My idea is that CinGG's internal ffmpeg cannot use the libzimg library
which is external instead. Could a patch be made that enables zimg and
also builds the library internally?
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrew Randrianasulu via Cin
чт, 1 июн. 2023 г., 14:42 Andrea paz :

> I set rgba-float. The message is only the previous one and there are
> no others. cpuset is not recognized. See the video:
> https://streamable.com/1qzfyl


:( what kind of zscale  filter setup string you used?

>
>
> =

I also named command wrong, try taskset
https://unix.stackexchange.com/questions/531757/how-to-limit-processes-to-all-but-one-cpu-in-linux

sorry!
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrea paz via Cin
I set rgba-float. The message is only the previous one and there are
no others. cpuset is not recognized. See the video:
https://streamable.com/1qzfyl
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrew Randrianasulu via Cin
чт, 1 июн. 2023 г., 11:00 Andrea paz :

> Thanks, with the two "exports" I compliled without any problems.
> No message in console. Among the ffmpeg plugins, "zscale" appeared.
> Applying it to an edit gives no error messages. But whatever changes I
> try to make to any of its parameters I always get the same error:
>
> PluginFVClient::process_buffer() F_zscale
>   err: Generic error in an external library
>



quick googling showed this closed ticket ...

https://trac.ffmpeg.org/ticket/9811

try with less threading (cpuset -c 0-1 cin)  ?

Can you also post full message? Also, be sure to set Format to rgba-float
just in case?


> Any advice on how to make it work? It would be a really nice plugin
> that allows you to control every aspect of a transcode, from size to
> colors.
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-06-01 Thread Andrea paz via Cin
Thanks, with the two "exports" I compliled without any problems.
No message in console. Among the ffmpeg plugins, "zscale" appeared.
Applying it to an edit gives no error messages. But whatever changes I
try to make to any of its parameters I always get the same error:

PluginFVClient::process_buffer() F_zscale
  err: Generic error in an external library

Any advice on how to make it work? It would be a really nice plugin
that allows you to control every aspect of a transcode, from size to
colors.
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrew Randrianasulu via Cin
ср, 31 мая 2023 г., 23:52 Andrew Randrianasulu :

>
>
> ср, 31 мая 2023 г., 23:15 Andrea paz :
>
>> > so, try 'pkg-config --libs zimg' please?
>>
>> $ pkg-config --libs zimg
>> -lzimg
>>
>> Then I tried a new compilation but with the same result:
>>
>
>
> well, do not put it into cingg's config, put it into two export lines
> before! I'll try to make working example ...soon (but may be not today)
>

in terminal:

export EXTRA_LIBS=" -lzimg"
export FFMPEG_EXTRA_CFG="  --enable-libzimg"

then your usual configure / make / make install

build-tested with 2.8 zimg + our 5.1 ffmpeg






>
>
>> configure: WARNING: unrecognized options: --enable-libzimg
>>
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrew Randrianasulu via Cin
ср, 31 мая 2023 г., 23:15 Andrea paz :

> > so, try 'pkg-config --libs zimg' please?
>
> $ pkg-config --libs zimg
> -lzimg
>
> Then I tried a new compilation but with the same result:
>


well, do not put it into cingg's config, put it into two export lines
before! I'll try to make working example ...soon (but may be not today)



> configure: WARNING: unrecognized options: --enable-libzimg
>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrea paz via Cin
> so, try 'pkg-config --libs zimg' please?

$ pkg-config --libs zimg
-lzimg

Then I tried a new compilation but with the same result:

configure: WARNING: unrecognized options: --enable-libzimg
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrew Randrianasulu via Cin
ср, 31 мая 2023 г., 22:31 Andrea paz :

> Giving your command I get:
>
> pkg-config --libs libzimg
> Package libzimg was not found in the pkg-config search path.
> Perhaps you should add the directory containing `libzimg.pc'
> to the PKG_CONFIG_PATH environment variable
> Package 'libzimg', required by 'virtual:world', not found
>
> I think I'm entering the territories unknown to me, so I'm retiring! :-)
>

sorry! I looked into my zimg.pc and found this:



prefix=/usr/local
  exec_prefix=${prefix}
libdir=${exec_prefix}/lib
   includedir=${prefix}/include

Name: zimg
Description: Scaling, colorspace conversion, and dithering library
Version: 3.0.4

# If building a static library against a C++ runtime other than libstdc++,
# define STL_LIBS when running configure.
Libs: -L${libdir} -lzimg



so, try 'pkg-config --libs zimg' please?

>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrea paz via Cin
Giving your command I get:

pkg-config --libs libzimg
Package libzimg was not found in the pkg-config search path.
Perhaps you should add the directory containing `libzimg.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libzimg', required by 'virtual:world', not found

I think I'm entering the territories unknown to me, so I'm retiring! :-)
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrew Randrianasulu via Cin
ср, 31 мая 2023 г., 13:54 Andrea paz :

> I have in the system zimg 3.0.4; installed as a dependency of ffmpeg.
> I tried to enable libzimg when compiling CinGG, but it is not recognized:
>
> configure: WARNING: unrecognized options: --enable-libzimg
>
> Any advice on how I could do that?
>

Just like I tried it in termux:

export FFMPEG_EXTRA_CFG="--disable-debug --target-os=android
--enable-mediacodec --enable-jni  --enable-opencl --disable-doc
--disable-ffprobe --enable-libdav1d"
export EXTRA_LIBS="-ldav1d -lOpenCL  -landroid"

before your configure line

just in your case you should put --enable-libzimg into ffmpeg_extra_cfg and
corresponding lib (does pkg-config --libs libzimg show anything?) to
extra_libs

>
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin


Re: [Cin] zimg 2.8

2023-05-31 Thread Andrea paz via Cin
I have in the system zimg 3.0.4; installed as a dependency of ffmpeg.
I tried to enable libzimg when compiling CinGG, but it is not recognized:

configure: WARNING: unrecognized options: --enable-libzimg

Any advice on how I could do that?
-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin