Re: [Clamav-devel] shared/ouput.c

[Tomasz Kojm]

On Sun, 16 Jan 2005 18:37:16 -0500
Stephen Gran [EMAIL PROTECTED] wrote:

 On Sun, Jan 16, 2005 at 02:09:16PM -0500, Stephen Gran said:
  Hello all,
  
  I have asked for this before, I think, but it would be really nice
  if output from the various clam binaries went to different file
  desriptors, depending on whether they are errors, warnings, or
  informative.  This would more easily filtering of output in things
  like cron jobs and the like.  I believe the attached patch does so.
 
 I think this patch is maybe a little smarter:

Applied in CVS. Sorry for the previous ignorance, the case was marked as
low priority.

Thanks,

-- 
   oo. Tomasz Kojm [EMAIL PROTECTED]
  (\/)\. http://www.ClamAV.net/gpg/tkojm.gpg
 \..._ 0DCA5A08407D5288279DB43454822DC8985A444B
   //\   /\  Wed Jan 26 10:18:21 CET 2005


pgprEqxpmOnkT.pgp
Description: PGP signature
___
http://lists.clamav.net/cgi-bin/mailman/listinfo/clamav-devel

Re: [Clamav-devel] shared/ouput.c

[Stephen Gran]

On Sun, Jan 16, 2005 at 02:09:16PM -0500, Stephen Gran said:
 Hello all,
 
 I have asked for this before, I think, but it would be really nice if
 output from the various clam binaries went to different file desriptors,
 depending on whether they are errors, warnings, or informative.  This
 would more easily filtering of output in things like cron jobs and the
 like.  I believe the attached patch does so.

I think this patch is maybe a little smarter:
-- 
 --
|  Stephen Gran  | fortune: cpu time/usefulness ratio too  |
|  [EMAIL PROTECTED] | high -- core dumped.|
|  http://www.lobefin.net/~steve | |
 --
--- clamav-devel-latest/shared/output.c 2004-10-16 20:48:02.0 -0400
+++ output.c2005-01-16 18:33:13.0 -0500
@@ -240,10 +240,7 @@
return;
 }
 
-if(mprintf_stdout)
-   fd = stdout;
-else
-   fd = stderr;
+fd = stdout;
 
 /* legend:
  * ! - error
@@ -253,11 +250,11 @@
 
 /*
  * ERRORWARNINGSTANDARD
- * normal   yes   yesyes
+ * normal  stderr   stderr stdout
  * 
- * verbose  yes   yesyes
+ * verbose stderr   stderr stdout
  * 
- * quietyes   no no
+ * quiet   stderr no no
  */
 
 
@@ -266,9 +263,13 @@
 va_start(argscpy, str);
 
 if(*str == '!') {
+   if(!mprintf_stdout)
+   fd = stderr;
fprintf(fd, ERROR: );
vfprintf(fd, ++str, args);
 } else if(*str == '@') {
+   if(!mprintf_stdout)
+   fd = stderr;
fprintf(fd, ERROR: );
vfprintf(fd, ++str, args);
 #ifdef NO_SNPRINTF
@@ -279,6 +280,8 @@
logg(ERROR: %s, logbuf);
 } else if(!mprintf_quiet) {
if(*str == '^') {
+   if(!mprintf_stdout)
+   fd = stderr;
fprintf(fd, WARNING: );
vfprintf(fd, ++str, args);
} else if(*str == '*') {


pgpYfYCoziN5z.pgp
Description: PGP signature
___
http://lists.clamav.net/cgi-bin/mailman/listinfo/clamav-devel