[cp-patches] RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Christian Schlichtherle
Hi everyone, the changes from int to long are required as to the ZIP file format specification available online from PKZIP Inc. The specification says that all integers are 4 byte unsigned integers. Java's int type is 4 byte signed, thus the type long is required to hold a ZIP file integer. You

[cp-patches] FYI: getPropertyPrefix() in UI delegates

2005-08-31 Thread David Gilbert
I committed this patch to tidy up the getPropertyPrefix() methods in the UI delegates for the Basic look and feel. Sun's implementation is a little inconsistent here: all the descendants of BasicButtonUI include the full stop ('.') with the prefix, while the descendants of BasicMenuItemUI and

[cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread Mark Wielaard
Hi David, On Wed, 2005-08-31 at 16:14 +, David Gilbert wrote: Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot create

[cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread David Gilbert
Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot create system class loader Exception occured while printing exception

Re: [cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread David Gilbert
Andrew Pinski wrote: On Aug 31, 2005, at 12:14 PM, David Gilbert wrote: Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot

[cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread Mark Wielaard
On Wed, 2005-08-31 at 17:44 +0200, Mark Wielaard wrote: Hmmm, after a clean build and install of both classpath and jamvm I have the same issue. Reverting the patch makes things work again. Embarrassing. Apologies. I am investigating what goes wrong and why I didn't notice this before. It was

[cp-patches] [RFC/docs] Additions and fixes for README and INSTALL

2005-08-31 Thread Robert Schuster
Hi, I updated README and INSTALL. Everyone ok with the changes? 2005-08-31 Robert Schuster [EMAIL PROTECTED] * README: Added MysaifuVM to list of VMs * INSTALL: Added info about Qt4 and ecj. cu Robert Index: README ===

[cp-patches] FYI: MetalBorders

2005-08-31 Thread David Gilbert
I committed this patch which implements the getTextFieldBorder() method in the MetalBorders class: 2005-08-31 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalBorders.java (textFieldBorder): new field, (Flush3DBorder): new class,

Re: [cp-patches] FYI: MetalIconFactory.getRadioButtonMenuItemIcon()

2005-08-31 Thread Tom Tromey
On Tue, 2005-08-30 at 21:35 +, David Gilbert wrote: I committed this patch to add an icon for JRadioButtonMenuItems under the Metal look and feel: +public int getIconWidth() +{ + return 10; +} I notice there are an awful lot of constant integers in the plaf code.

[cp-patches] Patch for PR swing/23204 BasicTableUI

2005-08-31 Thread Anthony Balkissoon
This patch implements the getMinimumSize and getMaximumSize methods in BasicTableUI, essentially fixing bug PR swing/23204 where table columns weren't being automatically resized. I have not yet closed this bug because changes need to be made (most likely in ViewportLayout) to allow

[cp-patches] Patch for PR swing/23037 FileChooser.java

2005-08-31 Thread Anthony Balkissoon
This patch fixes PR swing/23037 where the directory up button in JFileChoosers wasn't stopping at the top of the directory structure, but rather bouncing back to the user's home directory. Patch attached. 2005-08-31 Anthony Balkissoon [EMAIL PROTECTED] PR swing/23037 *

Re: [cp-patches] FYI: MetalIconFactory.getRadioButtonMenuItemIcon()

2005-08-31 Thread David Gilbert
Tom Tromey wrote: On Tue, 2005-08-30 at 21:35 +, David Gilbert wrote: I committed this patch to add an icon for JRadioButtonMenuItems under the Metal look and feel: +public int getIconWidth() +{ + return 10; +} I notice there are an awful lot of

[cp-patches] Patch for PR swing/23036 BasicFileChooserUI

2005-08-31 Thread Anthony Balkissoon
This patch fixes PR swing/23036 where the look-in box for JFileChoosers wasn't displaying the correct parent directories. Patch is attached. 2005-08-31 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicFileChooserUI.java: (boxEntries): Made this method package

[cp-patches] fix heavyweight placement within lightweight container

2005-08-31 Thread Thomas Fitzsimmons
Hi, This patch fixes the placement of heavyweight components in lightweight containers. I have an app that adds a Canvas to a JFrame; the canvas was being drawn with the wrong offsets relative to the frame. I've committed this patch, which fixes the canvas's placement. Tom 2005-08-31 Thomas

Re: [cp-patches] [RFC/docs] Additions and fixes for README and INSTALL

2005-08-31 Thread Mark Wielaard
Hi Robert, On Wed, 2005-08-31 at 18:57 +0200, Robert Schuster wrote: I updated README and INSTALL. Everyone ok with the changes? 2005-08-31 Robert Schuster [EMAIL PROTECTED] * README: Added MysaifuVM to list of VMs * INSTALL: Added info about Qt4 and ecj. Thanks for keeping

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Christian Schlichtherle
Hi everyone, the changes from int to long are required as to the ZIP file format specification available online from PKZIP Inc. The specification says that all integers are 4 byte unsigned integers. Java's int type is 4 byte signed, thus the type long is required to hold a ZIP file integer. You

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Jeroen Frijters
Christian Schlichtherle wrote: the changes from int to long are required as to the ZIP file format specification available online from PKZIP Inc. The specification says that all integers are 4 byte unsigned integers. Java's int type is 4 byte signed, thus the type long is required to hold

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Mark Wielaard
Hi, On Wed, 2005-08-31 at 12:06 +0200, Jeroen Frijters wrote: Christian Schlichtherle wrote: the changes from int to long are required as to the ZIP file format specification available online from PKZIP Inc. The specification says that all integers are 4 byte unsigned integers. Java's

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Jeroen Frijters
Christian Schlichtherle wrote: Unfortunately, we cannot add additional public constructors, but I would suggest adding a system property to control the encoding used by our zip implementation. By default we should be compatible with the JDK, but this would allow applications and/or

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Christian Schlichtherle
Hi everyone, Unfortunately, we cannot add additional public constructors, but I would suggest adding a system property to control the encoding used by our zip implementation. By default we should be compatible with the JDK, but this would allow applications and/or users to override the

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Christian Schlichtherle
Hi everyone, Yes, if someone can make a little testcase where we fail now and show how we are not properly converting the signed/unsigned ints at the moment that would be appreciated. Note that at the moment all public methods take and return longs already, we only store it as int

[Bug classpath/23652] New: scripts/check_jni_methods.sh is not portable

2005-08-31 Thread ebotcazou at gcc dot gnu dot org
It appears that scripts/check_jni_methods.sh requires at least GNU diff and GNU grep to run properly: cd /home/eric/cvs/gcc/libjava/classpath scripts/check_jni_methods.sh diff: illegal option -- 0 usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2 diff [-bitw] [-C number | -U

Re: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Per Bothner
Christian Schlichtherle wrote: More specifically, the size and compressed size field in the ZipEntry class are causing the problems as some comparisons are happening on these. The issue is that once a big integer equal or greater than 2*1024^3 and smaller than 4*1024^3 is stored into a Java int,

[Bug classpath/23653] lib/Makefile is not portable

2005-08-31 Thread mark at klomp dot org
--- Additional Comments From mark at klomp dot org 2005-08-31 14:12 --- Subject: Re: New: lib/Makefile is not portable -path is not a portable option for find. Would changing it to -wholename help? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23653

Re: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Stephen Crawley
Jeroen Frijters wrote: Christian Schlichtherle wrote: For my personal education: What's wrong about adding constructors? It is a violation of the Sun license included with the API specification -- you could argue about whether the license is valid or not, but that's not the point, and

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Mark Wielaard
Hi Christian, On Wed, 2005-08-31 at 14:05 +0200, Christian Schlichtherle wrote: For my personal education: What's wrong about adding constructors? The result would still be backward compatible to the JDK source, so I think this would make up a good solution. This is also what people have often

StatCVS report updated

2005-08-31 Thread David Gilbert
I updated the StatCVS report for GNU Classpath: http://www.object-refinery.com/classpath/statcvs/ Regards, Dave ___ Classpath mailing list Classpath@gnu.org http://lists.gnu.org/mailman/listinfo/classpath

RE: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Sven de Marothy
on Wed, 31 Aug 2005, Christian Schlichtherle wrote: More specifically, the size and compressed size field in the ZipEntry class are causing the problems as some comparisons are happening on these. The issue is that once a big integer equal or greater than 2*1024^3 and smaller than 4*1024^3

Re: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Dalibor Topic
Stephen Crawley wrote: Let us not beat about the bush. It would be bad for everyone (except Microsoft) if Java implementors were allowed to modify the APIs of the Java Class Libraries. If you are a Java(TM) licensee, I think you can modify the APIs through the respective JSRs at the JCP.

[Bug awt/20782] jawt assertion failure

2005-08-31 Thread fitzsim at redhat dot com
--- Additional Comments From fitzsim at redhat dot com 2005-08-31 21:57 --- Fixed in GNU Classpath. Closing. -- What|Removed |Added Status|ASSIGNED

Re: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Dalibor Topic
Mark Wielaard wrote: But even then for a core class library implementation being conservative about extensions is a good thing. If you aren't careful you have to support a new way to use the library for years and then you will have to make really sure that it is worth it both for your users and

Re: Patches to java.util.zip by Christian Schlichtherle

2005-08-31 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 http://www.javaworld.com/jw-10-1997/jw-10-sunsuit.html Interesting article, especially this one: And while Sun can exercise its legal rights over the use of the Java name, it can do little to stop Microsoft from implementing a clean room version of

Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread David Gilbert
Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot create system class loader Exception occured while printing exception

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-08-31 Thread David Gilbert
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: David Gilbert [EMAIL PROTECTED] 05/08/31 15:23:10 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicButtonUI.java

Re: [cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread Andrew Pinski
On Aug 31, 2005, at 12:14 PM, David Gilbert wrote: Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot create system class loader

Re: [cp-patches] Re: [commit-cp] classpath ./ChangeLog java/util/zip/ZipEntry.ja...

2005-08-31 Thread David Gilbert
Andrew Pinski wrote: On Aug 31, 2005, at 12:14 PM, David Gilbert wrote: Could this have caused the problem I'm now seeing with running the Swing demo: $ jamvm -Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel -classpath examples.zip gnu.classpath.examples.swing.Demo Cannot

[commit-cp] classpath ./ChangeLog java/nio/charset/Charset....

2005-08-31 Thread Mark Wielaard
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/08/31 17:01:43 Modified files: . : ChangeLog java/nio/charset: Charset.java Log message: * java/nio/charset/Charset.java

[commit-cp] classpath ./ChangeLog gnu/java/awt/peer/gtk/Gtk...

2005-08-31 Thread Thomas Fitzsimmons
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Thomas Fitzsimmons [EMAIL PROTECTED] 05/08/31 21:18:15 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: GtkComponentPeer.java Log message: 2005-08-31 Thomas

[commit-cp] classpath ChangeLog

2005-08-31 Thread Thomas Fitzsimmons
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Thomas Fitzsimmons [EMAIL PROTECTED] 05/08/31 21:28:49 Modified files: . : ChangeLog Log message: * ChangeLog: Add PR reference. CVSWeb URLs: