Re: GtkComponentPeer realization

2006-03-03 Thread Mark Wielaard
Hi Tom, On Mon, 2006-02-20 at 15:50 -0500, Thomas Fitzsimmons wrote: On Mon, 2006-02-20 at 17:47 +0100, Mark Wielaard wrote: Yes. We do defer creation of the gtk-peer till the actual addNotify() call. But then we also defer the parent/bound-setting if the container is already visible till

Re: GtkComponentPeer realization

2006-03-03 Thread Thomas Fitzsimmons
On Fri, 2006-03-03 at 21:30 +0100, Mark Wielaard wrote: Hi Tom, On Mon, 2006-02-20 at 15:50 -0500, Thomas Fitzsimmons wrote: On Mon, 2006-02-20 at 17:47 +0100, Mark Wielaard wrote: Yes. We do defer creation of the gtk-peer till the actual addNotify() call. But then we also defer the

Re: GtkComponentPeer realization

2006-03-03 Thread Mark Wielaard
On Fri, 2006-03-03 at 16:05 -0500, Thomas Fitzsimmons wrote: Yes, I agree. This patch looks good, and even avoids force-realizing widgets with gtk_widget_realize, while satisfying the AWT's peer-creation criteria. One small request: that you expand Component.addNotify's javadocs to describe

Re: GtkComponentPeer realization

2006-02-20 Thread Roman Kennke
Hi Mark, OK, I see now where the trouble comes from. In GtkComponentPeer constructor we have: // Only set our parent on the GTK side if our parent on the AWT // side is not showing. Otherwise the gtk peer will be shown // before we've had a chance to position and size it

Re: GtkComponentPeer realization

2006-02-20 Thread Mark Wielaard
On Mon, 2006-02-20 at 15:20 +0100, Roman Kennke wrote: I don't see how/if 2) ever happens/should happen after a Container.add(Component). The Container is invalid after an add(). When/Where should validate[Tree]() be called after a new component has been added? This is not performed

Re: GtkComponentPeer realization

2006-02-20 Thread Thomas Fitzsimmons
On Mon, 2006-02-20 at 17:47 +0100, Mark Wielaard wrote: On Mon, 2006-02-20 at 15:20 +0100, Roman Kennke wrote: I don't see how/if 2) ever happens/should happen after a Container.add(Component). The Container is invalid after an add(). When/Where should validate[Tree]() be called after a

Re: GtkComponentPeer realization

2006-02-19 Thread Mark Wielaard
Hi Tom, On Thu, 2006-02-09 at 09:53 -0500, Thomas Fitzsimmons wrote: An unrealized GtkComponentPeer is a GtkWidget that has an uninitialized X window field. In other words, the X server doesn't have a window data structure allocated for it. We used to force-realize every GtkComponentPeer on

Re: GtkComponentPeer realization

2006-02-13 Thread Thomas Fitzsimmons
On Sat, 2006-02-11 at 23:00 +0100, Mark Wielaard wrote: Hi Tom, On Fri, 2006-02-10 at 12:52 -0500, Thomas Fitzsimmons wrote: I am not sure how/where the GtkPanelPeer should have been realized and/or whether this comes from the delayed realization you talked about (I don't actually see

Re: GtkComponentPeer realization

2006-02-10 Thread Thomas Fitzsimmons
On Fri, 2006-02-10 at 00:26 +0100, Mark Wielaard wrote: Hi Tom, On Thu, 2006-02-09 at 09:53 -0500, Thomas Fitzsimmons wrote: On Thu, 2006-02-09 at 13:52 +0100, Mark Wielaard wrote: I like to debug this a bit further, but I couldn't find good documentation on the handling of

GtkComponentPeer realization

2006-02-09 Thread Mark Wielaard
Hi, After a lot of debugging I finally found out why a program I was testing was crashing sometimes. (The hsqldb AWT frontend - try the org.hsqldb.util.DatabaseManager class from the hsqldb.jar as distributed with OpenOffice for example.) A GtkGraphics object is created differently for realized

Re: GtkComponentPeer realization

2006-02-09 Thread Thomas Fitzsimmons
On Thu, 2006-02-09 at 13:52 +0100, Mark Wielaard wrote: Hi, After a lot of debugging I finally found out why a program I was testing was crashing sometimes. (The hsqldb AWT frontend - try the org.hsqldb.util.DatabaseManager class from the hsqldb.jar as distributed with OpenOffice for

Re: GtkComponentPeer realization

2006-02-09 Thread Mark Wielaard
Hi Tom, On Thu, 2006-02-09 at 09:53 -0500, Thomas Fitzsimmons wrote: On Thu, 2006-02-09 at 13:52 +0100, Mark Wielaard wrote: I like to debug this a bit further, but I couldn't find good documentation on the handling of (un)realized GtkComponentPeers. Does anybody have a link or an