Re: bug in java.util.Map

2004-01-21 Thread Matthias Pfisterer
Dalibor Topic wrote: Tom Tromey wrote: "Matthias" == Matthias Pfisterer <[EMAIL PROTECTED]> writes: Matthias> Building with kjc, I get the following errors: Matthias> ../java/beans/PropertyChangeSupport.java:1: error:Unaccessible class Matthias> "java/util/Map/Entry" can not be imported [JLS 7

Re: bug in java.util.Map

2004-01-21 Thread Dalibor Topic
Tom Tromey wrote: "Matthias" == Matthias Pfisterer <[EMAIL PROTECTED]> writes: Matthias> Building with kjc, I get the following errors: Matthias> ../java/beans/PropertyChangeSupport.java:1: error:Unaccessible class Matthias> "java/util/Map/Entry" can not be imported [JLS 7.5.1] If it isn't fixabl

Re: bug in java.util.Map

2004-01-21 Thread Tom Tromey
> "Matthias" == Matthias Pfisterer <[EMAIL PROTECTED]> writes: Matthias> Building with kjc, I get the following errors: Matthias> ../java/beans/PropertyChangeSupport.java:1: error:Unaccessible class Matthias> "java/util/Map/Entry" can not be imported [JLS 7.5.1] If it isn't fixable in the com

Re: bug in java.util.Map

2004-01-21 Thread Matthias Pfisterer
David Holmes wrote: I found a minor bug in java.util.Map: the inner class Entry has to be public. Diff is attached. All interface members are implicitly public. The preferred style is to not explicitly define them as public. Well, I prefer to be explicit. But this goes beyond a matter of taste

Re: bug in java.util.Map

2004-01-20 Thread Eric Blake
[Shoot, I hit send too early.] For that matter, you should delete the static modifier. Inner classes declared in an interface are implicitly 'public static'. Matthias Pfisterer wrote: Hi, I found a minor bug in java.util.Map: the inner class Entry has to be public. Diff i

Re: bug in java.util.Map

2004-01-20 Thread Eric Blake
That is not a bug. Map is an interface, so all inner types are implicitly public. Our coding standard discourages redundant modifiers, so please do not apply this patch. Matthias Pfisterer wrote: Hi, I found a minor bug in java.util.Map: the inner class Entry has to be public. Diff is

RE: bug in java.util.Map

2004-01-20 Thread David Holmes
> I found a minor bug in java.util.Map: the inner class Entry > has to be public. Diff is attached. All interface members are implicitly public. The preferred style is to not explicitly define them as public. David Holmes ___ Classpath mailin

bug in java.util.Map

2004-01-20 Thread Matthias Pfisterer
Hi, I found a minor bug in java.util.Map: the inner class Entry has to be public. Diff is attached. Matthias -- Matthias Pfisterer <mailto:[EMAIL PROTECTED]> Reuchlinstrasse 28 phone ++49-711-62 87 12 D-70176 Stuttgart (in Deutschland 0711-62 87 12) GERMANY Work like you