Re: dacapo xalan

2006-03-03 Thread Mark Wielaard
On Wed, 2006-03-01 at 10:15 -0800, David Daney wrote: Andrew Haley wrote: Mark Wielaard writes: Does the dacapo xalan work for you with the following patch? diff -u -r1.36 ResourceBundle.java --- java/util/ResourceBundle.java 23 Oct 2005 17:04:46 - 1.36

Re: dacapo xalan

2006-03-03 Thread David Daney
Mark Wielaard wrote: On Wed, 2006-03-01 at 10:15 -0800, David Daney wrote: Andrew Haley wrote: Mark Wielaard writes: Does the dacapo xalan work for you with the following patch? diff -u -r1.36 ResourceBundle.java --- java/util/ResourceBundle.java 23 Oct 2005 17:04:46 -

RE: dacapo xalan

2006-03-03 Thread Jeroen Frijters
David Daney wrote: We cannot violate the JLS! A method that throws a checked exception without declaring it is a bug. Rubbish! There are several ways to throw checked exceptions: http://weblogs.java.net/blog/crazybob/archive/2004/09/dont_try_this_a.ht ml Regards, Jeroen

Re: dacapo xalan

2006-03-03 Thread David Daney
Jeroen Frijters wrote: David Daney wrote: We cannot violate the JLS! A method that throws a checked exception without declaring it is a bug. Rubbish! There are several ways to throw checked exceptions: http://weblogs.java.net/blog/crazybob/archive/2004/09/dont_try_this_a.ht ml Rubbish

Re: dacapo xalan

2006-03-03 Thread Tom Tromey
David == David Daney [EMAIL PROTECTED] writes: David The documentation (jdk 1.4.2) of Class.newInstance() says that David InstantiationException is thrown if ... if the instantiation fails David for some other reason. In my book throwing an exception falls under David the catagory of some other

Re: dacapo xalan

2006-03-02 Thread Tom Tromey
David == David Daney [EMAIL PROTECTED] writes: David Well maybe some of those, but why not just catch those documented in David Class.newInstance() and Class.forName()? Namely add LinkageError and David ExceptionInInitializerError. Or maybe Exceptions in general but no David Errors others than

dacapo xalan

2006-03-01 Thread Christian Thalinger
Hi! Yesterday I investigated the dacapo xalan problem. It's about Class.newInstance. The exceptions thrown is: Exception in thread main java.lang.NullPointerException at java.io.InputStreamReader.init (InputStreamReader.java:198) at java.util.Properties.load (Properties.java:198

RE: dacapo xalan

2006-03-01 Thread Jeroen Frijters
Christian Thalinger wrote: Yesterday I investigated the dacapo xalan problem. It's about Class.newInstance. No, it's not. JikesRVM's Class.newInstance() is broken and ours is correct. Sun also lets exceptions (even checked ones) escape from Class.newInstace(). The problem is around

RE: dacapo xalan

2006-03-01 Thread Jeroen Frijters
Jeroen Frijters wrote: Christian Thalinger wrote: Yesterday I investigated the dacapo xalan problem. It's about Class.newInstance. No, it's not. JikesRVM's Class.newInstance() is broken and ours is correct. Sun also lets exceptions (even checked ones) escape from Class.newInstace

Re: dacapo xalan

2006-03-01 Thread Mark Wielaard
, InstantiationException and ClassNotFoundException. The jikes rvm, which is the only classpath based JVM that can run dacapo xalan, has this code for Class.newInstance: // Run the default constructor on the it. try { VM_Reflection.invoke(defaultConstructor, obj, null); } catch (Throwable e

Re: dacapo xalan

2006-03-01 Thread Andrew Haley
IllegalAccessException, InstantiationException and ClassNotFoundException. The jikes rvm, which is the only classpath based JVM that can run dacapo xalan, has this code for Class.newInstance: // Run the default constructor on the it. try { VM_Reflection.invoke

RE: dacapo xalan

2006-03-01 Thread Jeroen Frijters
Mark Wielaard wrote: Does the dacapo xalan work for you with the following patch? diff -u -r1.36 ResourceBundle.java --- java/util/ResourceBundle.java 23 Oct 2005 17:04:46 - 1.36 +++ java/util/ResourceBundle.java 1 Mar 2006 10:59:59 - @@ -476,9 +476,7

Re: dacapo xalan

2006-03-01 Thread Christian Thalinger
On Wed, Mar 01, 2006 at 01:11:23PM +0100, Jeroen Frijters wrote: Catching Throwable is not required (and not what Sun does). I've tested Dacapo with the attached patch and now it works, so I'm going to check it in. Ok, i guess catching exception is the right thing(tm). Thanks for commiting.

Re: dacapo xalan

2006-03-01 Thread David Daney
does only catch IllegalAccessException, InstantiationException and ClassNotFoundException. The jikes rvm, which is the only classpath based JVM that can run dacapo xalan, has this code for Class.newInstance: // Run the default constructor on the it. try