RE: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Jeroen Frijters
Hi Daniel, Your patch broke the Mauve gnu.testlet.java.io.Serializable.readResolve test. If the readResolve method is in the current class and it is private it is no longer found. Regards, Jeroen -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of

[cp-patches] FYI: Serialization Patch: fix support for private readResolve and writeReplace methods

2005-07-08 Thread Jeroen Frijters
Hi again, I applied the attached patch to fix the problem. Regards, Jeroen 2005-07-07 Jeroen Frijters [EMAIL PROTECTED] * java/io/ObjectStreamClass.java (findAccessibleMethod): Added code to make method accessible. -Original Message- From: Jeroen Frijters Sent:

Re: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Daniel Bonniot
Hi Jeroen Frijters, Your patch broke the Mauve gnu.testlet.java.io.Serializable.readResolve test. What VM do you get this failure with? I tried again with jamvm and classpath with my patch (and without yours) and all java.io.Serializable tests pass (0/5 failures). If the readResolve

Re: [cp-patches] Re: Patch: dependency tracking with gcj

2005-07-08 Thread Mark Wielaard
Hi, On Thu, 2005-07-07 at 22:25 +0200, Mark Wielaard wrote: On Wed, 2005-07-06 at 15:59 -0600, Tom Tromey wrote: Tom == Tom Tromey [EMAIL PROTECTED] writes: Tom This patch adds real dependency tracking when compiling with gcj. I am checking this in. This seems to break builddir

RE: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Jeroen Frijters
Daniel Bonniot wrote: Your patch broke the Mauve gnu.testlet.java.io.Serializable.readResolve test. What VM do you get this failure with? I tried again with jamvm and classpath with my patch (and without yours) and all java.io.Serializable tests pass (0/5 failures). I used my own VM

[cp-patches] FYI: fixlet for MetalLookAndFeel

2005-07-08 Thread Roman Kennke
The method getDefaults() in MetalLookAndFeel initializes the defaults table only once, but calls theme.addCustomEntriesToTable() on every invokation. This is not necessary and actually leads to an infinite recursion on an application here. This is fixed. 2005-07-08 Roman Kennke [EMAIL

Re: [cp-patches] [RFA] broken links in hacking.texinfo

2005-07-08 Thread Mark Wielaard
Hi Aaron, On Thu, 2005-07-07 at 17:05 -0400, Aaron Luchko wrote: 2005-07-07 Aaron Luchko [EMAIL PROTECTED] * doc/hacking.texinfo: Fixed broken links to GNU Coding Standards to point to http://www.gnu.org/prep/standards/ Please commit this. Thanks, Mark signature.asc

Re: [cp-patches] PATCH: logfile rotation, native methods

2005-07-08 Thread Mark Wielaard
Hi Casey, On Thu, 2005-07-07 at 23:17 -0700, Casey Marshall wrote: One feature this implementation requires, in order to function properly, are file locks, which to my dismay are still not implemented. On that point, I'd like to ask what the requirements on JNI code are for Classpath,

Re: [cp-patches] Re: Patch: dependency tracking with gcj

2005-07-08 Thread Tom Tromey
Mark == Mark Wielaard [EMAIL PROTECTED] writes: Mark This seems to break builddir != srcdir I don't see how -- that is how I build here. Mark (and make distcheck). Sorry. Tom ___ Classpath-patches mailing list Classpath-patches@gnu.org

RE: [cp-patches] Re: Serialization: readResolve and writeReplaceinparent class

2005-07-08 Thread Jeroen Frijters
Daniel Bonniot wrote: I'm fairly confident that IKVM.NET does the right thing. My guess is that JamVM incorrectly allows calls to private methods. Is this a known missing feature in jamvm? Are there mauve tests to check it? I think that gnu.testlet.java.lang.reflect.Method.invoke is

Re: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Tom Tromey
Daniel Actually, this is a VM concern rather than a class library one, so I'm Daniel not sure where such tests belong. Is there a common VM testsuite at Daniel all? (other things that could be tested: integer and floating point Daniel arithmetics, synchronization, ...) There isn't one, but I

[cp-patches] FYI: Patch closes bug #13556 JFileChooser

2005-07-08 Thread Anthony Balkissoon
Committed tiny patch that closes bug #13556 where JFileChooser threw a null pointer exception when given an argument that was not a valid file. Instead it should default to the home directory. Patch attached. 2005-07-08 Anthony Balkissoon [EMAIL PROTECTED] *

[cp-patches] FYI: Patch for BasicFileChooserUI.java fixes bug #13644

2005-07-08 Thread Anthony Balkissoon
This patch allows directories to be selected in JFileChooser unless the mode is FILES_ONLY. I'm not closing the bug because there are some smaller details I want to investigate (such as updating the filename text box when you select a file/directory). Patch attached. 2005-07-08 Anthony

Re: [cp-patches] [RFA] broken links in hacking.texinfo

2005-07-08 Thread Aaron Luchko
On Fri, 2005-07-08 at 14:03 +0200, Mark Wielaard wrote: Hi Aaron, On Thu, 2005-07-07 at 17:05 -0400, Aaron Luchko wrote: 2005-07-07 Aaron Luchko [EMAIL PROTECTED] * doc/hacking.texinfo: Fixed broken links to GNU Coding Standards to point to

Re: [cp-patches] Re: Serialization: readResolve and writeReplace inparent class

2005-07-08 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. Daniel Bonniot wrote: I used my own VM (IKVM.NET). :-) I'm fairly confident that IKVM.NET does the right thing. My guess is that JamVM incorrectly allows calls to private methods. Is this a known missing feature in jamvm? Are there