[cp-patches] Re: [patch] fix BE image issues

2005-07-25 Thread Andreas Tobler
Andreas Tobler wrote: 2005-07-24 Andreas Tobler <[EMAIL PROTECTED]> * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImage.c (Java_gnu_java_awt_peer_gtk_GtkImage_setPixels): Adjust BE image handling. here an update which removes one count var. Andreas Index: native/jni/gtk-peer/

Re: [cp-patches] [patch] fix memory image source handling in GTK peers

2005-07-25 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 21:56 -0400, Thomas Fitzsimmons wrote: > @@ -372,8 +374,28 @@ > if (x == 0 && y == 0 && width == 0 && height == 0) >return; > > -q().postEvent (new PaintEvent (awtComponent, PaintEvent.UPDATE, > - new Rectangle (x, y, wi

[cp-patches] [patch] fix memory image source handling in GTK peers

2005-07-25 Thread Thomas Fitzsimmons
Hi, This patch does three things: - implements GtkComponentPeer.repaint timed repaints properly - implements GtkComponentPeer.updateCursorImmediately - fixes handling of memory image sources in GtkImageConsumer I committed this to mainline. This patch gets the Cortado applet closer to working o

[cp-patches] [patch] examples swing/Demo.java

2005-07-25 Thread Andreas Tobler
Hi all, this one was bothering me since a longer time. We should exit when one presses the 'Close' on the right bottom of the panel. Is it correct? Andreas 2005-07-25 Andreas Tobler <[EMAIL PROTECTED]> * examples/gnu/classpath/examples/swing/Demo.java: Exit when pressing

[cp-patches] [patch] examples README

2005-07-25 Thread Andreas Tobler
Hi all, a little patchlet for the README in the examples directory. Ok? Andreas 2005-07-25 Andreas Tobler <[EMAIL PROTECTED]> * examples/README: Add GNULookAndFeel.java to the compile command. Index: README === RCS file

[cp-patches] FYI: BasicTableUI TAB, SHIFT-TAB, and SHIFT-ENTER

2005-07-25 Thread Anthony Balkissoon
This patch implements TAB, SHIFT-TAB, and SHIFT-ENTER key actions and merges them with the code for the ENTER action because of the similarities. Note that you won't be able to test the TAB or SHIFT-TAB unless you also apply the Hack.diff patch because JTable currently uses TABs to change focus.

Re: [cp-patches] RFC: New JCL helper functions for RawData handling

2005-07-25 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 19:21 +0200, Guilhem Lavaux wrote: > Ok. Then I will make a set of patches to first use the new common JCL > interface. And then I will rename RawData* to Pointer*. Is it ok ? Yes please. And for extra bonus points you could add a little thing to the Hacker Guide about u

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Mark Wielaard
Hi Jeroen, On Mon, 2005-07-25 at 18:17 +0200, Jeroen Frijters wrote: > Is this an important scenario? I thought you long haired types didn't > like binary distributions ;-) He he. Sure we don't. But if you follow the harmony effort of the cleanly shaved apache types you will have noticed that the

Re: [cp-patches] FYI: Some fixes and optimizations for Container

2005-07-25 Thread Roman Kennke
Hi, -/* AWTUtilities.java -- Common utility methods for AWT and Swing. - Copyright (C) 2005 Free Software Foundation, Inc. +/* Copyright (C) 2004 Free Software Foundation Don't do that. sorry, I simply copied over the file (from our repo). I will take more care in the future. I'll fix t

[cp-patches] Patch: FYI: fix PR classpath/22986

2005-07-25 Thread Tom Tromey
I'm checking this in. FindBugs pointed out that we were using equals() to compare arrays. In this case, this is incorrect, and we want Arrays.equals(). Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> * java/text/CollationKey.java (equals): Use Arrays.equals. PR classpa

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Aaron Luchko
On Mon, 2005-07-25 at 18:20 +0200, Mark Wielaard wrote: > On Mon, 2005-07-25 at 17:55 +0200, Jeroen Frijters wrote: > > > This won't work if you make the VM_USE_CACHE field static final. Then > > > the constant will be compiled into ClassLoader making it impossible to > > > override for the runtime

[cp-patches] rmic error handling

2005-07-25 Thread Archit Shah
Attached is a patch to the cp-tools rmic that centralizes calls to System.exit and makes handling of exceptions and error conditions more uniform. With the patch, rmic (built with libgcj-3.3.3-7 on FC2) passes the mauve rmic tests. -- Archit Shah Index: src/gnu/classpath/tools/rmi/rmic/RMIC

Re: [cp-patches] FYI: Some fixes and optimizations for Container

2005-07-25 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> (getAlignmentX): Despite common belief, this method does _not_ Roman> call the LayoutManagers getAlignmentX in the JDK. So we also Roman> don't. Information like this should be in comments in the code, not in the ChangeLog entry.

Re: [cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Tom Tromey
> "Jeroen" == Jeroen Frijters <[EMAIL PROTECTED]> writes: Jeroen> * java/rmi/server/RMIClassLoader.java Jeroen> (loadClass(String, String)): Use Class.forName() instead of Jeroen> directly calling ClassLoader.loadClass(), to handle array Jeroen> types correctly.

Re: [cp-patches]: Patch: JTree painting

2005-07-25 Thread Lillian Angel
Done it again! heres the correct patch. On Mon, 2005-07-25 at 13:39 -0400, Lillian Angel wrote: > A fix for the case where there are no icons. > > 2005-07-25 Lillian Angel <[EMAIL PROTECTED]> > > * javax/swing/plaf/basic/BasicTreeUI.java > (paint): moved code to paintNode >

[cp-patches] Patch: FYI: Properties fixlet

2005-07-25 Thread Tom Tromey
I'm checking this in. This fixes a bug in Properties.load that was found with FindBugs. Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> * java/util/Properties.java (load): Handle case where backslash appears at EOF when reading the key. PR classpath/22994. Index: ja

[cp-patches]: Patch: JTree painting

2005-07-25 Thread Lillian Angel
A fix for the case where there are no icons. 2005-07-25 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTreeUI.java (paint): moved code to paintNode (getCellBounds): width increased, slightly short before (paintNode): changed to paint node dependi

Re: [cp-patches] RFC: New JCL helper functions for RawData handling

2005-07-25 Thread Chris Burdess
Guilhem Lavaux wrote: Ok. Then I will make a set of patches to first use the new common JCL interface. And then I will rename RawData* to Pointer*. Is it ok ? Absolutely. -- Chris Burdess ___ Classpath-patches mailing list Classpath-patches@gnu.org

Re: [cp-patches] RFC: New JCL helper functions for RawData handling

2005-07-25 Thread Guilhem Lavaux
On Sun, 2005-07-24 at 21:26 +0100, Chris Burdess wrote: > Tom Tromey wrote: > > Guilhem> + rawDataClass = (*env)->FindClass (env, > > "gnu/classpath/RawData64"); > > > >>> At FOSDEM we talked about renaming these ... want to take it on? :-) > > > > Guilhem> Could you be more specific ? A lin

Re: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Archie Cobbs
Jeroen Frijters wrote: Oh, I'm sorry, I think see what you mean. If a VM would take a binary GNU Classpath jar, it wouldn't be able to override the value of the flag. Is this an important scenario? I thought you long haired types didn't like binary distributions ;-) OK now I get it too... I ca

[cp-patches] FYI: RMI Class loader fix

2005-07-25 Thread Jeroen Frijters
Hi, I applied the attached fix. Regards, Jeroen * java/rmi/server/RMIClassLoader.java (loadClass(String, String)): Use Class.forName() instead of directly calling ClassLoader.loadClass(), to handle array types correctly. Index: java/rmi/server/RMIClassLoader.java

[cp-patches] FYI: Container fixlet

2005-07-25 Thread Anthony Balkissoon
This patch fixes a typo in Container.java that was causing an array out of bounds exception with calls to setFocusedTraversalKeys. Patch attached. 2005-07-25 Anthony Balkissoon <[EMAIL PROTECTED]> * java/awt/Container.java: (setFocusTraversalKeys): Instantiate focusTraversalKeys to an array o

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Jeroen Frijters wrote: > Mark Wielaard wrote: > > On Mon, 2005-07-25 at 16:29 +0200, Jeroen Frijters wrote: > > > I committed the attached patch to complete to ability of the VM to > > > bypass the class caching in ClassLoader. > > > > > > 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> > > > > >

Re: [cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 14:52 +0200, Jeroen Frijters wrote: > I'm not an RMI person, but an IKVM user ran into an RMI problem that I > think is caused by a problem in the RMI class loader that the attached > patch should fix. > > Please comment. I assume this is because the code tries to load

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Mark Wielaard
On Mon, 2005-07-25 at 17:55 +0200, Jeroen Frijters wrote: > > This won't work if you make the VM_USE_CACHE field static final. Then > > the constant will be compiled into ClassLoader making it impossible to > > override for the runtime vm-classes later. It has to be a > > static method for that to

RE: [cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Jeroen Frijters
Mark Wielaard wrote: > On Mon, 2005-07-25 at 14:52 +0200, Jeroen Frijters wrote: > > I'm not an RMI person, but an IKVM user ran into an RMI > problem that I > > think is caused by a problem in the RMI class loader that > the attached > > patch should fix. > > > > Please comment. > > I assume t

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Mark Wielaard wrote: > Yes, but unfortunately that doesn't change the byte-code of the > ClassLoader class. static final primitive (and String) field > values are actually inlined into other classes. So you can replace > VMClassLoader all you want with a version the has VM_USE_CACHE set > to anoth

RE: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Mark Wielaard wrote: > On Mon, 2005-07-25 at 16:29 +0200, Jeroen Frijters wrote: > > I committed the attached patch to complete to ability of the VM to > > bypass the class caching in ClassLoader. > > > > 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> > > > > * java/lang/ClassLoader.java

[cp-patches] FYI: JTable selectAll fix

2005-07-25 Thread Anthony Balkissoon
This patch ensures selectAll doesn't affect the lead selection indices for the row or column ListSelectionModel. Since this is fixed, I also replaced some direct code in BasicListUI with a call to selectAll. Also a small touch-up to make the ENTER key press compatible with the JDK. Patch attache

Re: [cp-patches] FYI: Some fixes and optimizations for Container

2005-07-25 Thread Mark Wielaard
Hi Roman, On Mon, 2005-07-25 at 16:20 +0200, Roman Kennke wrote: > -/* AWTUtilities.java -- Common utility methods for AWT and Swing. > - Copyright (C) 2005 Free Software Foundation, Inc. > +/* Copyright (C) 2004 Free Software Foundation Don't do that. > -Free Software Foundation, Inc., 51 F

Re: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Archie Cobbs
Mark Wielaard wrote: I committed the attached patch to complete to ability of the VM to bypass the class caching in ClassLoader. This won't work if you make the VM_USE_CACHE field static final. Then the constant will be compiled into ClassLoader making it impossible to override for the runtime

Re: [cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Mark Wielaard
Hi, On Mon, 2005-07-25 at 16:29 +0200, Jeroen Frijters wrote: > I committed the attached patch to complete to ability of the VM to > bypass the class caching in ClassLoader. > > 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> > > * java/lang/ClassLoader.java > (loadedClasses): Se

[cp-patches] FYI: ClassLoader caching Part 2

2005-07-25 Thread Jeroen Frijters
Hi, I committed the attached patch to complete to ability of the VM to bypass the class caching in ClassLoader. Regards, Jeroen 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ClassLoader.java (loadedClasses): Set based on VMClassLoader.VM_USE_CACHE. (define

[cp-patches] FYI: Some fixes and optimizations for Container

2005-07-25 Thread Roman Kennke
Hi, I checked in some fixes and optimizations that I came upon while merging with Jamaica's AWT. Most importantly the Lightweightdispatcher has been reworked so that it is reentrant, and preferredSize is now working optimized, so that it only recalculates the preferredSize if the container is

Re: [cp-patches] RFC: cleanup in nio native code

2005-07-25 Thread Roman Kennke
Ok, as I was told on IRC, I have committed the attached slightly (only comments) changed patch. 2005-07-25 Roman Kennke <[EMAIL PROTECTED]> * gnu/java/nio/channels/FileChannelImpl.java (static initializer): Init out, err and in here. * native/jni/java-nio/gnu_java_nio

[cp-patches] RFC: RMI Class loader fix

2005-07-25 Thread Jeroen Frijters
Hi, I'm not an RMI person, but an IKVM user ran into an RMI problem that I think is caused by a problem in the RMI class loader that the attached patch should fix. Please comment. Regards, Jeroen * java/rmi/server/RMIClassLoader.java (loadClass(String, String)): Use Class.forNam

[cp-patches] FYI: Update assign faq entry

2005-07-25 Thread Mark Wielaard
Hi, I got some questions about our contribution requirements so I asked FSF-legal for a better explanation of the assignment policy to add to the FAQ explaining that it is a contract with the FSF committing the FSF to distribute your contribution and derived works under free terms and that you can

[cp-patches] RFC: cleanup in nio native code

2005-07-25 Thread Roman Kennke
While merging some nio code I came upon some strange code in gnu_java_nio_channels_FileChannelImpl.c. There is some code that initializes the field in, out and err, which I would think would better fit in the Java code. I propose the following patch to move this init code there. Are there any o

Re: [cp-patches] [generics] Enum#valueOf implementation

2005-07-25 Thread Mark Wielaard
On Mon, 2005-07-25 at 00:33 -0600, Tom Tromey wrote: > > "Ewout" == Ewout Prangsma <[EMAIL PROTECTED]> writes: > > Ewout> Here's the unified diff. Again my question if someone can > Ewout> commit this, or give me CVS access rights. > > It still needs a ChangeLog entry. > Also the code is not

[cp-patches] FYI: java.awt.image.ConvolveOp fix

2005-07-25 Thread David Gilbert
I committed this patch to fix some Mauve failures: 2005-07-25 David Gilbert <[EMAIL PROTECTED]> * java/awt/image/ConvolveOp.java: (getKernel): return a clone of the kernel. Regards, Dave Gilbert Index: java/awt/image/ConvolveOp.java ===

[cp-patches] FYI: Small additional ClassLoader VM extensibility point

2005-07-25 Thread Jeroen Frijters
Hi, I committed the attached patch, that allows a VM implementer to hook Classloader.findLoadedClass. Regards, Jeroen 2005-07-25 Jeroen Frijters <[EMAIL PROTECTED]> * java/lang/ClassLoader.java (findLoadedClass): Call VMClassLoader.findLoadedClass. * vm/reference/java/