Re: [cp-patches] Patch: RFA: QName serialization

2005-09-19 Thread Chris Burdess
Tom Tromey wrote: This updates QName to be Serializable as required by 1.5. As part of this, I changed the qName field to be computed lazily, so that it would work properly with serialization without requiring a readObject method. Any comments? Is this ok? This isn't really my area so I didn'

[cp-patches] fix hang in GtkComponentPeer.isRealized

2005-09-19 Thread Thomas Fitzsimmons
Hi, I committed this patch from David Lichteblau to fix a potential hang in GtkComponentPeer.isRealized. Tom 2005-09-20 Thomas Fitzsimmons <[EMAIL PROTECTED]> PR awt/23951 * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c (isRealized): Leave GDK critical r

[cp-patches] Patch: FYI: AWT accessibility serialization

2005-09-19 Thread Tom Tromey
I'm checking this in. I saw a bunch of AWT accessibility serialization reports in japi, so I went through and fixed them all. There was only one case where a change other than simply adding serialVersionUID was needed. BTW I noticed this in List.java: // FIXME: Need read/writeObject IMO it

Re: [cp-patches] RFC: Use WeakHashMap in java.util.ResourceBundle

2005-09-19 Thread David Daney
Robert Schuster wrote: Hi, Unfortunately I don't think this is the correct solution. In practice I think this patch would not cause caching for very long -- the next GC cycle would notice that there are no other references to the keys in the map, and it would be cleared. One idea would be

Re: [cp-patches] RFC: Use WeakHashMap in java.util.ResourceBundle

2005-09-19 Thread Robert Schuster
Hi, > Unfortunately I don't think this is the correct solution. In practice > I think this patch would not cause caching for very long -- the next > GC cycle would notice that there are no other references to the keys > in the map, and it would be cleared. > One idea would be a map where the ent

Re: [cp-patches] RFC: Use WeakHashMap in java.util.ResourceBundle

2005-09-19 Thread Tom Tromey
> "Robert" == Robert Schuster <[EMAIL PROTECTED]> writes: Robert> 2005-09-19 Robert Schuster <[EMAIL PROTECTED]> Robert> * java/util/ResourceBundle.java: Changed type of bundleCache Robert> to WeakHashMap. Unfortunately I don't think this is the correct solution. In practice I thin

[cp-patches] FYI: javax.swing.filechooser.FileView

2005-09-19 Thread David Gilbert
I committed this patch (reformatting and API docs): 2005-09-19 David Gilbert <[EMAIL PROTECTED]> * javax/swing/filechooser/FileView.java: Reformatted and added API doc comments. Regards, Dave Index: javax/swing/filechooser/FileView.java ===

[cp-patches]: Patch: Tooltip fix and BasicTreeUI fix

2005-09-19 Thread Lillian Angel
2005-09-19 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/ToolTipManager.java: Changed tooltip to be JDialog (no entry in taskbar), instead of JWindow. (actionPerformed): No need to start timer here. (mouseEntered): No need to call showTip here, it is cal

[cp-patches] Patch properly sets RootPane's glassPane layout manager

2005-09-19 Thread Anthony Balkissoon
Submitted this and the Mauve testcase (gnu/testlet/javax/swing/JFrame/glassPaneLayout.java) for this patch. A JRootPane's glassPane should use FlowLayout not BorderLayout by default. Patch is attached. 2005-09-19 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/JRootPane.java:

[cp-patches] Patch for JLayeredPane fixes #23920

2005-09-19 Thread Anthony Balkissoon
JLayeredPane had FlowLayout incorrectly set as its default layout manager. It instead should have been null. I checked in the Mauve testcase (gnu/testlet/javax/swing/JLayeredPane/defaultLayoutManager.java) and am now checking in this fix. This fixes bug 23920. Attached. 2005-09-19 Anthony Bal

Re: [cp-patches] Patch for RootPaneLayout

2005-09-19 Thread Anthony Balkissoon
"RootPaneLayout" should be "RootLayout", sorry, made this mistake in my ChangeLog entry and list email. This is changed in ChangeLog (no ChangeLog entry for this change). --Tony On Mon, 2005-09-19 at 14:18 -0400, Anthony Balkissoon wrote: > RootPane layout was incorrectly sizing the GlassPane, so

Re: [cp-patches] Patch for BasicInternalFrameUI fixes #23966

2005-09-19 Thread Anthony Balkissoon
Made a slight change to this, just a null pointer check before comparison. Patch is attached. 2005-09-19 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicInternalFrameUI.java: (GlassPaneDispatcher.handleEvent): Added check for mouseEventTarget being

[cp-patches] Patch for RootPaneLayout

2005-09-19 Thread Anthony Balkissoon
RootPane layout was incorrectly sizing the GlassPane, so I fixed it and added a comment about how the components (glassPane, layeredPane, contentPane, menuBar) should be sized. Patch is attached. 2005-09-19 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/JRootPane.java: (R

[cp-patches] Patch: RFA: QName serialization

2005-09-19 Thread Tom Tromey
This updates QName to be Serializable as required by 1.5. As part of this, I changed the qName field to be computed lazily, so that it would work properly with serialization without requiring a readObject method. Any comments? Is this ok? This isn't really my area so I didn't want to simply com

[cp-patches] Patch for BasicInternalFrameUI fixes #23966

2005-09-19 Thread Anthony Balkissoon
BasicInternalFrameUI$GlassPaneDispatcher.handleEvent was re-dispatching events to itself causing an infinite loop. This patch fixes the problem. Patch is attached. 2005-09-19 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicInternalFrameUI.java: (GlassPaneD

[cp-patches] [Tom Tromey <[EMAIL PROTECTED]>] Patch: FYI: javax.print serialization fixlet

2005-09-19 Thread Tom Tromey
I sent this to the wrong list. Sorry about that. --- Begin Message --- I'm checking this in. This fixes a small serialization bug noticed by japi. Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> * javax/print/DocFlavor.java (BYTE_ARRAY.serialVersionUID): New field. (

[cp-patches] FYI: BasicArrowButton

2005-09-19 Thread David Gilbert
I committed this minor patch: 2005-09-19 David Gilbert <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicArrowButton.java (paintTriangle): minor correction to highlight on triangle for disabled buttons. Regards, Dave Index: javax/swing/plaf/basic/BasicArrowButton.java

[cp-patches] Patch: FYI: java.text serialization fix

2005-09-19 Thread Tom Tromey
I'm checking this in. This is a small serialization fix in java.text. Tom Index: ChangeLog from Tom Tromey <[EMAIL PROTECTED]> * java/text/DateFormat.java (serialVersionUID): New field. Index: java/text/DateFormat.java =

[cp-patches]: Patch: JTree Accessible*

2005-09-19 Thread Lillian Angel
The accessible inner classes are now implemented. I am still running various tests on it. 2005-19-19 Lillian Angel <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTreeUI.java (selectPath): Changed so DISCONTIGUOUS_TREE_SELECTION is the default. * javax/swing/JT

[cp-patches] Patch: RFA: some javax.xml serialization fixes

2005-09-19 Thread Tom Tromey
I'm checking this in. This fixes some serialization buglets in javax.xml that were pointed out by japi (against 1.5). Normally I would ask for comment on a patch well outside my area like this, but this one seems pretty obvious. For some of these classes, our javadoc says '@since 1.3', but Sun's

[cp-patches] Re: [Fwd: [Jamvm-general] Problem with sockets on JamVM version 1.3.3 and Classpath 0.18]

2005-09-19 Thread Mark Wielaard
Hi, On Sun, 2005-09-18 at 15:43 -0600, Tom Tromey wrote: > I looked through our networking code and a few more places have this > problem: > > * javanet.c: _javanet_shutdownInput, _javanet_shutdownOutput > > * java_net_VMInetAddress.c: Java_java_net_VMInetAddress_getHostByAddr > Java_java_net_

[cp-patches] FYI: TitledBorder fixlet

2005-09-19 Thread Roman Kennke
Hi, the TitledBorder did not draw the border title at the correct offset. This is fixed. 2005-09-19 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/border/TitledBorder.java (paintBorder): Correctly set the Y offset for the border title. (getMeasurements): Determine the c

[cp-patches] RFC: Use WeakHashMap in java.util.ResourceBundle

2005-09-19 Thread Robert Schuster
Hi, I changed cacheBundle to be of type WeakHashMap because I think this would fix the problems mentioned in PR 23952[0]. Apart from that I changed the static type of bundleCache to WeakHashMap to avoid calling methods via the Map interface because I am under the impression that most VMs can work

[cp-patches] FYI: MetalComboBoxUI

2005-09-19 Thread David Gilbert
I committed this patch which implements most of the missing methods in MetalComboBoxUI. A few changes were needed in BasicComboBoxUI, and there are still some issues to fix, but it mostly works (well enough for others to hack on anyway). I'll continue to work on this, as time permits, during t

[cp-patches] FYI: Checkbox and Component - 2nd try

2005-09-19 Thread Robert Schuster
Hi, same patch but this time the right ChangeLog entry: 2005-09-19 Robert Schuster <[EMAIL PROTECTED]> * java/awt/Checkbox.java: (Checkbox): Properly set as selected checkbox in corresponding checkbox group. (paramString): Removed checkbox group information. * java/awt/Compo

[cp-patches] FYI: Checkbox and Component

2005-09-19 Thread Robert Schuster
Hi, I checked this in. The removal of 'group' from paramString() solves an infinite recursion problem when printing the selected checkbox. 2005-09-19 Robert Schuster <[EMAIL PROTECTED]> * java/awt/Checkbox.java: (paramString): Removed checkbox group information. * java/awt/Component