[cp-patches] FYI: java/io/ObjectInputStream.java

2005-10-18 Thread Jeroen Frijters
Hi, I committed the attached patch to fix proxy deserialization (bug 24422). Regards, Jeroen 2005-10-18 Jeroen Frijters [EMAIL PROTECTED] * java/io/ObjectInputStream.java (parseContent): Removed bogus println and fixed bug #24422. Index: java/io/ObjectInputStream.java

[cp-patches] FYI: ScrollPaneLayout fixes

2005-10-18 Thread Roman Kennke
Hi, The following patch solves a small but significant layout problem with JScrollPanes. The layout manager has to respect the insets of the JScrollPane properly. This is checked in. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/ScrollPaneLayout.java

[cp-patches] FYI: Some JViewport fixes

2005-10-18 Thread Roman Kennke
Hi, This fixes some issues with JViewport. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java (setView): Added repaint() call. (revalidate): Removed unnecessary and unspecified method. (reshape): Fire stateChanged if only the size changes.

[cp-patches] FYI: BasicComboBoxUI fixlets

2005-10-18 Thread David Gilbert
I committed this patch to fix a couple of very minor issues in the BasicComboBoxUI class: the button colors are now fetched from the UIDefaults, and the createEditor() method returns an editor that implements UIResource: 2005-10-18 David Gilbert [EMAIL PROTECTED] *

[cp-patches] FYI: AbstractButton fixlet

2005-10-18 Thread Roman Kennke
This prevents setEnabled() from getting active, if the actual value does not change. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/AbstractButton.java Filled empty blocks with comments. (ButtonChangeListener.stateChanged): Moved implementation from

[cp-patches] Patch: JTree scrollPathToVisible fix

2005-10-18 Thread Lillian Angel
Fixes bug #24218 2005-10-18 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTree.java (scrollPathToVisible): Reimplemented to make the path visible if its parent is not expanded. * javax/swing/plaf/basic/BasicTreeUI.java (installDefaults): Initialized

[cp-patches] Patch: BasicTextUI fix

2005-10-18 Thread Lillian Angel
Fixes bug #24338 2005-10-18 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTextUI.java (installDefaults): Set the selected text color for the text component. Index: javax/swing/plaf/basic/BasicTextUI.java

[cp-patches] FYI: BasicComboBoxUI fixlet

2005-10-18 Thread David Gilbert
I commited this patch to fix a failing Mauve test: 2005-10-18 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicComboBoxUI.java (installComponents): only set default editor if the current editor is null or implements UIResource,

[cp-patches] FYI: JComboBox fixes

2005-10-18 Thread David Gilbert
This patch fixes some failing Mauve tests: 2005-10-18 David Gilbert [EMAIL PROTECTED] * javax/swing/JComboBox.java (setModel): update the selectedItemReminder field, (selectedItemChanged): only send ItemEvent.SELECTED event if the new selection is non-null.

Re: [cp-patches] FYI: BasicTreeUI fix

2005-10-18 Thread Lillian Angel
Noticed the expanded and collapsed icon defaults were set to the wrong icons. Fixed this and reworked mousePressed to work with these changes. 2005-10-18 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java: Removed leafIcon field. (BasicTreeUI):

Re: [cp-patches] FYI: BasicScrollBarUI fixlet

2005-10-18 Thread Robert Schuster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Roman, For all Swing hackers: As a general rule, do not put repaint and revalidate calls in event handlers. When a property change must trigger a repaint and/or revalidate, then this should happen in the corresponding setter method. This makes

[cp-patches] Patch: JTable fixlet

2005-10-18 Thread Lillian Angel
After running some apps that work fine with Sun and IBM, I got several NPEs with JTable. 2005-10-18 Lillian Angel [EMAIL PROTECTED] * javax/swing/JTable.java (JTable): Moved code around so all models are set before any other function is called. Prevents all NPEs with

[cp-patches] Patch: GridBagLayout fixlet

2005-10-18 Thread Lillian Angel
Fixed a NullPointerException 2005-10-18 Lillian Angel [EMAIL PROTECTED] * java/awt/GridBagLayout.java (GetLayoutInfo): Added a null check for lastComponent. Prevents NPE. Index: java/awt/GridBagLayout.java

[cp-patches] FYI: filled empty blocks in javax.swing.colorchooser

2005-10-18 Thread Roman Kennke
I filled empty blocks (like method bodies) in javax.swing.colorchoosers with comments either stating that this does nothing or needs to be implemented. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/colorchooser/AbstractColorChooserPanel.java: *

[cp-patches] FYI: javax.swing.filechooser empty blocks

2005-10-18 Thread Roman Kennke
I filled two empty blocks in javax.swing.filechooser. 2005-10-18 Roman Kennke [EMAIL PROTECTED] * javax/swing/filechooser/FileFilter.java: * javax/swing/filechooser/FileView.java: Filled empty blocks with comments. /Roman Index: javax/swing/filechooser/FileFilter.java

Re: [cp-patches] FYI: filled empty blocks in javax.swing.colorchooser

2005-10-18 Thread Robert Schuster
Hi Roman, Index: javax/swing/colorchooser/DefaultSwatchChooserPanel.java === RCS file: /cvsroot/classpath/classpath/javax/swing/colorchooser/DefaultSwatchChooserPanel.java,v retrieving revision 1.5 diff -u -r1.5