Hi Christian,
On Tue, 2005-11-01 at 23:11 +0100, Christian Thalinger wrote:
> While fixing a CACAO problem in gnu.testlet.java.lang.String.StringTest,
> i noticed that we do not check one case:
>
> offset + count < 0
Ugh. Overflow. Took me a little time to realize that. Could you add
(overflow)
Hi,
On Mon, 2005-10-31 at 10:28 +0100, Roman Kennke wrote:
> > I committed this. But should we keep the GNULookAndFeel as default?
>
> I was also thinking about this and my feeling is that we should use the
> MetalLookAndFeel.
I made Metal the default. And added the option to select the LAF you
I'm committing the attached patch which fixes a regression in
object serialization, namely:
+FAIL: gnu.testlet.java.text.DecimalFormatSymbols.serial (number 1)
+FAIL: gnu.testlet.java.text.DecimalFormatSymbols.serial:
uncaught exception: java.lang.NullPointerException
I couldn't work out why th
Hi,
Am 1.11.2005 schrieb "Lillian Angel" <[EMAIL PROTECTED]>:
>2005-11-01 Lillian Angel <[EMAIL PROTECTED]>
>
>* java/awt/Window.java
>(show): If pack is not called before show, the size of the
>window is often set to 0. This is now fixed.
>
I reverted that patch, this
Hi Lillian,
Am Dienstag, den 01.11.2005, 17:18 -0500 schrieb Lillian Angel:
> 2005-11-01 Lillian Angel <[EMAIL PROTECTED]>
>
> * java/awt/Window.java
> (show): If pack is not called before show, the size of the
> window is often set to 0. This is now fixed.
Isn't this t
The MetalScrollPaneUI returned shared instances of itself for all
JScrollPanes. This is of course wrong. This has lead to disfunctional
scrollpanes in the Metal L&F.
2005-11-01 Roman Kennke <[EMAIL PROTECTED]>
* javax/swing/plaf/metal/MetalScrollPaneUI.java
(instance): Removed u
2005-11-01 Lillian Angel <[EMAIL PROTECTED]>
* java/awt/Window.java
(show): If pack is not called before show, the size of the
window is often set to 0. This is now fixed.
Index: java/awt/Window.java
===
RCS
Hi!
While fixing a CACAO problem in gnu.testlet.java.lang.String.StringTest,
i noticed that we do not check one case:
offset + count < 0
Thus we throw a ArrayIndexOutOfBoundsException instead of a
StringIndexOutOfBoundsException. The attached patch adds this checks
and, while everybody is talki
Hi Christian,
On Tue, 2005-11-01 at 21:03 +0100, Christian Thalinger wrote:
> On Tue, 2005-11-01 at 21:00 +0100, Christian Thalinger wrote:
> > On Sun, 2005-10-30 at 12:28 +0100, Mark Wielaard wrote:
> > > position. Opinions? Volunteers? Anyone want to test against other
> > > runtimes? Or another
Hi,
Lillian discovered a little bug in the JPopupMenu. The PopupFactory
always returned a lightweight Popup even when a heavyweight Popup would
be needed (when the Popup bounds don't fit the containing rootpane's
size). This is only a slight programming error, the JPopupMenu must be
packed before
Some apps were getting NPE with JTable because variables were not set
before the call to updateUI which could be overridden. This is fixed
now, although there are some intricacies which may be fixed after the
release, I put a TODO in the code for now.
2005-11-01 Anthony Balkissoon <[EMAIL PROTE
On Tue, 2005-11-01 at 21:00 +0100, Christian Thalinger wrote:
> On Sun, 2005-10-30 at 12:28 +0100, Mark Wielaard wrote:
> > position. Opinions? Volunteers? Anyone want to test against other
> > runtimes? Or another test set?
>
> Hmm, just tested the patch with cacao. It finished in 1.48user with
On Sun, 2005-10-30 at 12:28 +0100, Mark Wielaard wrote:
> position. Opinions? Volunteers? Anyone want to test against other
> runtimes? Or another test set?
Hmm, just tested the patch with cacao. It finished in 1.48user with and
without the patch, so you should benchmark with an interpreter ;-)
This patch fixes another Mauve regression pointed out by Mark.
BasicFileChooserUI should return the FileChooser's getApproveButtonText
as long as it is not null.
2005-11-01 Anthony Balkissoon <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicFileChooserUI.java:
(getApproveButton
On Tue, 2005-11-01 at 18:31 +0100, Mark Wielaard wrote:
> The round up probably comes from join() which uses a similar way to
> wait. And according to the bug pointed to in the comment apparently some
> VMs mishandle a zero ms argument (we also had that bug in the past).
It seems that sun also doe
This patch fixes the following mauve regressions that Mark pointed out:
+FAIL: gnu.testlet.javax.swing.JFileChooser.getApproveButtonText (number
1)
+FAIL: gnu.testlet.javax.swing.JFileChooser.getDialogTitle: uncaught
exception:
java.lang.StackOverflowError
+FAIL: gnu.testlet.javax.swing.JFileChoos
On Tue, 2005-11-01 at 17:47 +0100, Roman Kennke wrote:
> Hi Lillian,
>
> Am Dienstag, den 01.11.2005, 10:37 -0500 schrieb Lillian Angel:
> > Played around with the defaults a bit so BasicMenuItemUI initializes
> > checkIcon. I had to remove the checkIcon default from BasicL&F, so the
> > checkIcon
Hi Christian,
On Tue, 2005-10-25 at 01:10 +0200, Christian Thalinger wrote:
> Just noticed that the default implementation in GNU classpath has
> problems with gnu.testlet.java.lang.Thread.sleep. This patch should fix
> the issue, without breaking anything.
>
> 2005-10-25 Christian Thalinger <[
Hi Lillian,
Am Dienstag, den 01.11.2005, 10:10 -0500 schrieb Lillian Angel:
> > > public class BasicCheckBoxMenuItemUI extends BasicMenuItemUI
> > > {
> > >+
> > >+ /**
> > >+ * Creates a new BasicCheckBoxMenuItemUI object.
> > >+ */
> > >+ public BasicCheckBoxMenuItemUI()
> > >+ {
> > >+
Hi Lillian,
Am Dienstag, den 01.11.2005, 10:37 -0500 schrieb Lillian Angel:
> Played around with the defaults a bit so BasicMenuItemUI initializes
> checkIcon. I had to remove the checkIcon default from BasicL&F, so the
> checkIcon is not drawn all the time.
>
> 2005-11-01 Lillian Angel <[EMAIL
This patch fixes mauve regressions in JTable that Mark mentioned on the
classpath mailing list. The JTable model has to be set before the call
to initializeLocalVars is made. This is fixed.
2005-11-01 Anthony Balkissoon <[EMAIL PROTECTED]>
* javax/swing/JTable.java:
(JTable(Ta
Played around with the defaults a bit so BasicMenuItemUI initializes
checkIcon. I had to remove the checkIcon default from BasicL&F, so the
checkIcon is not drawn all the time.
2005-11-01 Lillian Angel <[EMAIL PROTECTED]>
* javax/swing/plaf/basic/BasicCheckBoxMenuItemUI.java
(Ba
On Tue, 2005-11-01 at 10:10 -0500, Lillian Angel wrote:
> > > public class BasicCheckBoxMenuItemUI extends BasicMenuItemUI
> > > {
> > >+
> > >+ /**
> > >+ * Creates a new BasicCheckBoxMenuItemUI object.
> > >+ */
> > >+ public BasicCheckBoxMenuItemUI()
> > >+ {
> > >+super();
> > >+
> > public class BasicCheckBoxMenuItemUI extends BasicMenuItemUI
> > {
> >+
> >+ /**
> >+ * Creates a new BasicCheckBoxMenuItemUI object.
> >+ */
> >+ public BasicCheckBoxMenuItemUI()
> >+ {
> >+super();
> >+UIDefaults defaults = UIManager.getLookAndFeelDefaults();
> >+checkIc
Hi,
Committed.
Regards,
Jeroen
2005-11-01 Jeroen Frijters <[EMAIL PROTECTED]>
* java/io/ObjectOutputStream.java
(writeObject): Fixed NPE.
Index: java/io/ObjectOutputStream.java
===
RCS file: /cvsroot/classpath/cla
Hi Christian,
On Tue, 2005-11-01 at 11:42 +0100, Christian Thalinger wrote:
> On Fri, 2005-10-21 at 12:01 +0200, Christian Thalinger wrote:
> > On Wed, 2005-10-19 at 14:57 +0200, Christian Thalinger wrote:
> > > On Tue, Oct 18, 2005 at 10:41:11AM -0600, Tom Tromey wrote:
> > > > The updated patch
On Fri, 2005-10-21 at 12:01 +0200, Christian Thalinger wrote:
> On Wed, 2005-10-19 at 14:57 +0200, Christian Thalinger wrote:
> > On Tue, Oct 18, 2005 at 10:41:11AM -0600, Tom Tromey wrote:
> > > The updated patch looks good to me. Write a ChangeLog entry and
> > > email it and the patch to me, I'
27 matches
Mail list logo
