[cp-patches] FYI: JComponent.setPreferredSize()

2005-11-17 Thread David Gilbert
This patch fixes a null pointer exception when I try to launch Findbugs. I've also backed this change up with some new Mauve tests: 2005-11-17 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JComponent.java (setPreferredSize): Check for null argument before making a copy. Re

Re: [cp-patches] FYI: Metal button fixes

2005-11-17 Thread Mark Wielaard
On Wed, 2005-11-16 at 20:37 +, Roman Kennke wrote: > This also introduces a missing method in MetalLookAndFeel. Strange > that nobody noticed that before ;-) > [...] > * javax/swing/plaf/metal/MetalButtonUI.java > (getCurrentTheme): New method. To celebrate I corrected the Chan

Re: [cp-patches] RFC:Modifying example build system.

2005-11-17 Thread Mark Wielaard
Hi Audrius, On Thu, 2005-11-17 at 12:30 +0100, Meskauskas Audrius wrote: > This is the first time I need to modify the build system. Surely I > tested what I did, but somebody with good experience in Classpath > building could briefly look at the patch. > > 2005-11-17 Audrius Meskauskas <[EMA

Re: [cp-patches] Patch: SecurityManager.checkAccess broken

2005-11-17 Thread Mark Wielaard
Hi Gary, On Thu, 2005-11-17 at 16:24 +, Gary Benson wrote: > The two SecurityManager.checkAccess functions are supposed to check > permissions when called on system threads and thread groups, but > neither function identifies them correctly so the checks never occur. > The attached patch fixes

[cp-patches] FYI: JComponent.setMinimumSize()

2005-11-17 Thread David Gilbert
As for my recent patch for setMaximumSize(), this patch fixes a bug that is showing up when I try to launch FindBugs (I've also added Mauve tests to back up the change): 2005-11-17 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JComponent.java (setMinimumSize): Check for null argumen

Re: [cp-patches] XMLJ_64BIT_POINTER now unused?

2005-11-17 Thread Mark Wielaard
Hi Paul, On Thu, 2005-11-17 at 20:57 +, Paul Jenner wrote: > Minor one but it looks like the XMLJ_64BIT_POINTER define in xmlj has > been unused since the RawData patch went in [1]. Attached patch > removes it for cleanliness. > > Tested on 32-bit but not 64-bit (although a quick grep shows t

[cp-patches] FYI: JComponent.setMaximumSize()

2005-11-17 Thread David Gilbert
This patch fixes a bug that is showing up when I try to launch FindBugs (I've also added Mauve tests to back up the change): 2005-11-17 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JComponent.java (setMaximumSize): Check for null argument before making a copy. Regards, Da

[cp-patches] FYI: more text fixes

2005-11-17 Thread Roman Kennke
This adds a default editor kit for JEditorPane and implements 2 previously stubbed methods. So now you can add icons and Components to JTextPanes. If you are lucky, they are even rendered using the freshly implemented ComponentView and IconView. Unfortunately, rendering styled text components is st

[cp-patches] FYI: text fixlets

2005-11-17 Thread Roman Kennke
I removed unneeded methods from 2 text UI classes: 2005-11-17 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/BasicEditorPaneUI.java (create): Removed unneeded method. * javax/swing/BasicTextPaneUI.java (create): Removed unneeded method. /Roman Index: javax/swing

[cp-patches] FYI: Container fix

2005-11-17 Thread Roman Kennke
I fixed some stuff in java.awt.Container. 2005-11-17 Roman Kennke <[EMAIL PROTECTED]> * java/awt/Container.java (Container): Added comment. (remove): Only call removeNotify if removed component is still showing. (paintComponents): Call paint() instead of

[cp-patches] FYI: fixlet for BoxView

2005-11-17 Thread Anthony Balkissoon
BoxView was using CompositeView's modelToView method, but it really should override it and make sure the children are allocated first, otherwise you'll get BadLocationError. This matches what the docs say to do and it eliminates a bunch of AssertionErrors. 2005-11-17 Anthony Balkissoon <[EMAIL

[cp-patches] XMLJ_64BIT_POINTER now unused?

2005-11-17 Thread Paul Jenner
Hi list. Minor one but it looks like the XMLJ_64BIT_POINTER define in xmlj has been unused since the RawData patch went in [1]. Attached patch removes it for cleanliness. Tested on 32-bit but not 64-bit (although a quick grep shows this unused elsewhere in the source tree). 2005-11-17 Paul Jenn

Re: [cp-patches] Patch: Text fix

2005-11-17 Thread Lillian Angel
Patch attached. On Thu, 2005-11-17 at 15:43 -0500, Lillian Angel wrote: > This fixes several assertion error and NPES found. Lots of functions > were not implemented according to the API. This is now fixed to work > like the JDK. > > 2005-11-17 Lillian Angel <[EMAIL PROTECTED]> > > Fix

[cp-patches] Patch: Text fix

2005-11-17 Thread Lillian Angel
This fixes several assertion error and NPES found. Lots of functions were not implemented according to the API. This is now fixed to work like the JDK. 2005-11-17 Lillian Angel <[EMAIL PROTECTED]> Fixes PR classpath/PR24721 * javax/swing/text/BoxView.java (getViewAtPoint

[cp-patches] FYI: Component fixes

2005-11-17 Thread Roman Kennke
Here comes some fixes for java.awt.Component. This removes the forwarding-to-parent in the repaint calls in the case the component is not showing. This is not needed and actually causes a bug in an application we have here, that overrides repaint() in an unusual way. The reasoning behind the old im

[cp-patches] FYI: javax.swing.text stuff

2005-11-17 Thread Roman Kennke
I hacked a little in javax.swing.text and filled in some missing stuff. I implemented the previously stubbed classes IconView and ComponentView (so it should now be theoretically possible to embed icons and Components into text views). Also I fixed some minor bugs and added most of the missing meth

Re: [cp-patches] FYI: fixlet for BasicEditorPaneUI

2005-11-17 Thread Roman Kennke
Hi Tony, Am Donnerstag, den 17.11.2005, 14:07 -0500 schrieb Anthony Balkissoon: > This accompanies the Mauve test > gnu.testlet.javax.swing.JEditorPane.ViewType. JEditorPane uses a > WrappedPlainView, not a PlainView. I disagree a bit. The changed method should simply not be there. Instead, the

[cp-patches] FYI: fixlet for BasicEditorPaneUI

2005-11-17 Thread Anthony Balkissoon
This accompanies the Mauve test gnu.testlet.javax.swing.JEditorPane.ViewType. JEditorPane uses a WrappedPlainView, not a PlainView. 2005-11-17 Anthony Balkissoon <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicEditorPaneUI.java: (create): Create new WrappedPlainView instance

Re: [cp-patches] RFC: GdkGraphics2D Assertion error fix

2005-11-17 Thread Thomas Fitzsimmons
On Thu, 2005-11-17 at 10:02 -0500, Lillian Angel wrote: > Norman (the person who filed these bugs), is not sure my patch is 100% > correct. Can someone please look it over and let me know? I did look at it when you committed it -- it simply avoids the assertion failures by not running the method b

[cp-patches] FYI: gnu.java.net.protocol.jar Connection patch from libgcj

2005-11-17 Thread Mark Wielaard
Hi, This imports a small change from libgcj. It brings us a little closer to merging these classes. But not that much because we actually need a slightly different implementation that initializes the DateFormat lazily because of bootstrap concerns (DateFormat uses regex, regex uses ResourceBundles

[cp-patches] Patch: SecurityManager.checkAccess broken

2005-11-17 Thread Gary Benson
Hi all, The two SecurityManager.checkAccess functions are supposed to check permissions when called on system threads and thread groups, but neither function identifies them correctly so the checks never occur. The attached patch fixes. Cheers, Gary Index: ChangeLog ==

[cp-patches] FYI: URLClassLoader reindent

2005-11-17 Thread Mark Wielaard
Hi, This just reindents URLClassLoader to match the libgcj version a bit more. Will make merging easier. 2005-11-17 Mark Wielaard <[EMAIL PROTECTED]> * java/net/URLClassLoader.java: Reindented. No code changes. Committed, Mark Index: java/net/URLClassLoader.java

Re: [cp-patches] RFC: GdkGraphics2D Assertion error fix

2005-11-17 Thread Lillian Angel
Norman (the person who filed these bugs), is not sure my patch is 100% correct. Can someone please look it over and let me know? Thanks! Lillian On Wed, 2005-11-16 at 15:58 -0500, Lillian Angel wrote: > Fixes Bugs PR23557 and PR24099 > Just added a check to avoid the assertion error. > > 2005-1

[cp-patches] FYI: paramString() fixlets

2005-11-17 Thread Roman Kennke
Most paramString() methods in Swing are pretty meaningless and only return the name of the component class, like 'JPanel'. This is bad for debugging and so I changed two of these paramStrings to return the super.paramString(), which already has all the information that I needed for debugging. Theor

[cp-patches] FYI: BasicButtonUI fixlet

2005-11-17 Thread Roman Kennke
I removed some code from the BasicButtonUI that I added to MetalButtonUI yesterday. 2005-11-17 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicButtonUI.java (installDefaults): Don't handle the Button.rollover property here, this is Metal specific and is ha

[cp-patches] FYI: JList API comment

2005-11-17 Thread Roman Kennke
I clarified a comment in JList. 2005-11-17 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JList.java (locationToIndex): Clarified API comment. /Roman Index: javax/swing/JList.java === RCS file: /cvsroot/classpath/c

[cp-patches] FYI: javax.swing.tree cleanup

2005-11-17 Thread Roman Kennke
Hi, I found some more occurances of this UIManager.getLookAndFeelDefaults().getXXX() bug in javax.swing.tree and replaced it with UIManager.getXXX(). 2005-11-17 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/tree/DefaultTreeCellEditor.java (DefaultTreeCellEditor): Replaced

[cp-patches] RFC:Modifying example build system.

2005-11-17 Thread Meskauskas Audrius
This patch makes the system to compile, zip and install the CORBA examples as well. The CORBA examples were not installed because they were placed in the more nested folders that expected by the build script. The patch should fix the PR 24911. The patch fixes problem in a primitive way, by add

Re: [cp-patches] Patch: java.io.FilePermission.implies checks reversed

2005-11-17 Thread Gary Benson
Mark Wielaard wrote: > On Wed, 2005-11-16 at 15:10 +, Gary Benson wrote: > > 2005-11-16 Gary Benson <[EMAIL PROTECTED]> > > > >* java/io/FilePermission.java (implies): Correct the sense > >in which action checks are applied. > > And you created mauve tests for this. Very nic

[cp-patches] FYI: URL "unquoting" patch from libgcj

2005-11-17 Thread Mark Wielaard
Hi, To make opening files and jars from URLs with funny characters possible Andrew wrote the following for libgcj. This was needed to load some files from jonas. 2005-11-17 Andrew Haley <[EMAIL PROTECTED]> * gnu/java/net/protocol/file/Connection.java (unquote): New method. (connect):

[cp-patches] FYI: Added not to CORBA examples readme.

2005-11-17 Thread Meskauskas Audrius
The note explains that there is no need to build the whole Classpath system just to build the examples. 2005-11-17 Audrius Meskauskas <[EMAIL PROTECTED]> * examples/gnu/classpath/examples/CORBA/swing/README.html: Added note about the build. Index: examples/gnu/classpath/examples/CORBA/swing/