Re: [cp-patches] Re: RFC: Don't unnecessary double queue GtkComponentPeer.repaint() events

2006-02-13 Thread Mark Wielaard
Hi Lillian, On Sun, 2006-02-12 at 21:00 -0500, Lillian Angel wrote: This is so awesome! I was working on fixing this same bug. Thanks! Good to know this was confusing to others too. For your information, I am still trying to figure out how the Panel realization/getGraphics() should work (any

Re: [cp-patches] RFC: Datatypes library

2006-02-13 Thread Mark Wielaard
Hi Chris, Sorry for moving so slow on this. I am a bit over-committed lately and clearly this is not a subject I am that knowledgeable about, so it takes some time to digest. On Tue, 2006-02-07 at 12:11 +, Chris Burdess wrote: So, does anybody else have any comments? Otherwise I think

[cp-patches] FYI: AsyncBoxView

2006-02-13 Thread Roman Kennke
I implemented the javax.swing.text.AsyncBoxView. This is really a piece of code that actually works better than with the latest JDK. JDK1.5.0_06 seems to have a bug which triggers an NPE with this class. I would guess that since that view is not used at all in one of the standard text components,

[cp-patches] FYI: MetalBorders.java - minor fixes

2006-02-13 Thread David Gilbert
This patch fixes some Mauve failures in the MetalBorders class: 2006-02-13 David Gilbert [EMAIL PROTECTED] * javax/swing/plaf/metal/MetalBorders.java (ButtonBorder.getBorderInsets(Component)): Return insets directly, (ButtonBorder.getBorderInsets(Component, Insets)):

Re: [cp-patches] Re: RFC: Don't unnecessary double queue GtkComponentPeer.repaint() events

2006-02-13 Thread Lillian Angel
Thanks! Good to know this was confusing to others too. For your information, I am still trying to figure out how the Panel realization/getGraphics() should work (any help with that appreciated since I think I just don't really get it). And I am working on fixing a crash with adding Menus to

[cp-patches] FYI: AbstractDocument locking fix

2006-02-13 Thread Roman Kennke
In AbstractDocument we must not attempt to release a read lock if the current thread also holds a write lock. That is because a thread the holds a write lock is ignored in a readLock() request. Decrementing the readLocks counter on readUnlock for such a thread would result in an exception later.

[cp-patches] FYI: View fix

2006-02-13 Thread Roman Kennke
View.setParent() must message all the child views with setParent(null) when it is called with a null argument. This gives the child views a chance to clean up before they get disconnected from the View hierarchy. This behaviour is part of the specification of this method. 2006-02-13 Roman Kennke

[cp-patches] Patch: Component, GtkPanelPeer, GtkWindowPeer

2006-02-13 Thread Lillian Angel
Small fixes. The repaint functions in Component were slightly inefficient, I fixed this. 2006-02-13 Lillian Angel [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GtkPanelPeer.java (handleEvent): Made more efficent by handling paint event and setting the clip for the

Re: [cp-patches] Patch: Component, GtkPanelPeer, GtkWindowPeer

2006-02-13 Thread Roman Kennke
Hi Lillian, Am Montag, den 13.02.2006, 09:34 -0500 schrieb Lillian Angel: Small fixes. The repaint functions in Component were slightly inefficient, I fixed this. Actually these repaint calls where a bit more efficient since they avoid unnecessary method calls. However, I would like you to

Re: [cp-patches] Patch: Component, GtkPanelPeer, GtkWindowPeer

2006-02-13 Thread Lillian Angel
On Mon, 2006-02-13 at 15:48 +0100, Roman Kennke wrote: Hi Lillian, Am Montag, den 13.02.2006, 09:34 -0500 schrieb Lillian Angel: Small fixes. The repaint functions in Component were slightly inefficient, I fixed this. Actually these repaint calls where a bit more efficient since

[cp-patches] RFC: ZipFile optimizations

2006-02-13 Thread Jeroen Frijters
Hi, I noticed that ZipFile currently doesn't use any buffering when reading the zip file directory, so I would like to propose the attached patch to fix this. For me this significantly increases performance of reading the zip directory. In addition to the buffering tweaks, this patch also fixes

Re: [cp-patches] Patch: Component, GtkPanelPeer, GtkWindowPeer

2006-02-13 Thread Roman Kennke
Hi Lillian, Am Montag, den 13.02.2006, 09:57 -0500 schrieb Lillian Angel: On Mon, 2006-02-13 at 15:48 +0100, Roman Kennke wrote: Hi Lillian, Am Montag, den 13.02.2006, 09:34 -0500 schrieb Lillian Angel: Small fixes. The repaint functions in Component were slightly inefficient, I

Re: [cp-patches] FYI: Component, GtkPanelPeer, GtkWindowPeer

2006-02-13 Thread Lillian Angel
Hi Roman, unless you want to revert it again ;-) I'll go and find the application that had a problem with that and reinvestigate. Sorry for unnecessarily bugging you. Done. 2006-02-13 Lillian Angel [EMAIL PROTECTED] * java/awt/Component.java (repaint): No need to call

[cp-patches] RFC: gtk+ awt peers (menu) font cleanup

2006-02-13 Thread Mark Wielaard
Hi, To better understand the gtk+ peers I documented GtkGenericPeer a little to make it more clear what should be overridden and why. I also cleaned up the setting of fonts of the Menu peers so they look better even when the user has set a custom (font) theme. While documenting this change I also

Re: [cp-patches] RFC: Introduction of VMMath

2006-02-13 Thread Andrew John Hughes
On Mon, 2006-02-06 at 21:58 +, Andrew John Hughes wrote: I'd welcome any comments on the attached patch, which separates the Math native methods into a separate class, VMMath, so that they can optionally be replaced by the VM. This fixes PR22198. I also have code for most of the new

[cp-patches] FYI: UnicastRemoteObject fix

2006-02-13 Thread Roman Kennke
Here comes a fix for UnicastRemoteObject.exportObject(Remote). This method used to do strange things, including a cast from the argument to RemoteObject, which my application here did not like (because it was not an instance of RemoteObject that was passed as argument). It occured to me that the

Re: [cp-patches] FYI: ElementBuffer.clone

2006-02-13 Thread Anthony Balkissoon
On Fri, 2006-02-10 at 15:10 +, Roman Kennke wrote: I added the missing ElementBuffer.clone() method. 2006-02-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java (ElementBuffer.clone): New method. I don't understand ... I implemented this

[cp-patches] FYI: UnicastRemoteObject reformatted

2006-02-13 Thread Roman Kennke
While I'm at it, this fixes the strange formatting in UnicastRemoteObject. 2006-02-13 Roman Kennke [EMAIL PROTECTED] * java/rmi/server/UnicastRemoteObject.java: Reformatted. /Roman Index: java/rmi/server/UnicastRemoteObject.java

Re: [cp-patches] FYI: ElementBuffer.clone

2006-02-13 Thread Roman Kennke
Hi Tony, Am 13.2.2006 schrieb Anthony Balkissoon [EMAIL PROTECTED]: On Fri, 2006-02-10 at 15:10 +, Roman Kennke wrote: I added the missing ElementBuffer.clone() method. 2006-02-10 Roman Kennke [EMAIL PROTECTED] * javax/swing/text/DefaultStyledDocument.java

[cp-patches] Patch: BorderLayout fix

2006-02-13 Thread Lillian Angel
Some of the problems I have had with Panels stemmed from BorderLayout. Many things were not being painted because the size was set incorrectly. This is now fixed. 2006-02-13 Lillian Angel [EMAIL PROTECTED] * java/awt/BorderLayout.java (layoutContainer): Rewrote part of this

[cp-patches] FYI: Formatted some files in java.awt.print

2006-02-13 Thread Wolfgang Baer
Hi, I formatted the files in java.awt.print which didn't follow our coding style. 2006-02-13 Wolfgang Baer [EMAIL PROTECTED] * java/awt/print/PrinterGraphics.java: Reformatted. * java/awt/print/Paper.java: Likewise. * java/awt/print/PageFormat.java: Likewise. *

[cp-patches] Patch: FYI: another .cvsignore update

2006-02-13 Thread Tom Tromey
I'm checking this in. I'm not sure how I missed this earlier... this adds another .cvsignore entry in the tools directory. Tom 2006-02-13 Tom Tromey [EMAIL PROTECTED] * tools/.cvsignore: Added Makefile. Index: tools/.cvsignore

[cp-patches] FYI: New file for javax.print

2006-02-13 Thread Wolfgang Baer
Hi, changelog says all. 2006-02-13 Wolfgang Baer [EMAIL PROTECTED] * javax/print/StreamPrintServiceFactory.java: New file. Wolfgang /* StreamPrintServiceFactory.java -- Copyright (C) 2006 Free Software Foundation, Inc. This file is part of GNU Classpath. GNU Classpath is free

[cp-patches] bootstrap, System.loadLibrary() and Math

2006-02-13 Thread Mark Wielaard
Hi, Andrews latest patch showed an interesting bootstrap related regression in some cases. Simple showcase: public class TP { public static void main(String[] args) { System.out.println(java.util.TimeZone.getDefault()); } } The problem is that some runtimes (like cacao and jamvm)

Re: [cp-patches] RFC: Introduction of VMMath

2006-02-13 Thread Mark Wielaard
Hi Andrew, On Mon, 2006-02-13 at 16:13 +, Andrew John Hughes wrote: On Mon, 2006-02-06 at 21:58 +, Andrew John Hughes wrote: I'd welcome any comments on the attached patch, which separates the Math native methods into a separate class, VMMath, so that they can optionally be

[cp-patches] Patch: FYI: update eclipse build

2006-02-13 Thread Tom Tromey
I'm checking this in. This updates the eclipse build infrastructure for the recent relaxng checkin. Tom 2006-02-13 Tom Tromey [EMAIL PROTECTED] * .classpath: Updated for external/relaxngDatatype. Index: .classpath ===

Re: [cp-patches] FYI: Remove freetype2 configure checks

2006-02-13 Thread Christian Thalinger
On Mon, 2005-11-07 at 14:31 +0100, Mark Wielaard wrote: Hi, As discussed on the main list the checks for freetype2 are not necessary and might break on (really) old gtk+ installations. This patch removes them. 2005-11-07 Mark Wielaard [EMAIL PROTECTED] * configure.ac: Don't

Re: [cp-patches] FYI: Remove freetype2 configure checks

2006-02-13 Thread Christian Thalinger
On Mon, 2006-02-13 at 21:40 +0100, Christian Thalinger wrote: Haven't recompiled the classpath for a long time on darwin, but this check is really necessary for darwin. What was the exact reason to remove this? As Mark suggested on irc, here is the linking error message: ld:

[cp-patches] Re: bootstrap, System.loadLibrary() and Math

2006-02-13 Thread Stuart Ballard
Mark Wielaard mark at klomp.org writes: The problem is that some runtimes (like cacao and jamvm) dynamically load the javalang reference library through System.loadLibrary(). But we were relying on Math to do this since obviously it cannot be done in (VM)System/Runtime directly while those are

Re: [cp-patches] Patch: request for approval of serialization related fixes

2006-02-13 Thread Olivier Jolly
The first constructor of the first concrete non serializable super class was selected instead of the first non serializable super class, either concrete or abstract. It is reported in bugzilla as bug 14144 ( http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14144 ) Strange. I cannot see why we

[cp-patches] FYI: JRootPane fixlet

2006-02-13 Thread Roman Kennke
The JRootPane in Sun's implementation is opaque, so should we do. This allows for some nice painting optimization (if the root pane isn't opaque, the painting goes up to the toplevel container, thus jumping out of Swing and going through the inefficient AWT painting.). 2006-02-13 Roman Kennke

[cp-patches] FYI: Real double buffering for Swing

2006-02-13 Thread Roman Kennke
I implemented real double buffering for Swing. What does that mean? Up until now implemented double buffering like this: When painting for a component starts, it fetches an offscreen image from the RepaintManager, paints the component to (0,0) and when this is done, the painted area is copied onto

[cp-patches] Patch: FYI: minor javadoc fixes

2006-02-13 Thread Tom Tromey
I'm checking this in. This fixes a couple javadoc warnings in java.lang.reflect. Tom 2006-02-13 Tom Tromey [EMAIL PROTECTED] * vm/reference/java/lang/reflect/Method.java: Javadoc fix. * vm/reference/java/lang/reflect/Constructor.java: Javadoc fix. Index:

Re: [cp-patches] bootstrap, System.loadLibrary() and Math

2006-02-13 Thread Tom Tromey
Mark == Mark Wielaard [EMAIL PROTECTED] writes: Mark For now to get things working I just reintroduced the loadLibrary() call Mark in the Math static initializer. This should work as before the Mark Math/VMMath split even though it is a little ugly. I'm glad you fixed this immediately; it was

Re: [cp-patches] Patch: BorderLayout fix

2006-02-13 Thread Roman Kennke
Hi Lillian, Am Montag, den 13.02.2006, 12:30 -0500 schrieb Lillian Angel: Some of the problems I have had with Panels stemmed from BorderLayout. Many things were not being painted because the size was set incorrectly. Is it possible to add Mauve tests for your changes? LayoutManagers are