RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
Casey Marshall wrote: > Really? That seems like worse behavior than just giving up when > trying to create the factory. Just delaying exceptions like that > seems like it will just hide bugs, instead of forcing you to deal > with them up front. Well, given that this method is currently used

[cp-patches] FYI: Fix AttributeList to inherit from ArrayList

2006-12-11 Thread Andrew John Hughes
This fixes a few JAPI errors by giving AttributeList a type parameter for its superclass. Changelog: 2006-12-12 Andrew John Hughes <[EMAIL PROTECTED]> * javax/management/AttributeList.java: Extend ArrayList. -- Andrew :-) Escape the Java Trap with GNU Classpath! http://www.g

[cp-patches] FYI: Fix PR30154

2006-12-11 Thread Andrew John Hughes
This patch fixes bug 30154. Changelog: 2006-12-12 Andrew John Hughes <[EMAIL PROTECTED]> PR classpath/30154: * javax/management/MBeanServer.java: (createMBeanServer(String)): Check for a null builder. -- Andrew :-) Escape the Java Trap with GNU Classpath! htt

Re: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Casey Marshall
On Dec 11, 2006, at 8:37 AM, Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException("error instantiating default socket factory: " - + ex.toString()); That sounds more like an InternalError than the super

Re: [cp-patches] FYI: PrinterJob missing method

2006-12-11 Thread Roman Kennke
Whoops. The patch and commit have been empty. Here's the patch, the stuff is committed. > 2006-12-11 Roman Kennke <[EMAIL PROTECTED]> > > * java/awt/print/PrinterJob.java > (lookupStreamPrintServices): Uncommented and fixed parameters. /Roman Index: java/awt/print/PrinterJob.

[cp-patches] FYI: PrinterJob missing method

2006-12-11 Thread Roman Kennke
The method PrinterJob.lookupStreamPrintServices(java.lang.String) has been commented out because at that time it was missing another method. Apparantly this method is already there, so I uncommented this method and corrected the parameters a little so that we pass a public constant DocFlavor rather

[cp-patches] FYI: SystemFlavorMap stuff

2006-12-11 Thread Roman Kennke
This adds the two missing methods in SystemFlavorMap and implements the actual mapping by reading in the flavormap.properties file. I suppose there's more that we should do, but I can't make up what with only the specs at hand. 2006-12-11 Roman Kennke <[EMAIL PROTECTED]> * java/awt/data

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
David Daney wrote: > Jeroen Frijters wrote: > > David Daney wrote: > > > >> Jeroen Frijters wrote: > >> > >>> throw new RuntimeException("error > instantiating default > >>> socket factory: " > >>> - + ex.toString()); > >>> > >>>

Re: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread David Daney
Jeroen Frijters wrote: David Daney wrote: Jeroen Frijters wrote: throw new RuntimeException("error instantiating default socket factory: " - + ex.toString()); That sounds more like an InternalError than the super-generic Runt

RE: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
David Daney wrote: > Jeroen Frijters wrote: > > throw new RuntimeException("error instantiating default > > socket factory: " > > - + ex.toString()); > > > That sounds more like an InternalError than the super-generic > RuntimeException. Possi

Re: [cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread David Daney
Jeroen Frijters wrote: Hi, Committed. Regards, Jeroen 2006-12-11 Jeroen Frijters <[EMAIL PROTECTED]> * javax/net/ssl/SSLSocketFactory.java (getDefault): Chain exception cause. Index: javax/net/ssl/SSLSocketFactory.java ===

Re: [cp-patches] Re: Cleanup: Correct javadoc

2006-12-11 Thread Stefan Huehner
On Mon, Dec 11, 2006 at 03:22:22PM +, Dalibor Topic wrote: > Stefan Huehner huehner.org> writes: > > > > > Hi, > > > > attached patch correct some javadoc entries. Mostly renaming of > > parameters inside the param tag to match the actual function > > parameters. Some param statements h

[cp-patches] Re: Cleanup: Correct javadoc

2006-12-11 Thread Dalibor Topic
Stefan Huehner huehner.org> writes: > > Hi, > > attached patch correct some javadoc entries. Mostly renaming of > parameters inside the param tag to match the actual function > parameters. Some param statements have been removed to to no matching > parameter in the functions argument list.

[cp-patches] FYI: Use exception chaining in javax.net.ssl.SSLSocketFactory.getDefault()

2006-12-11 Thread Jeroen Frijters
Hi, Committed. Regards, Jeroen 2006-12-11 Jeroen Frijters <[EMAIL PROTECTED]> * javax/net/ssl/SSLSocketFactory.java (getDefault): Chain exception cause. Index: javax/net/ssl/SSLSocketFactory.java === RCS file: /c

[cp-patches] FYI: ASM in Eclipse build path

2006-12-11 Thread Roman Kennke
This includes the ASM sources in Eclipse's build path. 2006-12-11 Roman Kennke <[EMAIL PROTECTED]> * .classpath: Include ASM in Eclipse classpath. /Roman Index: .classpath === RCS file: /cvsroot/classpath/classpath/.class