[cp-patches] FYI: inheritedChannel() support

2007-04-03 Thread Roman Kennke
This has been lying around for a long time here. It implements the basic inheritedChannel() infrastructure. The default implementation can't do much more than return null (which is OK, and actually what the JDK does for me). If a VM can do something more useful here, it would have to provide its ow

Re: [cp-patches] FYI: Avoid possible NPE ByteOrder

2007-04-03 Thread Roman Kennke
Hi, > This avoids a possible NPE when the byteorder system property is not > set. Some people argued (on IRC IIRC) that we should rather let this fail if the property is not setup correcly. I think I agree and revert that like attached. 2007-04-03 Roman Kennke <[EMAIL PROTECTED]> * ja

[cp-patches] FYI: BasicTreeUI fix

2007-04-03 Thread Roman Kennke
This fixes BasicTreeUI.getPathBounds() to also consider the tree's insets, plus it adds a bunch of null checks for safety (all of this stuff is public API and can thus be overridden to return null, so...). 2007-04-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTreeUI.

[cp-patches] FYI: BasicLabelUI

2007-04-03 Thread Roman Kennke
This improves the BasicLabelUI: - It caches the Insets instance. - It makes the font metrics fetching more fail-safe. - It removes the graphics color restoring, this is already performed by Swing's painting mechanism. 2007-04-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/

[cp-patches] FYI: Metal fixlets

2007-04-03 Thread Roman Kennke
Ok, I've got to flush some older patches. These are a small bunch of minor fixes for the Metal L&F. 2007-04-03 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalButtonUI.java (paintButtonPressed): Fill the whole button not only visibleRect. * javax/swing/pla

[cp-patches] FYI: Some cvsignores

2007-04-03 Thread Roman Kennke
There were some .cvsignores missing. Here they are. 2007-04-03 Roman Kennke <[EMAIL PROTECTED]> * native/target/.cvsignore, * native/target/Linux/.cvsignore, * native/target/generic/.cvsignore: Some new ignores. /Roman -- http://kennke.org/blog/ Index: native/target/.

Re: [cp-patches] FYI: Reentrant GDK lock

2007-04-03 Thread Roman Kennke
Hi Thomas, > For now this is not enabled by default. I propose to thouroughly test > > this and make it default when things turn out to work. > > This may make sense for portableNativeSync -- have you talked to the JikesRVM > developers about this change? I don't think making it the default is

Re: [cp-patches] FYI: Font substitution

2007-04-03 Thread Francis Kung
I've run through a number of tests and have not noticed any regressions in performance or functionality, but please let me know if there are any problems. That didn't take long. This patch clears up a null pointer exception introduced by the last patch. One last one, a tiny fix for people

Re: [cp-patches] [RFA] Add ArrayValue for JDWP

2007-04-03 Thread Kyle Galloway
Keith Seitz wrote: Kyle Galloway wrote: ChangeLog 2007-04-03 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/value/ArrayValue.java: New file. Questions/comments/concerns? Looks good. Please commit. Committed, thanks. Kyle

Re: [cp-patches] [RFA] Add ArrayValue for JDWP

2007-04-03 Thread Keith Seitz
Kyle Galloway wrote: ChangeLog 2007-04-03 Kyle Galloway <[EMAIL PROTECTED]> * gnu/classpath/jdwp/value/ArrayValue.java: New file. Questions/comments/concerns? Looks good. Please commit. Keith

Re: [cp-patches] FYI: Reentrant GDK lock

2007-04-03 Thread Thomas Fitzsimmons
Hi Roman, Roman Kennke wrote: This patch makes the GDK lock reentrant. Basically it replaces the portableNativeSync functionality by a simple new implementation. As of GTK 2.4 (according to the docs), there is a function gdk_threads_set_lock_functions() which allows to define a pair of functions

Re: [cp-patches] [RFA] Add ArrayValue for JDWP

2007-04-03 Thread Kyle Galloway
Sometimes, it helps to attach a patch :-). Kyle Galloway wrote: JDWP needs to distinguish between and Object and an Array to properly get and set values, so this patch adds the ArrayValue type, which is used for this purpose. It is very similar to ObjectValue, but with a different tag value.

[cp-patches] [RFA] Add ArrayValue for JDWP

2007-04-03 Thread Kyle Galloway
JDWP needs to distinguish between and Object and an Array to properly get and set values, so this patch adds the ArrayValue type, which is used for this purpose. It is very similar to ObjectValue, but with a different tag value. ChangeLog 2007-04-03 Kyle Galloway <[EMAIL PROTECTED]> * g

[cp-patches] FYI: Reentrant GDK lock

2007-04-03 Thread Roman Kennke
This patch makes the GDK lock reentrant. Basically it replaces the portableNativeSync functionality by a simple new implementation. As of GTK 2.4 (according to the docs), there is a function gdk_threads_set_lock_functions() which allows to define a pair of functions for locking and unlocking. I imp