[cp-patches] FYI: Drop some ecj warnings (correct patch)

2008-02-17 Thread Andrew John Hughes
This patch completes the ecj warning support I added last night. I forgot to add it for both cases :( ChangeLog: 2008-02-17 Andrew John Hughes [EMAIL PROTECTED] * m4/ac_prog_javac.m4: Turn off ecj warnings for deprecation, serialization and unused imports

Re: [cp-patches] RFC: Abstract StringBuilder and StringBuffer

2008-02-17 Thread Robert Schuster
Hi Andrew, public final class StringBuilder + extends AbstractStringBuffer StringBuffer and StringBuilder have Object as their superclass. I think we are not allowed to break that. If so you should change your implementation to follow a delegation pattern and make as many methods 'final' as

Re: [cp-patches] RFC: Abstract StringBuilder and StringBuffer

2008-02-17 Thread Roman Kennke
Hi Robert, public final class StringBuilder + extends AbstractStringBuffer StringBuffer and StringBuilder have Object as their superclass. I think we are not allowed to break that. If so you should change your implementation to follow a delegation pattern and make as many methods 'final'

[cp-patches] FYI: Cleanup ecj warnings #02: Generification

2008-02-17 Thread Andrew John Hughes
This patch adds type parameters to a number of collections in the javax.swing classes. ChangeLog: 2008-02-17 Andrew John Hughes [EMAIL PROTECTED] * javax/swing/tree/FixedHeightLayoutCache.java, * javax/swing/tree/VariableHeightLayoutCache.java, *

Re: [cp-patches] RFC: Abstract StringBuilder and StringBuffer

2008-02-17 Thread Andrew John Hughes
On 17/02/2008, Roman Kennke [EMAIL PROTECTED] wrote: Hi Robert, public final class StringBuilder + extends AbstractStringBuffer StringBuffer and StringBuilder have Object as their superclass. I think we are not allowed to break that. If so you should change your implementation to

[cp-patches] FYI: Cleanup ecj warnings #02: More Swing trees

2008-02-17 Thread Andrew John Hughes
This patch fixes more of the javax.swing.tree classes adding generics and removing some obsolete code. ChangeLog: 2008-02-17 Andrew John Hughes [EMAIL PROTECTED] * javax/swing/tree/DefaultMutableTreeNode.java: Add generics. *

[cp-patches] FYI: Add missing getParameterAnnotations methods

2008-02-17 Thread Andrew John Hughes
This adds two missing methods in our VM reference implementation. These retrieve the annotations on parameters for methods and constructors, and are left for implementation by the VM. ChangeLog: 2008-02-17 Andrew John Hughes [EMAIL PROTECTED] *

[cp-patches] FYI: Fix build error with last patch

2008-02-17 Thread Andrew John Hughes
Forgot to add the imports... ChangeLog: 2008-02-17 Andrew John Hughes [EMAIL PROTECTED] * vm/reference/java/lang/reflect/Constructor.java, * vm/reference/java/lang/reflect/Method.java: Add missing java.lang.annotation.Annotation import. -- Andrew :) Support Free