Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Christian Thalinger
On Tue, 2005-11-22 at 14:07 -0500, Lillian Angel wrote: I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. I'm compiling my local classpath (on x86_64) with --enable-Werror and this patch broke it. This patched fix it. Is const

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Mark Wielaard
Hi Christian, On Fri, 2005-11-25 at 10:50 +0100, Christian Thalinger wrote: On Tue, 2005-11-22 at 14:07 -0500, Lillian Angel wrote: I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. I'm compiling my local classpath (on

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-25 Thread Lillian Angel
Thanks, I fixed this. Committed. 2005-11-25 Lillian Angel [EMAIL PROTECTED] * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c (drawString): Changed pointer to be const, and fixed check to draw characters only if they are = ' '. Handles all control

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-22 Thread Lillian Angel
I added the code to filter out non-printing characters in native, like Mark suggested. It is a lot more efficient. 2005-11-22 Lillian Angel [EMAIL PROTECTED] PR 24937 * gnu/java/awt/peer/gtk/GdkGraphics.java (drawString): Removed pattern matching code. This is now

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-21 Thread Lillian Angel
This has been approved by Tom and Roman. I re-implemented this to just use replaceAll. I know it is sometimes inefficent, so I added a FIXME. 2005-11-21 Lillian Angel [EMAIL PROTECTED] PR classpath/PR24937 * gnu/java/awt/peer/gtk/GdkGraphics.java (drawString): Removed

Re: [cp-patches] FYI: GdkGraphics fix

2005-11-21 Thread Mark Wielaard
Hi Lilian, On Mon, 2005-11-21 at 17:11 -0500, Lillian Angel wrote: I re-implemented this to just use replaceAll. I know it is sometimes inefficent, so I added a FIXME. This is really, really inefficient. +// FIXME: Possibly more characters we need to ignore/ +// Also,