Re: [cp-patches] FYI: JTable fixes and improvements

2006-05-18 Thread Roman Kennke
Hi there, This is surely required, no doubt about this. The table must support variable row heights and it did not. But now when scrolling from top to bottom, the height of the repaint region occasionaly turns negative: java.awt.Rectangle[x=0,y=465,width=34,height=-450] This is strange.

Re: [cp-patches] FYI: JTable fixes and improvements

2006-05-18 Thread Roman Kennke
Hi there again, This is surely required, no doubt about this. The table must support variable row heights and it did not. But now when scrolling from top to bottom, the height of the repaint region occasionaly turns negative: java.awt.Rectangle[x=0,y=465,width=34,height=-450] Now

Re: [cp-patches] FYI: JTable fixes and improvements

2006-05-18 Thread Roman Kennke
Ugh, I forgot to remove the old statement. 2006-05-18 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GdkGraphics.java (clipRect): Removed old intersection statement. /roman -- “Improvement makes straight roads, but the crooked roads, without Improvement, are roads of

Re: [cp-patches] FYI: JTable fixes and improvements

2006-05-18 Thread Roman Kennke
Hi again, I think, the blitting is broken again, because width=450,height=426 means that the whole table should be repainted. Another part of the problem is the following stacktrace that I get when intercepting repaint() in JTable (below). You can see that the painting of the cells goes

[cp-patches] FYI: JTable fixes and improvements

2006-05-16 Thread Roman Kennke
I fixed a couple of bugs in JTable and BasicTableUI, and added the variable row height feature. 2006-05-16 Roman Kennke [EMAIL PROTECTED] PR 26521 * javax/swing/JTable.java (rowHeights): New field. (initializeLocalVars): Call setRowHeigt instead of rowHeight=,

Re: [cp-patches] FYI: JTable fixes and improvements

2006-05-16 Thread Audrius Meskauskas
Roman Kennke wrote: I fixed a couple of bugs in JTable and BasicTableUI, and added the variable row height feature. 2006-05-16 Roman Kennke [EMAIL PROTECTED] PR 26521 * javax/swing/JTable.java (rowHeights): New field. (initializeLocalVars): Call setRowHeigt

Re: [cp-patches] FYI: JTable fixes

2006-05-07 Thread Andrew John Hughes
On Thu, 2006-05-04 at 14:13 +0200, Roman Kennke wrote: The attached patch fixes a couple of issues in JTables: - the border color for selected cells was not correct in the Metal LF - the table was not painted correctly. The grid must be painted to the right and bottom of each cell, we painted

[cp-patches] FYI: JTable fixes

2006-05-04 Thread Roman Kennke
The attached patch fixes a couple of issues in JTables: - the border color for selected cells was not correct in the Metal LF - the table was not painted correctly. The grid must be painted to the right and bottom of each cell, we painted it to the top and left - related to the previous, the cells

[cp-patches] FYI: JTable fixes

2005-11-21 Thread Roman Kennke
Hi, I fixed a bug in the JTable and its UI implementation. The UI should actually call JTable.prepareRenderer() to prepare the cell renderer, instead of preparing the renderer in the UI. Also I removed some unused code that was pointed out by Eclipse. 2005-11-21 Roman Kennke [EMAIL PROTECTED]

[cp-patches] FYI: JTable fixes

2005-09-12 Thread Roman Kennke
Hi, I tweaked JTable a bit, so that it is now possible to programatically set the column widths. I also check in some Mauve tests to back these changes. 2005-09-12 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTable.java (TableColumnPropertyChangeHandler): New inner class.

[cp-patches] FYI: JTable fixes

2005-06-24 Thread Roman Kennke
Hi, I checked in some fixes for JTable related stuff. Basically this makes sure that the columnModel and tableHeader are synced when the tableModel is changed. See ChangeLog entry for details. 2005-06-24 Roman Kennke [EMAIL PROTECTED] * javax/swing/JTable.java (constructor):