Re: [cp-patches] Minor refactoring of PrintStream

2010-12-06 Thread Pekka Enberg
Hi all, I added the following PrintStream constructor API tests to Malva: https://github.com/penberg/malva/commit/b5020c862656c491fc81b2f4f3cee39a6444709a Some of the tests fail with GNU Classpath but Ivan's patch from June cures most of the issues: http://developer.classpath.org/pipermail/clas

[cp-patches] Minor refactoring of PrintStream - resubmission

2010-06-18 Thread Ivan Maidanski
Hi! This is the updated version of my patch for PrintStream (http://comments.gmane.org/gmane.comp.java.classpath.patches/12964). ChangeLog entries: * java/io/PrintStream.java: (line_separator): Convert static field to an instance one (to match the RI functionality).

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-16 Thread Andrew John Hughes
2010/6/16 Ivan Maidanski : > Hi! > > Tue, 15 Jun 2010 21:58:02 +0200 Mario Torre : > >> Il giorno mar, 15/06/2010 alle 22.59 +0400, Ivan Maidanski ha scritto: >> > Hi! >> > >> > How fast! >> > >> > Tue, 15 Jun 2010 19:07:18 +0100 Andrew John Hughes : >> > >> > > 2010/6/15 Ivan Maidanski : >> > > >

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-16 Thread Andrew John Hughes
2010/6/15 Ivan Maidanski : > Hi! > > How fast! > > Tue, 15 Jun 2010 19:07:18 +0100 Andrew John Hughes : > >> 2010/6/15 Ivan Maidanski : >> > Hi! >> > >> > Here, the proposed changes of PrintStream are: >> > 1. to be closer to the RI behavior (see changes for line_separator, >> > out.flush(), appen

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-15 Thread Mario Torre
Il giorno mar, 15/06/2010 alle 21.58 +0200, Mario Torre ha scritto: > Actually, even in the JDK the path separator is a field in the File class > that is cached Ops, forget about this, this is not path, but line separator... Anyway, the rest of the argument stays, I don't see how this can affec

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-15 Thread Mario Torre
Il giorno mar, 15/06/2010 alle 22.59 +0400, Ivan Maidanski ha scritto: > Hi! > > How fast! > > Tue, 15 Jun 2010 19:07:18 +0100 Andrew John Hughes : > > > 2010/6/15 Ivan Maidanski : > > > Hi! > > > > > > Here, the proposed changes of PrintStream are: > > > 1. to be closer to the RI behavior (see

Re: [cp-patches] Minor refactoring of PrintStream

2010-06-15 Thread Andrew John Hughes
2010/6/15 Ivan Maidanski : > Hi! > > Here, the proposed changes of PrintStream are: > 1. to be closer to the RI behavior (see changes for line_separator, > out.flush(), append()); While some of these are sensible changes, how are you discovering the 'RI behaviour' in the cases where it wouldn't b

[cp-patches] Minor refactoring of PrintStream

2010-06-15 Thread Ivan Maidanski
Hi! Here, the proposed changes of PrintStream are: 1. to be closer to the RI behavior (see changes for line_separator, out.flush(), append()); 2. some code optimizations (like removal of writeChars() pos/len parameters). ChangeLog entries: * java/io/PrintStream.java (line_separator): Con