Re: [cp-patches] Patch: FYI: implementing missing nio method

2006-05-14 Thread Mark Wielaard
Hi Tom, On Sat, 2006-05-13 at 11:15 -0600, Tom Tromey wrote: > > "Mark" == Mark Wielaard <[EMAIL PROTECTED]> writes: > > >> 2006-05-01 Tom Tromey <[EMAIL PROTECTED]> > >> * java/nio/ByteBufferImpl.java (compact): Don't reset position > >> in empty case. > > Mark> This does introduce a mauv

Re: [cp-patches] Patch: FYI: implementing missing nio method

2006-05-13 Thread Tom Tromey
> "Mark" == Mark Wielaard <[EMAIL PROTECTED]> writes: >> 2006-05-01 Tom Tromey <[EMAIL PROTECTED]> >> * java/nio/ByteBufferImpl.java (compact): Don't reset position >> in empty case. Mark> This does introduce a mauve regression. Sorry about that. Mark> Could you take a look? Fixed as app

Re: [cp-patches] Patch: FYI: implementing missing nio method

2006-05-10 Thread Mark Wielaard
Hi Tom, On Mon, 2006-05-01 at 16:32 -0600, Tom Tromey wrote: > It also fixes a systematic bug in the 'compact' methods > > 2006-05-01 Tom Tromey <[EMAIL PROTECTED]> > > * java/nio/ByteBufferImpl.java (compact): Don't reset position > in empty case. This does introduce a mauve regr

[cp-patches] Patch: FYI: implementing missing nio method

2006-05-01 Thread Tom Tromey
I'm checking this in. This implements a missing java.nio method. It also fixes a systematic bug in the 'compact' methods, and adds the appropriate locking to ChannelReader. Tom 2006-05-01 Tom Tromey <[EMAIL PROTECTED]> * java/nio/ByteBufferImpl.java (compact): Don't reset position