Anthony == Anthony Green [EMAIL PROTECTED] writes:
Anthony Here's a virtually complete javax.sound.midi implementation.
Anthony No providers yet.
Anthony Ok?
I took a quick look through this.
I think this is looking great. I think it is OK to go in.
First though, some minor nits, one real
On Mon, 2005-09-26 at 09:48 -0600, Tom Tromey wrote:
I think this is looking great. I think it is OK to go in.
Thanks. I'll do that.
I think @author should have your full name, like:
@author Anthony Green ([EMAIL PROTECTED])
Each class' javadoc should say '@since 1.3'.
Ok, I've
Anthony This doesn't quite work because ShortMessage's parent
Anthony declares an abstract clone(), so you can't super.clone() it.
Anthony Perhaps they did this to force the implementation method I
Anthony chose.
Ok, thanks. How amazingly lame.
Tom
On Mon, 2005-09-26 at 09:48 -0600, Tom Tromey wrote:
There are one or two places where the code goes past column 79.
(I'm not super concerned about this. I think we need a reformatting
flag day anyway.)
I've cleaned most of these up in the attached patch. This patch also
removes the
Here's a virtually complete javax.sound.midi implementation. No
providers yet.
Ok?
AG
2005-09-25 Anthony Green [EMAIL PROTECTED]
* javax/sound/midi/InvalidMidiDataException.java
javax/sound/midi/MidiFileFormat.java
javax/sound/midi/ControllerEventListener.java
