Re: [cp-patches] RFC: Combo box mouseclick

2006-06-14 Thread Roman Kennke
Hi Francis, Am Mittwoch, den 14.06.2006, 12:05 -0400 schrieb Francis Kung: > Thanks Roman; I didn't know that would work - the MenuSelectionManager > is smarter than I thought! =) > > Attached is a patch to finish it up; I'll commit it if there are no > objections. Yes, please go ahead! /Roman

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-14 Thread Francis Kung
Thanks Roman; I didn't know that would work - the MenuSelectionManager is smarter than I thought! =) Attached is a patch to finish it up; I'll commit it if there are no objections. Francis 2006-06-14 Francis Kung <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicArrowButton.java:

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-13 Thread Roman Kennke
Hi Francis, > After talking to rkennke, here is an alternate implementation to fix the > same bug, which does not involve removing and re-adding listeners, nor > consuming the mouseclick event (since this breaks other functionality). What I meant was something along the line of the attached patch

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-13 Thread Francis Kung
After talking to rkennke, here is an alternate implementation to fix the same bug, which does not involve removing and re-adding listeners, nor consuming the mouseclick event (since this breaks other functionality). Regards, Francis 2006-06-13 Francis Kung <[EMAIL PROTECTED]> * javax/s

Re: [cp-patches] RFC: Combo box mouseclick

2006-06-12 Thread Thomas Fitzsimmons
Hi, Francis Kung wrote: Not sure how to write a mauve test, since it must simulate a mouseclick on a specific component's location... You can use java.awt.Robot for this. There are already tests in Mauve that use Robot, for example gnu.testlet.java.awt.Frame.size1. Tom

[cp-patches] RFC: Combo box mouseclick

2006-06-12 Thread Francis Kung
Hi, Please find attached a patch to fix mouseclick actions in the JComboBox. Previously, if you clicked on the combo box button while the popup menu was already open, it would close and immediately re-open the popup; this was caused by two listeners both catching the mouseclick and both toggling