Re: [cp-patches] RFC: misc NIO fixes

2005-07-27 Thread Casey Marshall
Attached is a patch that fixes the warnings in the NIO files I changed, and fixes the problem on Darwin (adding the 'volatile' keyword to the MappedByteBufferImpl instance we create and return appears to fix this). A bug in GCC 4.0 on that platform, perhaps? I can't test this properly

Re: [cp-patches] RFC: misc NIO fixes

2005-07-26 Thread Mark Wielaard
Hi, On Sat, 2005-07-23 at 20:37 -0700, Casey Marshall wrote: Committed. I changed a few minor things, such as using Mark's suggestion to use 'madvise' to load the file into core. I can't get this to work with Jamvm on Darwin; I get a bizarre segfault when trying to create the new

Re: [cp-patches] RFC: misc NIO fixes

2005-07-23 Thread Casey Marshall
Committed. I changed a few minor things, such as using Mark's suggestion to use 'madvise' to load the file into core. I can't get this to work with Jamvm on Darwin; I get a bizarre segfault when trying to create the new MappedByteBufferImpl, and apparently 'mincore' does not work properly

Re: [cp-patches] RFC: misc NIO fixes

2005-07-21 Thread Mark Wielaard
Hi, On Tue, 2005-07-19 at 09:12 -0500, Archie Cobbs wrote: Casey Marshall wrote: Attached is a patch I'd like to get some comments on, before I check it in, especially if anyone can spot holes in my C. This patch + /* FIXME: I'd bet dollars for donuts the compiler optimizes this +

Re: [cp-patches] RFC: misc NIO fixes

2005-07-21 Thread Casey Marshall
On Jul 21, 2005, at 3:04 PM, Mark Wielaard wrote: Hi, On Tue, 2005-07-19 at 09:12 -0500, Archie Cobbs wrote: Casey Marshall wrote: Attached is a patch I'd like to get some comments on, before I check it in, especially if anyone can spot holes in my C. This patch + /* FIXME: I'd

Re: [cp-patches] RFC: misc NIO fixes

2005-07-19 Thread Archie Cobbs
Casey Marshall wrote: Attached is a patch I'd like to get some comments on, before I check it in, especially if anyone can spot holes in my C. This patch + /* FIXME: I'd bet dollars for donuts the compiler optimizes this + away. How can we load memory into core??? */ + for (i = 0; i