Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v9]

2021-11-18 Thread Laurent Bourgès
On Wed, 17 Nov 2021 08:53:07 GMT, Jeremy wrote: >> This removes code that relied on consulting the Bezier control points to >> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward >> to convert the Bezier control points into the x & y parametric equations. At >> their m

RFR: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits

2021-11-18 Thread Alexander Zuev
Made colorBits and maskBits arrays dynamic so they are allocated on heap instead of stack. Added regression test. - Commit messages: - 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits Changes: https://git.openjdk.java.net/jdk/pull/6473/files Webrev: http

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v4]

2021-11-18 Thread Alexander Zuev
On Wed, 17 Nov 2021 18:55:20 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

2021-11-18 Thread Prasanta Sadhukhan
On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov wrote: > It's a little cleanup: make sure `frame` is accessed from EDT only, remove > unused variables and imports. I am not sure on this as those 100+ tests which accesses frame variable outside EDT before it calls dispose is not failing in CI

Re: RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v3]

2021-11-18 Thread Toshio Nakamura
On Thu, 21 Oct 2021 00:57:47 GMT, Toshio Nakamura wrote: >> Hi, >> >> Could you review the fix? >> When non-English characters were printed from JTable on MacOS, >> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, >> CTextPipe seems not support glyph with slot number of

RFR: JDK-8276447 Deprecate finalization-related methods for removal

2021-11-18 Thread Brent Christian
Here are the code changes for the "Deprecate finalizers in the standard Java API" portion of JEP 421 ("Deprecate Finalization for Removal") for code review. This change makes the indicated deprecations, and updates the API spec for JEP 421. It also updates the relevant @SuppressWarning annotatio

Re: RFR: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

2021-11-18 Thread Victor Dyakov
On Thu, 18 Nov 2021 19:04:05 GMT, Alexander Zuev wrote: > Add component accessibility peer @forantar please review @pankaj-bansal please review - PR: https://git.openjdk.java.net/jdk/pull/6462

RFR: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer

2021-11-18 Thread Alexander Zuev
Add component accessibility peer - Commit messages: - JDK-8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer Changes: https://git.openjdk.java.net/jdk/pull/6462/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6462&range=00 Issue: https:

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-18 Thread Andrey Turbanov
On Thu, 18 Nov 2021 05:36:29 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274893: Update java.desktop classes to use try-with-resources >> fix review comments > > src/java.desktop/shar

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v3]

2021-11-18 Thread Andrey Turbanov
> 8274893: Update java.desktop classes to use try-with-resources Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8274893: Update java.desktop classes to use try-with-resources fix review comments - Changes: - all:

Re: RFR: 8274893: Update java.desktop classes to use try-with-resources [v2]

2021-11-18 Thread Andrey Turbanov
On Thu, 18 Nov 2021 05:30:59 GMT, Sergey Bylokhov wrote: >> Andrey Turbanov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8274893: Update java.desktop classes to use try-with-resources >>close nested resources too >> - [PATCH] U

Integrated: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-18 Thread Sergey Bylokhov
On Wed, 10 Nov 2021 18:45:12 GMT, Sergey Bylokhov wrote: > The bug occurs more often if initially the window is moved partly outside of > the first screen(let's name this part as the invisible part), and then slowly > moved to the second screen where that invisible part became visible on the >

Re: RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

2021-11-18 Thread Alexey Ivanov
On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov wrote: > It's a little cleanup: make sure `frame` is accessed from EDT only, remove > unused variables and imports. I've been working with this test, I found what seemed wrong and so I decided to fix it. I'm sure there are many tests which acces

Integrated: 8275071: [macos] A11y cursor gets stuck when combobox is closed

2021-11-18 Thread Alexander Zuev
On Wed, 17 Nov 2021 00:57:47 GMT, Alexander Zuev wrote: > Before the new JList accessibility peer implementation sending popup closed > event to the combobox popup could trigger the native memory access error due > to the events arriving in the wrong order. After new implementation is done > it i

Re: RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

2021-11-18 Thread Prasanta Sadhukhan
On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov wrote: > It's a little cleanup: make sure `frame` is accessed from EDT only, remove > unused variables and imports. I guess there's probably 100+ tests in swing that access frame outside EDT before it calls dispose ex. Action/8133039/bug8133039

Re: Integrated: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058

2021-11-18 Thread Daniel D . Daugherty
On Thu, 18 Nov 2021 15:09:34 GMT, Prasanta Sadhukhan wrote: > Fixed compilation issue. Single char typo. Wow. Thumbs up. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6458

Integrated: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058

2021-11-18 Thread Prasanta Sadhukhan
On Thu, 18 Nov 2021 15:09:34 GMT, Prasanta Sadhukhan wrote: > Fixed compilation issue. This pull request has now been integrated. Changeset: 276bfcd1 Author:Prasanta Sadhukhan URL: https://git.openjdk.java.net/jdk/commit/276bfcd1a115f90dde644abef79d64bb61788c75 Stats: 1 line in

Integrated: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058

2021-11-18 Thread Prasanta Sadhukhan
Fixed compilation issue. - Commit messages: - 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058 Changes: https://git.openjdk.java.net/jdk/pull/6458/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6458&range=00 Is

RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

2021-11-18 Thread Alexey Ivanov
It's a little cleanup: make sure `frame` is accessed from EDT only, remove unused variables and imports. - Commit messages: - JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread Changes: https://git.openjdk.java.net/jdk/pull/6455/files W

Re: RFR: JDK-8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread

2021-11-18 Thread Alexey Ivanov
On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov wrote: > It's a little cleanup: make sure `frame` is accessed from EDT only, remove > unused variables and imports. test/jdk/javax/swing/DefaultButtonModel/DefaultButtonModelCrashTest.java line 24: > 22: */ > 23: > 24: /* With double asterisk

Integrated: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-18 Thread Andrey Turbanov
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.ba