Integrated: 8279673: AudioClip.play doesn't work due to NullPointerException when creating DataPusher

2022-01-26 Thread Andrey Turbanov
On Sun, 14 Nov 2021 20:02:27 GMT, Andrey Turbanov wrote: > There is possible NPE, when trying to play AudioClip > > import java.applet.AudioClip; > import java.io.IOException; > import java.net.URL; > > > public class AudioNpe { > public static void main(String[] args) throws IOException,

Re: RFR: 8278254: Cleanup doclint warnings in java.desktop module [v5]

2022-01-26 Thread Prasanta Sadhukhan
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan wrote: >> The changes done under JDK-8278175 suppress on a per-file basis various >> missing comments that would otherwise trigger doclint warnings. Fixed them >> so as to remove the doclint:missing warnings. > > Prasanta Sadhukhan has updat

Re: RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn [v2]

2022-01-26 Thread Toshio Nakamura
On Thu, 27 Jan 2022 00:36:54 GMT, Phil Race wrote: >> Toshio Nakamura has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Applied review comments > > Looks so much better. Thank you for reviewing, @prrace @mrserb. Updated the patch. This te

Re: RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn [v2]

2022-01-26 Thread Toshio Nakamura
> JInternalFrame's bottom area is not properly drawn with Aqua LAF. > This problem remained for long time, but we recognized it recently. > > According to the bug report, it depends on MacOS's version. I don't have old > ones (10.10 and 10.11 in the report), but the current MacOS can recreate the

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-26 Thread Phil Race
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

2022-01-26 Thread Phil Race
On Thu, 27 Jan 2022 02:37:01 GMT, Sergey Bylokhov wrote: > I am still not sure can we do something about this, depending on that we > should update the test/problem list/file another client bug/another hotspot > bug? I can't work out what you are saying/expecting. The test is nothing to do wit

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-26 Thread Phil Race
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

2022-01-26 Thread Sergey Bylokhov
On Fri, 14 Jan 2022 19:09:53 GMT, Phil Race wrote: > Some more signal handler related warning strings from the VM need to be > excluded from what this test considers a failure > > See the bug for more info. I am still not sure can we do something about this, depending on that we should updat

Re: RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn

2022-01-26 Thread Sergey Bylokhov
On Wed, 26 Jan 2022 06:53:42 GMT, Toshio Nakamura wrote: > JInternalFrame's bottom area is not properly drawn with Aqua LAF. > This problem remained for long time, but we recognized it recently. > > According to the bug report, it depends on MacOS's version. I don't have old > ones (10.10 and 1

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-26 Thread Victor Dyakov
On Wed, 26 Jan 2022 00:12:17 GMT, Harshitha Onkar wrote: > A new test case was added to test the fix as there was no corresponding test > case present for this issue previously. @prsadhuk please review - PR: https://git.openjdk.java.net/jdk/pull/7219

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-26 Thread Sergey Bylokhov
On Wed, 26 Jan 2022 00:12:17 GMT, Harshitha Onkar wrote: > A new test case was added to test the fix as there was no corresponding test > case present for this issue previously. src/java.desktop/macosx/classes/com/apple/laf/AquaTableHeaderBorder.java line 2: > 1: /* > 2: * Copyright (c) 2011,

RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-26 Thread Harshitha Onkar
A new test case was added to test the fix as there was no corresponding test case present for this issue previously. - Commit messages: - incorporated review changes - removed jtreg author tag - added copyright year and removed commented lines - Merge branch 'master' into JTableH

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader

2022-01-26 Thread Harshitha Onkar
On Wed, 26 Jan 2022 20:29:47 GMT, Sergey Bylokhov wrote: >> A new test case was added to test the fix as there was no corresponding test >> case present for this issue previously. > > src/java.desktop/macosx/classes/com/apple/laf/AquaTableHeaderBorder.java line > 2: > >> 1: /* >> 2: * Copyrig

Re: RFR: 8139173: [macosx] JInternalFrame shadow is not properly drawn

2022-01-26 Thread Phil Race
On Wed, 26 Jan 2022 06:53:42 GMT, Toshio Nakamura wrote: > JInternalFrame's bottom area is not properly drawn with Aqua LAF. > This problem remained for long time, but we recognized it recently. > > According to the bug report, it depends on MacOS's version. I don't have old > ones (10.10 and 1

Re: RFR: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

2022-01-26 Thread Phil Race
On Fri, 14 Jan 2022 19:09:53 GMT, Phil Race wrote: > Some more signal handler related warning strings from the VM need to be > excluded from what this test considers a failure > > See the bug for more info. The discussion seems to have gone off somewhere unrelated to this client test. Feel fr

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-26 Thread Phil Race
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-26 Thread Alexey Ivanov
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2022-01-26 Thread Alexey Ivanov
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

2022-01-26 Thread Sergey Bylokhov
On Fri, 14 Jan 2022 19:09:53 GMT, Phil Race wrote: > Some more signal handler related warning strings from the VM need to be > excluded from what this test considers a failure > > See the bug for more info. Probably we have some tests which may validate that even if our handlers are not defa