On Mon, 21 Feb 2022 05:12:44 GMT, Toshio Nakamura wrote:
>> Hi,
>>
>> Could you review the fix?
>> When non-English characters were printed from JTable on MacOS,
>> CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However,
>> CTextPipe seems not support glyph with slot number of
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote:
> - The hand-crafted methods for addition and multiplication are replaced by
> the "Math" versions.
> - Cleanup: the usage of do/while(false) is removed
not now
-
PR: https://git.openjdk.java.net/jdk/pull/
On Wed, 9 Mar 2022 16:11:02 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug. The bug consists in
>> the fact that When an assistive technology software by means of Java Access
>> Bridge API executes "AccessibleAction" "click" on "AccessibleConte
On Thu, 10 Mar 2022 04:15:14 GMT, Phil Race wrote:
>> As per the bug eval, we are returning a pointer to a native raw LittleCMS
>> profile and it should be a cooked one.
>> The simple test fails before the fix with
>> ~/jdk17/Contents/Home/bin/java SetTagDataValidation
On Mon, 7 Mar 2022 23:47:42 GMT, Rajat Mahajan wrote:
> 8249592 : Robot.mouseMove moves cursor to incorrect location when display
> scale varies and Java runs in DPI Unaware mode
This pull request has now been integrated.
Changeset: 8aba4de9
Author:Rajat Mahajan
Committer: Sergey Bylokhov
On Thu, 10 Mar 2022 04:15:14 GMT, Phil Race wrote:
>> As per the bug eval, we are returning a pointer to a native raw LittleCMS
>> profile and it should be a cooked one.
>> The simple test fails before the fix with
>> ~/jdk17/Contents/Home/bin/java SetTagDataValidation
Removed the println() line from the Interrupted catch block. Since waitForID()
Interrupt indicates completion of Image Loading, println as Interrupt handling
was not required.
-
Commit messages:
- 8236987: Remove call to System.out.println from ImageIcon.loadImage
- 8236987: Remov
On Thu, 10 Mar 2022 04:15:14 GMT, Phil Race wrote:
>> As per the bug eval, we are returning a pointer to a native raw LittleCMS
>> profile and it should be a cooked one.
>> The simple test fails before the fix with
>> ~/jdk17/Contents/Home/bin/java SetTagDataValidation
On Thu, 10 Mar 2022 04:15:14 GMT, Phil Race wrote:
>> As per the bug eval, we are returning a pointer to a native raw LittleCMS
>> profile and it should be a cooked one.
>> The simple test fails before the fix with
>> ~/jdk17/Contents/Home/bin/java SetTagDataValidation
> As per the bug eval, we are returning a pointer to a native raw LittleCMS
> profile and it should be a cooked one.
> The simple test fails before the fix with
> ~/jdk17/Contents/Home/bin/java SetTagDataValidation
>
> Exception in thread "main" java.awt.color.CMMEx
Previously while tabbing through the JTable cell, the cell highlighter/focus
ring was not visible against the selection background.
Changes were made to Aqua LAF to derive a brighter focus ring color by changing
hue, saturation and brightness of selection background color so that it is
visible
On Thu, 3 Mar 2022 21:27:36 GMT, Phil Race wrote:
>> As per the bug eval, we are returning a pointer to a native raw LittleCMS
>> profile and it should be a cooked one.
>> The simple test fails before the fix with
>> ~/jdk17/Contents/Home/bin/java SetTagDataValidation
>
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For the bundles in java.xml:
For files with Oracle copyright, update the year to 2022 and @LastModified Mar
2022. Take XPATHErrorResources_ja.java as an example, the copyright year was
updated to 2021 and @
On Wed, 9 Mar 2022 13:35:44 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/op
On Wed, 9 Mar 2022 16:11:02 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug. The bug consists in
>> the fact that When an assistive technology software by means of Java Access
>> Bridge API executes "AccessibleAction" "click" on "AccessibleConte
On Wed, 9 Mar 2022 22:19:53 GMT, Phil Race wrote:
> One way to "save" the test is that after doing the validation which calls
> cmsReadTag() and get an "OK" we discard this profile and create ANOTHER copy
> which we return to the app. Since nothing will have cooked that new profile
> data it w
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
`src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties`
`src/java.base/share/classes/sun/util/resources/CurrencyNames_ja.properties`
`src/java.base/share/classes/sun/util/resources/Currenc
On Tue, 8 Mar 2022 04:09:23 GMT, Sergey Bylokhov wrote:
> The current bug looks similar to this one
> https://bugs.openjdk.java.net/browse/JDK-8272865 I tried to fix it the same
> way but I was not sure if it is safe to ignore the ReadWriteProfileTest.java
> or not, since it has five related b
On Wed, 9 Mar 2022 22:20:08 GMT, Phil Race wrote:
>> src/java.desktop/share/native/liblcms/LCMS.c line 765:
>>
>>> 763: // The profile we used for sanity checking needs to be returned
>>> 764: // since the one we updated is raw - not cooked.
>>> 765: cmsCloseProfile(p);
>
On Tue, 8 Mar 2022 05:10:51 GMT, lawrence.andrews wrote:
>> Following methods are covered in this testcase
>> getAccessibleAction()
>> getAccessibleActionCount()
>> getAccessibleActionDescription()
>> doAccessibleAction(int direction)
>>
>> @shurymury
>
> lawrence.andrews has updated the pull r
On Tue, 8 Mar 2022 05:10:51 GMT, lawrence.andrews wrote:
>> Following methods are covered in this testcase
>> getAccessibleAction()
>> getAccessibleActionCount()
>> getAccessibleActionDescription()
>> doAccessibleAction(int direction)
>>
>> @shurymury
>
> lawrence.andrews has updated the pull r
msg drop for jdk19, Mar 9, 2022
-
Commit messages:
- open jdk19 l10n msg drop
Changes: https://git.openjdk.java.net/jdk/pull/7765/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7765&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8280400
Stats: 13775 lines
On Wed, 9 Mar 2022 20:37:50 GMT, Alexandre Iline wrote:
> @azuev-java what do you think be a better location for this test?
> javax/swing/JSlider/8262981 or somewhere in javax/accessibility?
I'd say let's group them up somewhere in accessibility folder so they can be
ran easier as a bundle ins
On Tue, 8 Mar 2022 05:13:44 GMT, lawrence.andrews wrote:
>> This testcase covers both old and new api ( api added in jdk17
>> getAccessibleAction(), getAccessibleActionCount() ,
>> getAccessibleActionDescription )
>>
>> @shurymury
>> @savoptik
>
> lawrence.andrews has updated the pull reques
On Tue, 8 Mar 2022 05:10:51 GMT, lawrence.andrews wrote:
>> Following methods are covered in this testcase
>> getAccessibleAction()
>> getAccessibleActionCount()
>> getAccessibleActionDescription()
>> doAccessibleAction(int direction)
>>
>> @shurymury
>
> lawrence.andrews has updated the pull r
On Wed, 9 Mar 2022 16:11:02 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug. The bug consists in
>> the fact that When an assistive technology software by means of Java Access
>> Bridge API executes "AccessibleAction" "click" on "AccessibleConte
On Wed, 9 Mar 2022 16:11:02 GMT, Anton Litvinov wrote:
>> Hello,
>>
>> Could you please review the following fix for the bug. The bug consists in
>> the fact that When an assistive technology software by means of Java Access
>> Bridge API executes "AccessibleAction" "click" on "AccessibleConte
> Hello,
>
> Could you please review the following fix for the bug. The bug consists in
> the fact that When an assistive technology software by means of Java Access
> Bridge API executes "AccessibleAction" "click" on "AccessibleContext" which
> corresponds to "javax.swing.JTable" cell containi
On Wed, 9 Mar 2022 14:22:30 GMT, Alexey Ivanov wrote:
> Does it make sense to run all the checks before throwing the exception?
>
> I mean run all the checks that the test performs and accumulate failures if
> any. If the list of failures isn't empty, throw an exception to fail the
> entire te
On Tue, 8 Mar 2022 18:26:59 GMT, Rajat Mahajan wrote:
>> 8249592 : Robot.mouseMove moves cursor to incorrect location when display
>> scale varies and Java runs in DPI Unaware mode
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
On Wed, 9 Mar 2022 13:35:44 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/op
On Wed, 9 Mar 2022 11:02:08 GMT, Alexey Ivanov wrote:
>>> @aivanov-jdk Thanks for re-running the test. Where does this failure come
>>> from - Linux or Windows? The saved image's size is correct (400x300 px),
>>> but I can't explain the location of the painted area inside it and why it
>>> is
On Mon, 21 Feb 2022 21:03:05 GMT, Alexey Ivanov wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments fixed: file name changed, volatile dimension, static call
>> to doTest
>
> Changes requested by
On Wed, 9 Mar 2022 09:38:51 GMT, Alexey Ivanov wrote:
> > You're right. The old icon handles in `hOldIcon` and `hOldIconSm` will be
> > leaked here if `CreateIconFromRaster` throws an exception.
>
> I've submitted
> [JDK-8282862](https://bugs.openjdk.java.net/browse/JDK-8282862):
> AwtWindow:
On Wed, 9 Mar 2022 11:02:08 GMT, Alexey Ivanov wrote:
>>> @aivanov-jdk Thanks for re-running the test. Where does this failure come
>>> from - Linux or Windows? The saved image's size is correct (400x300 px),
>>> but I can't explain the location of the painted area inside it and why it
>>> is
> The two tests `ScreenCaptureGtkTest.java` and
> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
> started to intermittently fail under Windows and Linux after the [recent
> changes](https://github.com/openjdk/jdk/commit/cc7cf81256ed4d74493472017b1c4df20fa2208a)
>
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
This pull request has now been integrated.
Changeset: 5df2a057
On Wed, 9 Mar 2022 06:53:29 GMT, Thomas Stuefe wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> mrserb and aivanov-jdk's comments
>
> Still looks good to me.
Thanks for the review and suggestions, @tstuefe, @dholmes
On Tue, 8 Mar 2022 15:54:45 GMT, Zhengyu Gu wrote:
>> Please review this small patch that fixes a potential memory leak that
>> exception return fails to release allocated `cacheDirs`
>>
>> Test:
>>
>> - [x] jdk_desktop on Linux x86_64
>
> Zhengyu Gu has updated the pull request incrementally
On Wed, 9 Mar 2022 10:32:26 GMT, Alexey Ivanov wrote:
> Shouldn't the image be larger than 400×300? The size of the frame is 400×300
> in user's space, the test is running with uiScaleX=3 and uiScaleY=2,
> therefore the size of the frame should be 1200×600. In some cases, such a
> size may not
On Tue, 8 Mar 2022 16:10:02 GMT, Alexey Ivanov wrote:
>>> > I submitted a job for testing the changes.
>>>
>>> Thanks a lot!
>>
>> I got 1 failure out of 15 on Linux for
>> `java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java`. The
>> screenshot of the entire screen has no open
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote:
>> The proposed fix makes fonts with and without fallback components
>> distinguishable (in terms of `equals` method), so that
>> font metrics cache (and other similar code) can handle them separately. This
>> is achieved by adding a new boo
On Tue, 8 Mar 2022 16:10:02 GMT, Alexey Ivanov wrote:
>>> > I submitted a job for testing the changes.
>>>
>>> Thanks a lot!
>>
>> I got 1 failure out of 15 on Linux for
>> `java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java`. The
>> screenshot of the entire screen has no open
On Tue, 8 Mar 2022 20:47:45 GMT, Alexey Ivanov wrote:
> You're right. The old icon handles in `hOldIcon` and `hOldIconSm` will be
> leaked here if `CreateIconFromRaster` throws an exception.
I've submitted [JDK-8282862](https://bugs.openjdk.java.net/browse/JDK-8282862):
AwtWindow::SetIconData
On Tue, 8 Mar 2022 15:54:45 GMT, Zhengyu Gu wrote:
>> Please review this small patch that fixes a potential memory leak that
>> exception return fails to release allocated `cacheDirs`
>>
>> Test:
>>
>> - [x] jdk_desktop on Linux x86_64
>
> Zhengyu Gu has updated the pull request incrementally
Create a regression test for
[JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690)
In many cases in Swing it is possible to easily programatically determine that
a JScrollBar (or two) is scrolling some JPanel (the cannonical case is a
JScrollPane).
In these cases, when accessibility s
46 matches
Mail list logo
