Re: RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails

2022-04-29 Thread Sergey Bylokhov
On Thu, 28 Apr 2022 09:11:19 GMT, DamonGuy wrote: > Closed repo test fix from the test sprint. This test was approved in the > closed repo and has been converted to an open repo test. > > This test checks if the coordinates are still correct after changing focuses > between different JInternal

RFR: 8285867 : Convert applet manual tests SelectionVisible.java to Frame and automate

2022-04-29 Thread lawrence . andrews
1) Removed Applet dependent code and used Frame as top level. 2) Automated the manual test. @shurymury - Commit messages: - 8285867 : Convert applet manual tests SelectionVisible.java to Frame and automate Changes: https://git.openjdk.java.net/jdk/pull/8477/files Webrev: https://

Re: RFR: 8285687 : Remove jtreg tag manual=yesno for ava/awt/print/PrinterJob/PageRangesDlgTest.java [v5]

2022-04-29 Thread lawrence . andrews
> 1) Fixed Parser error by removing yesno from @run main/manual=yesno > 2) Used PassFaileJFrame to show the test instruction to the user instead of > printing the test instruction on the console or jtreg log file. > 3) If printer is not configured then mark the test as passed. > > @shurymury

Integrated: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails

2022-04-29 Thread DamonGuy
On Thu, 28 Apr 2022 09:11:19 GMT, DamonGuy wrote: > Closed repo test fix from the test sprint. This test was approved in the > closed repo and has been converted to an open repo test. > > This test checks if the coordinates are still correct after changing focuses > between different JInternal

Re: RFR: 8285687 : Remove jtreg tag manual=yesno for ava/awt/print/PrinterJob/PageRangesDlgTest.java [v4]

2022-04-29 Thread lawrence . andrews
> 1) Fixed Parser error by removing yesno from @run main/manual=yesno > 2) Used PassFaileJFrame to show the test instruction to the user instead of > printing the test instruction on the console or jtreg log file. > 3) If printer is not configured then mark the test as passed. > > @shurymury

Re: RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails

2022-04-29 Thread Alexander Zuev
On Thu, 28 Apr 2022 09:11:19 GMT, DamonGuy wrote: > Closed repo test fix from the test sprint. This test was approved in the > closed repo and has been converted to an open repo test. > > This test checks if the coordinates are still correct after changing focuses > between different JInternal

Re: RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails

2022-04-29 Thread DamonGuy
On Thu, 28 Apr 2022 22:42:33 GMT, Sergey Bylokhov wrote: > Please confirm that the mach5 is green for the few iterations. I ran the test locally 50 times and it all passed. I also ran the test in mach5 with repeats and it all passed as well. Added results to JBS. - PR: https://git

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-04-29 Thread Phil Race
On Wed, 27 Apr 2022 18:52:46 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails

2022-04-29 Thread Phil Race
On Thu, 28 Apr 2022 09:11:19 GMT, DamonGuy wrote: > Closed repo test fix from the test sprint. This test was approved in the > closed repo and has been converted to an open repo test. > > This test checks if the coordinates are still correct after changing focuses > between different JInternal

Re: RFR: 8285687 : Remove jtreg tag manual=yesno for ava/awt/print/PrinterJob/PageRangesDlgTest.java [v3]

2022-04-29 Thread Phil Race
On Thu, 28 Apr 2022 22:29:51 GMT, lawrence.andrews wrote: >> 1) Fixed Parser error by removing yesno from @run main/manual=yesno >> 2) Used PassFaileJFrame to show the test instruction to the user instead of >> printing the test instruction on the console or jtreg log file. >> 3) If printer

Integrated: 8285686: Upgrade to FreeType 2.12.0

2022-04-29 Thread Phil Race
On Thu, 28 Apr 2022 19:41:46 GMT, Phil Race wrote: > This upgrades the JDK from using freetype 2.10.4 to 2.12.0 > Automated tests pass, manual testing looks fine. > --with-freetype=bundled was used to make sure it is OK on Linux builds. This pull request has now been integrated. Changeset: 67dd

Re: RFR: 8285373: Create an automated test for JDK-4702233 [v2]

2022-04-29 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233) > > Several new AccessibleRole and AccessibleRelation constants are needed in > those classes in the java.accessibility package. These new contants codify > additions made in the GNOME, Netscape, an

Re: RFR: 8284680: sun.font.FontConfigManager.getFontConfig() leaks charset [v2]

2022-04-29 Thread Zhengyu Gu
> Please review this small patch that releases temporary charsets to avoid > memory leak. > > Test: > > - [x] jdk_2d Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision: Andrew's comment - Changes: - all: https://git.openj

Integrated: 8274597: Some of the dnd tests time out and fail intermittently

2022-04-29 Thread Manukumar V S
On Wed, 20 Apr 2022 13:03:48 GMT, Manukumar V S wrote: > These dnd tests fails with a time out intermittently in some machines(mostly > Windows 11) which creates frequent noise in CI. > 1. java/awt/dnd/AcceptDropMultipleTimes/AcceptDropMultipleTimes.java > 2. java/awt/dnd/DropTargetEnterExitTest

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces [v5]

2022-04-29 Thread Pavel Rappo
On Fri, 29 Apr 2022 08:45:42 GMT, Pavel Rappo wrote: > Good catch. Sorry I missed it. This occurs in all `java/lang/ref` files. I've created a PR; feel free to review it at your convenience. - PR: https://git.openjdk.java.net/jdk/pull/8410

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces [v5]

2022-04-29 Thread Pavel Rappo
On Thu, 28 Apr 2022 19:06:04 GMT, Mandy Chung wrote: >> src/java.base/share/classes/java/lang/ref/PhantomReference.java line 48: >> >>> 46: * The {@link #refersTo(Object) refersTo} method can be used to test >>> 47: * whether some object is the referent of a phantom reference. >>> 48: * @para

Re: RFR: 8274597: Some of the dnd tests time out and fail intermittently [v5]

2022-04-29 Thread Manukumar V S
> These dnd tests fails with a time out intermittently in some machines(mostly > Windows 11) which creates frequent noise in CI. > 1. java/awt/dnd/AcceptDropMultipleTimes/AcceptDropMultipleTimes.java > 2. java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java > 3. java/awt/dnd/DropTargetEnte

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-29 Thread Matthias Baesken
On Fri, 29 Apr 2022 05:09:35 GMT, David Holmes wrote: > That only seems to be half of the issue though. If we are defining > _WIN32_WINNT=0x0601 because the minimum required OS API support level is > Windows 7, then don't we need a check that the build platform is also at > least Windows 7? H